Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 02 2017 03:34

    jedateach on 1.1.0

    (compare)

  • Aug 02 2017 03:29

    jedateach on master

    Introduced gulp for front-end a… Gruntfile fixes Removed compiled assets. These … and 1 more (compare)

  • Nov 06 2016 05:45
    SilbinaryWolf opened #7
  • Oct 09 2015 23:00

    jedateach on master

    Introduced 'field' class onto F… (compare)

  • Oct 06 2015 07:59

    jedateach on master

    Minor updates (compare)

  • Oct 06 2015 07:53

    jedateach on master

    Added CheckoutPage_order templa… added gap to cart footer Only show steps if they exist (… (compare)

  • Oct 05 2015 07:42

    jedateach on master

    Refactored gruntfile.js to allo… Removed custom code Introduced gulpfile alternative… (compare)

  • Oct 04 2015 04:08

    jedateach on master

    Introduced (and made use of) a … (compare)

  • Oct 03 2015 00:50

    jedateach on master

    Better breakpoint sizes for Sec… Optionally include link to acc… Added extra bootstrap-style cla… and 2 more (compare)

Jeremy Shipman
@jedateach
precompilation is just mandatory these days
Anselm Christophersen
@anselmdk
yeah!
just created a pull request for some indentation
Anselm Christophersen
@anselmdk
In general I like that you’re adding some nice libraries to get started out with - e.g. the bootswatch theme and animate
maybe an idea would be to have all of them as bower components and have them commented out so they would be opt-in ?
Jeremy Shipman
@jedateach
yes, I’m thinking the same
I’ve been using this theme internally for a few months now, and I only recently moved it from a private repo to github
Anselm Christophersen
@anselmdk
then the base theme would be very bare-bone, but people could easily copy site.less over to a “bootstrap_mysite” directory, and get going with some nice libs in a snap
Jeremy Shipman
@jedateach
exactly!
I did that very thing last week
Anselm Christophersen
@anselmdk
doing that very thing as we speak :)
Jeremy Shipman
@jedateach
it was the first time I didn’t merge the entire theme into the site repo
= lots of bloat
Anselm Christophersen
@anselmdk
…and a mess with all those form tempates
I also like keeping bower_components and node_modules out of the repo (also a lot of bloat)
though I’ve heard some people speaking of adding “node_modules” to the repo as being best practice...
Anselm Christophersen
@anselmdk
...also compiling sourcemaps takes time - by taking icons and that out, I’m now down to a compile time of 1.8s (from 6)
Jeremy Shipman
@jedateach
:+1:
If you PR with things taken out, make sure there are notes on how to add back in in docs or something
eg missing sorurce maps would break workflow if developing in chrome devtools
Anselm Christophersen
@anselmdk
I’d actually like to learn a little more about that workflow (I’m still using Firebug). Can you edit less files directly from within Chrome?
Jeremy Shipman
@jedateach
yes
Anselm Christophersen
@anselmdk
nice :)
Jeremy Shipman
@jedateach
you can’t update from the inspector, but you can click through to the sources part of devtools, and update there
changes in the inspector will just temporarily make changes
I’d like it if you could ‘bake’ those changes into the source
doesn’t work like that AFAIK
Anselm Christophersen
@anselmdk
okay, I’ve created a pull request of those improvements
Anselm Christophersen
@anselmdk
It seems the module is not updated on packagist
it’s referencing to #a2f4317 from 2. march
Anselm Christophersen
@anselmdk
another thing: I’d consider adding this part from the footer into an include:
<script type="text/javascript" src="$ThemeDir/javascript/site.min.js"></script>
this get’s messed up when you use Requirements::javascscript(), as they get loaded before it
Jeremy Shipman
@jedateach
hmm, I’ve always had mixed results with packagist auto-updating. I’m not sure if this is a result of migrating from bitbucket either. I’ll take a look.
Yes now that I’ve realised the Requirements system is falling short, perhaps we just do what you suggest. Feel free to PR
Anselm Christophersen
@anselmdk
nice we agree :) I now got the module running on 2 projects, so I’m happy to keep on shaping it, as needs arise, nice to only need to do a fix once!
Jeremy Shipman
@jedateach
:)
:clap:
Jeremy Shipman
@jedateach
Hi all, FYI I'm pushing up a few updates to this bootstrap theme, and also bootstrap_shop
Anselm Christophersen
@anselmdk
@jedateach I remember I did some work on the shop theme appr. 2 years ago, when playing with the shop module: https://github.com/titledk/silverstripe-cloudy-shop/commits/master
Anselm Christophersen
@anselmdk
@jedateach did you push the updates to the bootstrap shop theme? I’m thinking of using it as a base for a shop I’ll be working on.
Anselm Christophersen
@anselmdk
also it doesn’t seem that bootstrap_mysite is overwriting bootstrap_shop- any ideas?
for now I’ve just moved the templates to the mysitedirectory, that seems to work
Jeremy Shipman
@jedateach
hmm, right yeah. _mysite doesn't take precedence, but as you say, you can put templates in the root templates folder and they will take precedence that way. I wonder if (/wish) there is a way to force precedence of templates.
Anselm Christophersen
@anselmdk
yeah, hope that’ll happen at some point, I really like workin this way
fast question: what were your thoughs with this: burnbright/silverstripe-bootstrap@b8158f8
Jeremy Shipman
@jedateach
I refactored a bit to allow modifying paths etc
which in-turn allowed doing the bootstrap_mysite thing
Anselm Christophersen
@anselmdk
I like the idea - for now I still prefer to let SilverStripe hande javascript, so I built my own stripped-down version of the grunt file