Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Brian Vaughn
    @bvaughn
    Hah, well even if you just need to ask a question for clarity or whatever.
    Mark Chapman
    @mchapman
    I have pretty robust Protractor tests. Even screen compares
    Brian Vaughn
    @bvaughn
    That's fantastic.
    Mark Chapman
    @mchapman
    Well, I only put them in after I did something very un-fantastic!
    Brian Vaughn
    @bvaughn
    Adding them to formFor would be a bit of a pain in the ass, given it has 3 significantly different template libraries.
    Mark Chapman
    @mchapman
    Not sure it would. forms-angular has 3 as well. Didn't take me as long as I thought. https://github.com/forms-angular/website/tree/master/test/screen_tests will give you a start.
    and then you can compare with something like http://www.akikoskinen.info/image-diffs-with-git/
    But you are less likely to shoot yourself in the foot than me, as you use sensible templates rather than spitting out HTML direct from a directive
    Brian Vaughn
    @bvaughn
    Ah, screenshot compares, yeah. I was thinking more along the lines of Protractor tests to verify initial state and changes to state.
    That seems...more complicated, because the DOM structure (and thus the Protractor statements) would vary between the 3 templates. Seems like it would require a lot of (admittedly simple) code.
    Guess I could create a facade to set between a reusable Protractor test and each of the templates add-ons to abstract the differences in the DOM..
    Mohsen Azimi
    @mohsen1
    Thanks to JetBlue we arrived home 1am last night. I’m very eager to make web components repo as advanced as angular-1x but I just don’t find the time. This week hopefully I’ll do something about it. Please don’t hesitate to checkout the web-component repo and push whatever you think is the right thing to do.
    Brian Vaughn
    @bvaughn
    Ouch. Sorry to hear, Mohsen.
    Brian Vaughn
    @bvaughn
    Struggling to write Protractor tests that involve hovering.
    Or potentially-absent DOM elements
    This is not a very forgiving/friendly framework here.
    Brian Vaughn
    @bvaughn

    I think I came up with a pretty elegant solution for testing the 3 different formFor templates.

    For example, this Protractor test:
    https://github.com/bvaughn/angular-form-for/blob/master/tests/integration/directives/checkbox-field.js

    Runs against this view:
    https://github.com/bvaughn/angular-form-for/blob/master/examples/checkbox-field.html

    Which uses this shared helper to load/initialize the correct formFor templates and supporting libraries:
    https://github.com/bvaughn/angular-form-for/blob/master/examples/init.js

    Not sure any of this directly benefits forms-js, but...maybe if we end up supporting more than one CSS library, it might
    Mohsen Azimi
    @mohsen1
    Hi guys, I found another similiar project
    Mark Chapman
    @mchapman
    I think the A2 forms meetup will be key to how we proceed. Sadly I won't be able to watch it live as I have to get up really early and drive for several hours, and it looks like they won't put it on youtube for about a week.
    Mohsen Azimi
    @mohsen1
    @bvagughn and I are going there. We will give you guys a brief afterwards
    Mark Chapman
    @mchapman
    So you won the lottery too? Cool
    Brian Vaughn
    @bvaughn
    :)
    Brian Vaughn
    @bvaughn
    You still coming to the meetup tonight, right Mohsen?
    Mohsen Azimi
    @mohsen1
    Yes
    Maybe we can be there a little earlier to catch up with stuff
    Brian Vaughn
    @bvaughn
    Yeah :)
    Was going to suggest that.
    Mohsen Azimi
    @mohsen1
    Cool. I’ll try to be in mtv by 5p
    Mohsen Azimi
    @mohsen1
    Brian I’m here. in front of 1950
    Brian Vaughn
    @bvaughn
    Last night's meet-up was encouraging, regarding Forms JS and Angular 2. It's still early in the Angular 2 Forms project but from the presentation and the conversations after, it sounds like their forms support is going to intentionally be somewhat barebones. One of the devs said something along the lines of "there will be room for abstraction libraries to be built on top" in response to a question.
    Brian Vaughn
    @bvaughn
    I've been thinking...a little...about potentially refactoring Forms JS a small bit, after learning more about Angular 2's control/control-group structure.
    Thinking about perhaps mimicking that structure a little more. Not sure. Still just loose thoughts atm.
    Mohsen Azimi
    @mohsen1
    I liked composibility of Angular 2 forms very much. I think it’s a good idea
    Mark Chapman
    @mchapman
    It seems like starting working on an Angular 2 adaptor will make sense shortly - is this the right time to start planning a hangout? If so am I OK to assume weekday evening CET / early lunch PT?
    Brian Vaughn
    @bvaughn
    May be a bit too soon to move on the Angular 2 adaptor (at least that's my take away from the meetup- Mohsen may think differently?) but I was encouraged overall. And it gave me some ideas for things to try in the base library.
    I'm also moving this weekend so my availability with be less than the norm.
    Mohsen Azimi
    @mohsen1
    I think Angular 2 is great to experiment with to learn from it. I don't mean writing an adapter for formjs I mean writing some small form from schema library with Angular 2. That will give us a better understanding of how it exactly works. The video of the meetup will be available in couple of days.
    Mohsen Azimi
    @mohsen1
    Hey guys, did you know we can free WebStrom license for our open source stuff?
    Brian Vaughn
    @bvaughn
    Yah, I applied but have not heard back yet
    Brian Vaughn
    @bvaughn
    It's understandably not very high priority for them but I think I applied a week ago and haven't heard zip. I'll probably just give in and buy it, even though I only use it for open source stuff. My trial ran out and I miss it too much to continue waiting :)
    Mark Chapman
    @mchapman
    I got it, after a few weeks and a reminder email from me. But I had no time pressures. http://www.forms-angular.org/#/supported-by
    Brian Vaughn
    @bvaughn
    Nice!
    Brian Vaughn
    @bvaughn
    Fixed a pretty interesting pair of bugs this afternoon (bvaughn/angular-form-for#108 and bvaughn/angular-form-for#106) with bvaughn/angular-form-for@792184f.
    Thought I'd share in case you guys ever encountered a similar thing. Probably unlikely given how much of an edge-case it is but...you never know. :)
    David Jensen
    @davidlgj
    Cool solution, a bit of warning though, probably not relevant in your case anyway, but I found that $compiling in the link function really impacts performance in ng-repeat loops. It's my main performance hog in schema form
    Brian Vaughn
    @bvaughn
    Thanks for that warning. I'll have to keep an eye on it.
    David Jensen
    @davidlgj
    Thanks for sharing