These are chat archives for bvaughn/forms-js

25th
Mar 2015
Mark Chapman
@mchapman
Mar 25 2015 01:41
Just trying to install master of forms-js and angular-1x. It is not going smoothly...
Brian Vaughn
@bvaughn
Mar 25 2015 02:07
How so
Mark Chapman
@mchapman
Mar 25 2015 02:08
At the moment (after quite a few adds to package and bower.json - I can't understand why both) the angular 1 test isn't working. I can't see how it ever did
Mark Chapman
@mchapman
Mar 25 2015 02:30
Oh well, it is late. Will start again in the morning. Goodnight
Brian Vaughn
@bvaughn
Mar 25 2015 02:35
Hm...my PR worked. I don't know if David's did. I didn't actually see it working
Maybe he could help?
Brian Vaughn
@bvaughn
Mar 25 2015 03:03
I'd be happy to as well if you catch me around :)
Brian Vaughn
@bvaughn
Mar 25 2015 04:57
Fucking hell... NPM is rejecting me this evening when I try to login, adduser, publish...
David Jensen
@davidlgj
Mar 25 2015 11:40
The tests never worked in my PR, I never wrote any.... but you could build it and see the example/index.html for a working example. After I merged your Brian I noticed that you need a newer version of forms-js then was in NPM so I just cloned master and did a npm install .../forms-js
David Jensen
@davidlgj
Mar 25 2015 12:26
Or... npm install "git+https://github.com/forms-js/forms-js.git#master"
David Jensen
@davidlgj
Mar 25 2015 12:33
scratch that... that didn't work at all :(
David Jensen
@davidlgj
Mar 25 2015 12:42
Building starts building forms-js as well and complains about promises etc being defined several times.
btw, I've started working on angular 1.x again, but in the branch re-introduce-buiider, I'm pushing it to github since I need to switch between computers when lunch and evening hacking :) So right now its WIP that doesn't even compile :D
Brian Vaughn
@bvaughn
Mar 25 2015 14:40
Ah, I .. totally misunderstood Mark's question last night.
Mark, did you say the forms-js Gulp wasn't working for you either?
All of those tests should pass. I've even got them running/passing in Travis.
Mark Chapman
@mchapman
Mar 25 2015 17:22

No - forms-js is fine:

 git clone git@github.com:forms-js/forms-js.git
cd forms-js
npm install
npm run build
npm run test

works perfectly. But with angular-1x the npm install runs the tests, which fail.

(Which isn't a big deal I know)
Brian Vaughn
@bvaughn
Mar 25 2015 18:28
Oooh. Gotcha.