These are chat archives for bvaughn/forms-js

31st
Mar 2015
Brian Vaughn
@bvaughn
Mar 31 2015 01:18
FYI I'm going to go ahead and play with the Angular 1x branch a little this evening.
Brian Vaughn
@bvaughn
Mar 31 2015 02:37
Angular material support for input added @ https://github.com/forms-js/angular-1x/compare/angular-material
Brian Vaughn
@bvaughn
Mar 31 2015 04:28
Updated text input to use Material components. Also added checkbox and radio inputs.
David Jensen
@davidlgj
Mar 31 2015 05:25
Awesome
Brian Vaughn
@bvaughn
Mar 31 2015 05:29
Allllmost have some basic Protractor tests working in the branch.
Ugh, these things are ... awful.
:)
Once they're setup, they're fine.
But the docs are horrid
David Jensen
@davidlgj
Mar 31 2015 05:29
cool! You're really productive @bvaughn, looking forward to see what you come up with! :)
the protractor docs?
Anyway, one of my kids are sick so I won't have time to contribute right now, :( but I'll try too keep up with what you and mohsen1 do
Brian Vaughn
@bvaughn
Mar 31 2015 05:47
Fuck the protractor docs.
They're awful.
That's okay David. Hope your kids feel better.
David Jensen
@davidlgj
Mar 31 2015 05:48
:D that made my day
Brian Vaughn
@bvaughn
Mar 31 2015 05:51
Well I'm glad I could make your day ;)
Looks like something in the ViewDirective is causing the protractor tests to hang and shit out a worthless error "Timed out waiting for Protractor to synchronize with the page after 11 seconds"
The Protractor team are kind enough to say about 20 words on the subject of that error
David Jensen
@davidlgj
Mar 31 2015 05:53
Could it be since we're using es6 promises, and not angular ones?
They do tie in to the digest loop and all that
Brian Vaughn
@bvaughn
Mar 31 2015 05:54
Don't see how that would cause this
David Jensen
@davidlgj
Mar 31 2015 05:55
I wonder how they "synchronize the page"
Brian Vaughn
@bvaughn
Mar 31 2015 05:56
Their doc says it usually indicates a long running $http or $timeout poll. Neither of which we're doing.
So...
David Jensen
@davidlgj
Mar 31 2015 06:00
Template loading gone wrong? Templates are loaded via $http, so you have a hidden use of it there.
Brian Vaughn
@bvaughn
Mar 31 2015 13:54
Yeah, we are loading templates..but I'm already waiting on them to load and asserting things about them, and those assertions pass.
Hm.
Mark Chapman
@mchapman
Mar 31 2015 14:36
Is it in a branch? I suspect I am the most experienced Protractor wrangler out of us (I don't love it, but I haven't lost my temper that much with it for a few months)
Brian Vaughn
@bvaughn
Mar 31 2015 15:12
Shoot, it is in the branch I linked to last night w/ the Material integration, but I didn't push the Protractor bit before leaving for work.
I'll happily push and hand off to you, Mark, when I get home :)
Mark Chapman
@mchapman
Mar 31 2015 15:15
Ok. Not working tonight but hopefully will do it tomorrow