Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 09:20
    ajunlonglive starred cake-build/cake
  • 07:22
    tapika edited #4079
  • 07:21
    tapika opened #4079
  • Nov 28 19:41
    calebRH starred cake-build/cake
  • Nov 28 17:10
    BalintBanyasz starred cake-build/cake
  • Nov 28 16:00
    c0ffeine starred cake-build/cake
  • Nov 26 12:33
    devlead commented #3517
  • Nov 26 06:44
    jingliancui commented #3517
  • Nov 26 06:40
    jingliancui commented #3517
  • Nov 24 20:50
    guykisel starred cake-build/cake
  • Nov 24 13:22
    augustoproiete assigned #514
  • Nov 23 20:49
    Fifok starred cake-build/cake
  • Nov 23 09:37
    CSkoubo starred cake-build/cake
  • Nov 23 04:22
    gersoncjunior starred cake-build/cake
  • Nov 22 18:46
    squid-box commented #4071
  • Nov 22 15:23
    augustoproiete commented #1317
  • Nov 22 15:21
    augustoproiete unassigned #1317
  • Nov 22 15:21
    augustoproiete assigned #1317
  • Nov 22 15:18
    FrankRay78 commented #514
Asbjørn Ulsberg
@asbjornu
@gep13: Sure, where do I find the resources section?
Gary Ewan Park
@gep13
@Redth if you could for now, that would be great.
Gary Ewan Park
@gep13
We have spoken about removing the dependency from Cake, but there are issues in doing that /cc @mholo65
@asbjornu yip, that's the page
thank you!
Asbjørn Ulsberg
@asbjornu
:thumbsup:
Jonathan Dick
@Redth
ok cake.json 3.0.1 is out which is cake 0.26 compatible
Gary Ewan Park
@gep13
@Redth nice one! Thank you!
Gary Ewan Park
@gep13
@redth have you got it on your list to update your Url Module as well? :-D
Mattias Karlsson
@devlead
@Redth maybe works ootb with 0.27.1, @daveaglick added some code to sort that assembly binding. Json .NET is indirect dependency based on the NuGet client.
Jonathan Dick
@Redth
this was on 27.1 :/
Mattias Karlsson
@devlead
Ok, interesting, maybe we need more recursion @daveaglick 😎
Dave Glick
@daveaglick
Interesting - @Redth is that being output as a warning or is it an error and failing? Or is this output from building the addin? The changes in 27.1 should at least allow the addin to bind at runtime to whatever version of the assembly was loaded into the AppDomain by Cake itself (previously it would have crashed in this case).
Jonathan Dick
@Redth
i was running a script that used my addin which referenced newtsonsoft.json 11.0.2
and the script failed
saying that 9.0.0.0 was already loaded
Dave Glick
@daveaglick
:frown: Hrm. If you get a chance (and can still reproduce) would you mind sending me the full verbose output?
Jonathan Dick
@Redth
i can try and repro in a bit here.. i delisted the nuget that caused it but i can still access it to make a repro
Dave Glick
@daveaglick
Thanks!
Dave Glick
@daveaglick
Oh, wow - so that's failing even before runtime during the compliation stage. Yeah, the changes I made in 27.x aren't going to help there, they only do what's essentially a binding redirect on the fly at runtime to whatever's already been loaded.
Martin Björkström
@mholo65
Hmmm.. @daveaglick didn't we ship 11.0.2 with Cake 0.27.x?
For full framework, a simple binding redirect between versions 0.0.0.0 - 255.255.255.255 in the app.config should be sufficient.
Dave Glick
@daveaglick
We did, but I suspect the ScriptRunnermust be loading and adding a MetadataReference to 9.0.0, perhaps because some other addin or indirect dependency references it
@Redth Is this the only addin or tool being used in this script?
Jonathan Dick
@Redth
that gist IS the script
just the addin line
Dave Glick
@daveaglick
That makes it easy :)
Jonathan Dick
@Redth
that’s what I was aiming for :D
Martin Björkström
@mholo65
image.png
That's from Cake 0.27.0
Dave Glick
@daveaglick
@mholo65 Is that from the 27.0 package? WTF?
That probably explains it though :confused:
Martin Björkström
@mholo65
yep..
Is it a problem that Newtonsoft.Json is strong-name signed?
Dave Glick
@daveaglick
But this also exposes a bigger issue - we're not going to keep bumping Cake every time JSON.NET bumps, so this same problem could occur when Cake gradually slips further from the current version of JSON.NET
Martin Björkström
@mholo65
damn NuGet..
Dave Glick
@daveaglick
Keeping up with the latest JSON.NET at release probably helps with a large percentage of the potential problems, but not all
Martin Björkström
@mholo65
about to linke you the same :smile:
and thinking about it... That PackageReference might be better to have in Cake.csproj, right?
...I blame the reviewer(s)..
:smiley:
Gary Ewan Park
@gep13
Did someone shout on me?
What did I miss?
:-P
Martin Björkström
@mholo65
But the PackageReference is inside the netstandard2.0
so, only valid for that :small_blue_diamond:
Dave Glick
@daveaglick
Right, but that's okay because netstandard is the only profile that references Microsoft.Extensions.DependencyModel which is where the JSON.NET reference is coming from anyway