Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 26 01:10
    jrdodds starred cake-build/cake
  • Jan 25 07:00
    IndisciplineHQ starred cake-build/cake
  • Jan 24 22:23
    NikoMix starred cake-build/cake
  • Jan 24 16:42
    MolassesLover starred cake-build/cake
  • Jan 24 14:34
    augustoproiete milestoned #4107
  • Jan 24 14:34
    augustoproiete labeled #4107
  • Jan 21 22:55
    Build #7457 passed
  • Jan 21 22:51
    Marusyk edited #4111
  • Jan 21 22:50
    Marusyk opened #4111
  • Jan 21 22:25
    Build #7456 passed
  • Jan 21 22:20
    Marusyk opened #4110
  • Jan 20 18:17
    augustoproiete milestoned #4109
  • Jan 20 18:17
    augustoproiete labeled #4109
  • Jan 20 18:17
    augustoproiete opened #4109
  • Jan 20 07:07
    Specter-13 starred cake-build/cake
  • Jan 19 12:52
    sfwester commented #4107
  • Jan 19 09:38
    Kuldeep-kd commented #4107
  • Jan 18 13:51
    areisler starred cake-build/cake
  • Jan 17 14:26
    aurax starred cake-build/cake
  • Jan 16 18:02
    sfwester opened #4107
Jonathan Dick
@Redth
saying that 9.0.0.0 was already loaded
Dave Glick
@daveaglick
:frown: Hrm. If you get a chance (and can still reproduce) would you mind sending me the full verbose output?
Jonathan Dick
@Redth
i can try and repro in a bit here.. i delisted the nuget that caused it but i can still access it to make a repro
Dave Glick
@daveaglick
Thanks!
Jonathan Dick
@Redth
@daveaglick https://gist.github.com/Redth/37bfa030e2890d22d93c06b154648e72
Dave Glick
@daveaglick
Oh, wow - so that's failing even before runtime during the compliation stage. Yeah, the changes I made in 27.x aren't going to help there, they only do what's essentially a binding redirect on the fly at runtime to whatever's already been loaded.
Martin Björkström
@mholo65
Hmmm.. @daveaglick didn't we ship 11.0.2 with Cake 0.27.x?
For full framework, a simple binding redirect between versions 0.0.0.0 - 255.255.255.255 in the app.config should be sufficient.
Dave Glick
@daveaglick
We did, but I suspect the ScriptRunnermust be loading and adding a MetadataReference to 9.0.0, perhaps because some other addin or indirect dependency references it
@Redth Is this the only addin or tool being used in this script?
Jonathan Dick
@Redth
that gist IS the script
just the addin line
Dave Glick
@daveaglick
That makes it easy :)
Jonathan Dick
@Redth
that’s what I was aiming for :D
Martin Björkström
@mholo65
image.png
That's from Cake 0.27.0
Dave Glick
@daveaglick
@mholo65 Is that from the 27.0 package? WTF?
That probably explains it though :confused:
Martin Björkström
@mholo65
yep..
Is it a problem that Newtonsoft.Json is strong-name signed?
Dave Glick
@daveaglick
But this also exposes a bigger issue - we're not going to keep bumping Cake every time JSON.NET bumps, so this same problem could occur when Cake gradually slips further from the current version of JSON.NET
Martin Björkström
@mholo65
damn NuGet..
Dave Glick
@daveaglick
Keeping up with the latest JSON.NET at release probably helps with a large percentage of the potential problems, but not all
Here's the latest PackageReference - clearly indicates 11.0.2: https://github.com/daveaglick/cake/blob/ee40718b1a07384aac3380a9c1077cd32be33198/src/Cake.Core/Cake.Core.csproj#L19
Martin Björkström
@mholo65
about to linke you the same :smile:
and thinking about it... That PackageReference might be better to have in Cake.csproj, right?
...I blame the reviewer(s)..
:smiley:
Gary Ewan Park
@gep13
Did someone shout on me?
What did I miss?
:-P
Martin Björkström
@mholo65
But the PackageReference is inside the netstandard2.0
so, only valid for that :small_blue_diamond:
Dave Glick
@daveaglick
Right, but that's okay because netstandard is the only profile that references Microsoft.Extensions.DependencyModel which is where the JSON.NET reference is coming from anyway
Martin Björkström
@mholo65
@daveaglick no, the reference also comes from NuGet.Protocol..
Dave Glick
@daveaglick
Unless... does Cake.Common or Cake.NuGet also reference JSON.NET in the .NET Framework profile?
Martin Björkström
@mholo65
which comes from Cake.NuGet..
Dave Glick
@daveaglick
That explains it then
Gary Ewan Park
@gep13
I could only see one place where it was referenced in the Cake code base
Dave Glick
@daveaglick
We need a JSON.NET PackageReference for both profiles - not sure if it should go in Cake.Core or Cake
Mattias Karlsson
@devlead
Not Core right? Would mean all addins would depend on json.net too
Martin Björkström
@mholo65
Yup, with @devlead on that.. Preferably the runner (Cake, or Cake.NuGet...)
Dave Glick
@daveaglick
They do anyway if they're targetting netstandard
So maybe match it up with where we bring in the transitive JSON.NET dep? Leave the netstandard one in Core and add an extra one in NuGet?
RichardJFoster
@RichardJFoster
Oh... Myyyyyyyy! Does reading all these dependency problems give anyone else queasy "DLL Hell" feelings, or am I just showing my age? :-)
Dave Glick
@daveaglick
@RichardJFoster I've been living in DLL hell for months and have been getting increasingly frustrated with .NET because of it. One of these days, it's all supposed to "just work". Today is not that day.
Added #2134 to track this
Gary Ewan Park
@gep13
@daveaglick are you wanting to treat this as another hotfix release?
Martin Björkström
@mholo65
@gep13 no need for hotfix afaik
Dave Glick
@daveaglick
¯_(ツ)_/¯ (gut says no)