These are chat archives for cakemanager/cakeadmin-lightstrap

26th
Jun 2015
Leonardo Ruhland
@leoruhland
Jun 26 2015 10:29
Xs buttons is my first choice, but in some subthemes they are too little. Actually, i have to ignore subthemes right now and only think of plain lightstrap. After I can adjust fixes for each subtheme.
Bob Mulder
@bobmulder
Jun 26 2015 10:30
Okay great. I am adding the settings plugin to the cakeadmin plugin. From there we are able to select subthemes dynamically. Also you can add settings for the theme :)
I suggest using an apart config file
Leonardo Ruhland
@leoruhland
Jun 26 2015 10:30
What your think about the plus button without New PostType label?
Its OK? And about the tooltip?
Bob Mulder
@bobmulder
Jun 26 2015 10:31
Hm not sure about that ;) I am afraid people won't notice it so quick...
Leonardo Ruhland
@leoruhland
Jun 26 2015 10:33
Yeah.. I tried to make a default for all buttons, but I really afraid of that
Bob Mulder
@bobmulder
Jun 26 2015 10:34
Maybe you should just add the New $postTypeName text
Leonardo Ruhland
@leoruhland
Jun 26 2015 10:35
OK.. Today I'll update it
Bob Mulder
@bobmulder
Jun 26 2015 10:35
Great work man :)
Leonardo Ruhland
@leoruhland
Jun 26 2015 10:35
And about the config, very nice..
Right now I want to reorganize all the theme. Make more i n the cake way.
And less spaghetti code.
Bob Mulder
@bobmulder
Jun 26 2015 10:40
Haha okay... I think that way of thinking should be paralel on the layout-structure of the CakeAdmin plugin?
Leonardo Ruhland
@leoruhland
Jun 26 2015 10:40
Create some helpers, extending views..
Bob Mulder
@bobmulder
Jun 26 2015 10:40
Agree with my suggestion? ;)
Leonardo Ruhland
@leoruhland
Jun 26 2015 10:41
Yes, some changes have to be in cakeadmin
Bob Mulder
@bobmulder
Jun 26 2015 10:42
I suggest you will fork the cakeadmin plugin and work on an apart branch to add that custom helpers and stuff? Then you can do pull requests and I will accept them
blob
Leonardo Ruhland
@leoruhland
Jun 26 2015 10:46
Sure! I'll try to create a branch for new features i. Theme too.
Bob Mulder
@bobmulder
Jun 26 2015 10:46
@leoruhland You are using multiple configures with different prefixes. Please add them all as default value to the bootstrap.php, and explain them in the readme.md ;)
Leonardo Ruhland
@leoruhland
Jun 26 2015 10:47
Right!
Leonardo Ruhland
@leoruhland
Jun 26 2015 10:59
Just updated readme
;)
Feel free to correct my english/way of writing
Bob Mulder
@bobmulder
Jun 26 2015 11:01
Looks great. Thanks! I saw this in the layout-files: Configure::check('CA.LightStrap.subtheme'). But if you add the default value in your bootstrap of the plugin (Configure::write....), You don't have to check it but can directly the value ;)
Leonardo Ruhland
@leoruhland
Jun 26 2015 11:03
Im leaving for work right now. I will fix this today!
Thanks for the help!
Bob Mulder
@bobmulder
Jun 26 2015 11:04
Okay great... I am allowed to commit settings-plugin integration?
Leonardo Ruhland
@leoruhland
Jun 26 2015 11:08
For sure!
Please!
;)
Bob Mulder
@bobmulder
Jun 26 2015 11:11
Ah okay cool! Great work :)
Bob Mulder
@bobmulder
Jun 26 2015 11:34
@leoruhland I commited. Dont forget to run bin/cake migrations migrate -p Settings
@leoruhland Can you fix that I you can set CA.LightStrap.subtheme to false?
Bob Mulder
@bobmulder
Jun 26 2015 13:09
@leoruhland Maybe you should add the breadcrumb in the layout-file and not the templates. That because that custom pages (like the settings page atm) doesn't contain any breadcrumb. Keep in mind that people will add custom pages to the panel and we should display it right ;)
Leonardo Ruhland
@leoruhland
Jun 26 2015 13:14
Yes, I'm sure! I will adjust it and the positioning of Flash messages along with the extension of views.It is a necessary change.
Maybe this weekend
Bob Mulder
@bobmulder
Jun 26 2015 13:14
Cool... You've done great work :) What do you think about my changes? ;)
Leonardo Ruhland
@leoruhland
Jun 26 2015 13:16
I didn't have enough time to test yet!
Bob Mulder
@bobmulder
Jun 26 2015 13:17
Me neither... Hopefully got time to test next week...
When testing I will enable Travis for the repo
Bob Mulder
@bobmulder
Jun 26 2015 13:26
@leoruhland I changed to action-buttons to xs.. It was too annoying ;)
Leonardo Ruhland
@leoruhland
Jun 26 2015 13:26
Thanks and feel free to change everything!
Bob Mulder
@bobmulder
Jun 26 2015 13:27
Okay thanks ;) What's on your wishlist? (so I won't hurt your code)
Leonardo Ruhland
@leoruhland
Jun 26 2015 13:29
I'm busy solving some problems right now.. at night I will check everything.
Bob Mulder
@bobmulder
Jun 26 2015 13:29
You have to sleep at night as well :P
Leonardo Ruhland
@leoruhland
Jun 26 2015 13:30
In fact the next change I will make is about the project structure. Extend the views and make these adjustments.
Maybe create some helpers too.
Bob Mulder
@bobmulder
Jun 26 2015 13:30
Okay cool...
Leonardo Ruhland
@leoruhland
Jun 26 2015 13:30
Yesterday I rested enough!
;)
Bob Mulder
@bobmulder
Jun 26 2015 13:31
Haha
This message was deleted
Bob Mulder
@bobmulder
Jun 26 2015 20:38
Hey @leoruhland still got this issue:
blob
Leonardo Ruhland
@leoruhland
Jun 26 2015 22:29
I'll try to fix it