Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 18 2016 18:08

    leoruhland on master

    Renames the AppView to LightStr… (compare)

  • Mar 03 2016 08:40
    bobmulder commented #4
  • Mar 03 2016 08:31
    okuda-k closed #4
  • Mar 03 2016 08:31
    okuda-k commented #4
  • Mar 03 2016 08:25
    okuda-k opened #4
  • Feb 16 2016 01:15

    leoruhland on master

    Add gettext domain Ignore mo files Add initial LightStrap pot and 1 more (compare)

  • Jan 06 2016 12:24
    leoruhland commented #3
  • Jan 06 2016 12:22

    bobmulder on master

    Update AppView.php Decided to … Merge pull request #3 from cake… (compare)

  • Jan 06 2016 12:22
    bobmulder closed #3
  • Jan 06 2016 12:22
    bobmulder commented #3
  • Dec 18 2015 22:23
    bobmulder assigned #3
  • Dec 18 2015 22:23
    bobmulder opened #3
  • Dec 18 2015 22:23
    bobmulder labeled #3
  • Dec 18 2015 22:22

    bobmulder on bobmulder-patch-1

    Update AppView.php Decided to … (compare)

  • Sep 28 2015 09:30

    bobmulder on master

    Update composer.json (compare)

  • Sep 21 2015 18:37

    bobmulder on master

    restructure login template + ad… (compare)

  • Sep 21 2015 16:57
  • Sep 21 2015 15:42
  • Sep 21 2015 15:13

    bobmulder on master-dashboard

    Dynamic dashboard (compare)

  • Sep 21 2015 15:12

    bobmulder on master

    Cake 3.1 compatible (compare)

Bob Mulder
@bobmulder
Agree with my suggestion? ;)
Leonardo Ruhland
@leoruhland
Yes, some changes have to be in cakeadmin
Bob Mulder
@bobmulder
I suggest you will fork the cakeadmin plugin and work on an apart branch to add that custom helpers and stuff? Then you can do pull requests and I will accept them
blob
Leonardo Ruhland
@leoruhland
Sure! I'll try to create a branch for new features i. Theme too.
Bob Mulder
@bobmulder
@leoruhland You are using multiple configures with different prefixes. Please add them all as default value to the bootstrap.php, and explain them in the readme.md ;)
Leonardo Ruhland
@leoruhland
Right!
Leonardo Ruhland
@leoruhland
Just updated readme
;)
Feel free to correct my english/way of writing
Bob Mulder
@bobmulder
Looks great. Thanks! I saw this in the layout-files: Configure::check('CA.LightStrap.subtheme'). But if you add the default value in your bootstrap of the plugin (Configure::write....), You don't have to check it but can directly the value ;)
Leonardo Ruhland
@leoruhland
Im leaving for work right now. I will fix this today!
Thanks for the help!
Bob Mulder
@bobmulder
Okay great... I am allowed to commit settings-plugin integration?
Leonardo Ruhland
@leoruhland
For sure!
Please!
;)
Bob Mulder
@bobmulder
Ah okay cool! Great work :)
Bob Mulder
@bobmulder
@leoruhland I commited. Dont forget to run bin/cake migrations migrate -p Settings
@leoruhland Can you fix that I you can set CA.LightStrap.subtheme to false?
Bob Mulder
@bobmulder
@leoruhland Maybe you should add the breadcrumb in the layout-file and not the templates. That because that custom pages (like the settings page atm) doesn't contain any breadcrumb. Keep in mind that people will add custom pages to the panel and we should display it right ;)
Leonardo Ruhland
@leoruhland
Yes, I'm sure! I will adjust it and the positioning of Flash messages along with the extension of views.It is a necessary change.
Maybe this weekend
Bob Mulder
@bobmulder
Cool... You've done great work :) What do you think about my changes? ;)
Leonardo Ruhland
@leoruhland
I didn't have enough time to test yet!
Bob Mulder
@bobmulder
Me neither... Hopefully got time to test next week...
When testing I will enable Travis for the repo
Bob Mulder
@bobmulder
@leoruhland I changed to action-buttons to xs.. It was too annoying ;)
Leonardo Ruhland
@leoruhland
Thanks and feel free to change everything!
Bob Mulder
@bobmulder
Okay thanks ;) What's on your wishlist? (so I won't hurt your code)
Leonardo Ruhland
@leoruhland
I'm busy solving some problems right now.. at night I will check everything.
Bob Mulder
@bobmulder
You have to sleep at night as well :P
Leonardo Ruhland
@leoruhland
In fact the next change I will make is about the project structure. Extend the views and make these adjustments.
Maybe create some helpers too.
Bob Mulder
@bobmulder
Okay cool...
Leonardo Ruhland
@leoruhland
Yesterday I rested enough!
;)
Bob Mulder
@bobmulder
Haha
This message was deleted
Bob Mulder
@bobmulder
Hey @leoruhland still got this issue:
blob
Leonardo Ruhland
@leoruhland
I'll try to fix it
Bob Mulder
@bobmulder
Cool new commit! Looks fancy! What should be the width of the tabs of the settings? Prepared for multiple tabs for muliple plugins... ;)
@leoruhland Look what I've found :)
blob
This code is found in toolbar-app.js:
   saveState: function() {
        if (!window.localStorage) {
            return;
        }
        window.localStorage.setItem('toolbar_state', this._state);
    },

    loadState: function() {
        if (!window.localStorage) {
            return;
        }
        var old = window.localStorage.getItem('toolbar_state');
        if (!old) {
            old = 0;
        }
        if (old == 0) {
            return this.hideContent();
        }
        if (old == 1) {
            return this.toggle();
        }
    },
Bob Mulder
@bobmulder
I've set up the activity-integration for our trello-board at the right ;)\
Bob Mulder
@bobmulder

Hey @leoruhland,

First of all, you've done great commits! I think the feature adds something to the theme. On the other side we have some things do discuss ;) But keep in mind I really appreciate your work ;).

I've found the following in the CookBook: http://book.cakephp.org/3.0/en/views/helpers/form.html#adding-custom-widgets. This would make it better to add custom types, instead of your switch-case you have now...

At the moment it's possible to add a type named ls-name. But what if an user decides to use the theme HeavyStrap? He has to change all his ls-name to hs-name and needs even to change the types in all the plugins he uses... So what do you think about the following:

  • ls-select - Will be default used when it's a select-box.
  • ls-editor - Will be default used when it's a textarea.
  • ls-date - Will be default used when it's a dateTime-input.
  • ls-color - Will be used when the class colorpicker is added.
  • ls-toggle - Will be default used when it's a checkbox or something?
  • ls-number Will be default used when the input is an integer.

What do you think about this? When using it this way, it's easier for other themes and people to customize, and that's what we want ;).

An option could be that we will define some extra inputs in the CakeAdmin plugin (about that widgets I talked about above), and themes are able to design that widgets ;).

Please let me know what you think about it ;)

Greetz

Leonardo Ruhland
@leoruhland
Hi! I agree that widgets is the best solution for fieldtypes.
I just reused some cakephp2 code to get working. I really need to learn how to apply that on widgets.