Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 18 2016 18:08

    leoruhland on master

    Renames the AppView to LightStr… (compare)

  • Mar 03 2016 08:40
    bobmulder commented #4
  • Mar 03 2016 08:31
    okuda-k closed #4
  • Mar 03 2016 08:31
    okuda-k commented #4
  • Mar 03 2016 08:25
    okuda-k opened #4
  • Feb 16 2016 01:15

    leoruhland on master

    Add gettext domain Ignore mo files Add initial LightStrap pot and 1 more (compare)

  • Jan 06 2016 12:24
    leoruhland commented #3
  • Jan 06 2016 12:22

    bobmulder on master

    Update AppView.php Decided to … Merge pull request #3 from cake… (compare)

  • Jan 06 2016 12:22
    bobmulder closed #3
  • Jan 06 2016 12:22
    bobmulder commented #3
  • Dec 18 2015 22:23
    bobmulder assigned #3
  • Dec 18 2015 22:23
    bobmulder opened #3
  • Dec 18 2015 22:23
    bobmulder labeled #3
  • Dec 18 2015 22:22

    bobmulder on bobmulder-patch-1

    Update AppView.php Decided to … (compare)

  • Sep 28 2015 09:30

    bobmulder on master

    Update composer.json (compare)

  • Sep 21 2015 18:37

    bobmulder on master

    restructure login template + ad… (compare)

  • Sep 21 2015 16:57
  • Sep 21 2015 15:42
  • Sep 21 2015 15:13

    bobmulder on master-dashboard

    Dynamic dashboard (compare)

  • Sep 21 2015 15:12

    bobmulder on master

    Cake 3.1 compatible (compare)

Bob Mulder
@bobmulder
I don't think that's right because you want to add a theme only for the design. When a specific plugin adds a postType it should be sure it uses the right type. ls-select is only for lightstrap but what happens if another theme is used?
Leonardo Ruhland
@leoruhland
I should separate all fieldtypes in another plugin? Because now you are required to use with LS. All external plugins used are bootstrap compatible and i dont know if really work without it.
We can rename types to plugin names.. My old helper works like that.
Bob Mulder
@bobmulder
But am I right that when using lightstrap (for example) you always want to use select2 when you have a select type?
Leonardo Ruhland
@leoruhland
select2, summernote, colorpicker
I dont think so.
Maybe in some project you wanna use a new markdown editor and not summernote.
Or, not in whole project, but in some PostType only.
Bob Mulder
@bobmulder
Yeah okay. But then, make it class specific (so when I add the class editor summernote will be added). This is because you want that an code-standard when you have multiple themes. All themes should work without extra code ;)
Leonardo Ruhland
@leoruhland
Right. I'll study widgets to perfectly implement that.
Bob Mulder
@bobmulder
I think widgets shouldn't be needed anymore in that case? ;)
Leonardo Ruhland
@leoruhland
But I dont think that use the class is the best option to chose the type
I generate a unique field class to give the possibility to configure two instances of a plugins with different options.
In same form..
Bob Mulder
@bobmulder
Example?
Leonardo Ruhland
@leoruhland
Two datepickers, one for past date and one for future only..
Two editors, one of they we dont want to enable font changes..
The number spinner, with different max and step value
Bob Mulder
@bobmulder
But when I have a textarea, i just should add the class editor and summernote could come in? ;)
Leonardo Ruhland
@leoruhland
Yes.. But where do you set options for this instance of summernote?
All fieldtypes should be configurable
Bob Mulder
@bobmulder
Ehm the themebuilder should do?
Because summernote is theme specific.
Leonardo Ruhland
@leoruhland
Theme specific?
Bob Mulder
@bobmulder
Yeah. The lightstrap theme uses summernote, but another theme could use ckeditor or whatever. So the user should not be interested in changing the summernote-setting. If you really want to you could create a setting via the settings-plugin. (summernote on or off)
Leonardo Ruhland
@leoruhland
via settings?
Bob Mulder
@bobmulder
Yeah but only the most important ones (so enable or disable summernote) but not specific settings because that's theme based
Leonardo Ruhland
@leoruhland
but what about two instances of summernote with different options?
What the problem with changing type that bothers you?
Bob Mulder
@bobmulder
We want to create multiple themes. The goal is that you could easily switch between themes. When creating a custom standard only for lightstrap other themes wont be compatible with that.
Leonardo Ruhland
@leoruhland
really agree to exchange the names of types .. remove the prefix LS
and use the plugin name.. select2, bs-datepicker, summernote
we can detach the FormHelper
Bob Mulder
@bobmulder
Select2 is a choice of the lightstrap theme. select is the type that should be used. Another theme could use another jquery-plugin... Same for summernote... summernote is a choise of the lightstrap theme. textarea is the type that should be used. Another theme could use ckeditor...
Leonardo Ruhland
@leoruhland
No. Its not a choice of the theme.
Bob Mulder
@bobmulder
Why not?
Leonardo Ruhland
@leoruhland
You can reuse select2 or summernote in other themes
dont you?
Bob Mulder
@bobmulder
Of course but another plugin can choose to use another plugin instead of select2 so the type select2 shouldnt be used...
Leonardo Ruhland
@leoruhland
sure..
thats why we have to rename the field type to plugin names
and detach LightStrapFormHelper from theme
to reuse in any theme
what you think?
we can implement ckeditor type
and other plugins too.
Bob Mulder
@bobmulder
implement in what? ;)
Leonardo Ruhland
@leoruhland
add ckeditor to LightStrapFormHelper.. and rename this helper to FieldTypesFormHelper
Bob Mulder
@bobmulder
Why? We chose for summernote ;)
Bob Mulder
@bobmulder
Hey @leoruhland, still getting this: