by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jun 05 18:59
    dependabot-preview[bot] labeled #905
  • Jun 05 18:59
    dependabot-preview[bot] labeled #905
  • Jun 05 18:59
    dependabot-preview[bot] labeled #905
  • Jun 05 18:59
    dependabot-preview[bot] opened #905
  • Jun 05 18:59

    dependabot-preview[bot] on npm_and_yarn

    [Security] Bump websocket-exten… (compare)

  • Jun 04 12:55
    dependabot-preview[bot] labeled #904
  • Jun 04 12:55
    dependabot-preview[bot] labeled #904
  • Jun 04 12:55
    dependabot-preview[bot] opened #904
  • Jun 04 12:55

    dependabot-preview[bot] on npm_and_yarn

    Bump dropzone from 5.7.0 to 5.7… (compare)

  • Jun 04 11:40
    dependabot-preview[bot] synchronize #903
  • Jun 04 11:40

    dependabot-preview[bot] on composer

    Bump friendsofsymfony/rest-bund… (compare)

  • Jun 04 11:40
    dependabot-preview[bot] edited #903
  • Jun 04 11:36
    dependabot-preview[bot] edited #903
  • Jun 04 11:36

    dependabot-preview[bot] on npm_and_yarn

    (compare)

  • Jun 04 11:36
    GKFX closed #902
  • Jun 04 11:36

    GKFX on master

    Bump @github/hotkey from 1.4.0 … (compare)

  • Jun 04 08:29
    dependabot-preview[bot] labeled #903
  • Jun 04 08:29
    dependabot-preview[bot] labeled #903
  • Jun 04 08:29
    dependabot-preview[bot] opened #903
  • Jun 04 08:29

    dependabot-preview[bot] on composer

    Bump friendsofsymfony/rest-bund… (compare)

Peter Hoyes
@hoyes
Just made the error a little more helpful :-) https://travis-ci.org/camdram/camdram/jobs/467794985#L1065
Charlie Jonas
@CHTJonas
Fun topic for discussion - shows versus diary events.

https://www.camdram.net/venues/adc-theatre/shows.json?from=2018-12-01&to=2018-12-03

Expected: return a blank array seeing as there are no performances at the ADC in this date range.
Actual: returns data for ETG because the show's venue matches and at least one of their performances is in the query date range.

Is this a bug or intended behaviour? I can see the distinction between performances and shows and maybe this could be useful to someone?
Or is it just confusing...?
George Bateman
@GKFX
I’m working on a branch where shows have no venue, only performances do, so the problem should go away
Charlie Jonas
@CHTJonas
Cool.
Is it worth fixing in master if this is planned for far future?
George Bateman
@GKFX
No, I should be able to get the branch out in the not-too-distant future
George Bateman
@GKFX
I've pushed the relevant three lines to master anyway; as usual there are a bunch of loose ends to tie up with the branch.
Peter Hoyes
@hoyes
I'll leave this here: https://threader.app/thread/1078388060696576001 (by a ReactJS maintainer)
Charlie Jonas
@CHTJonas
Haha!
Charlie Jonas
@CHTJonas
@GKFX just to check I understand the recent CSP stuff correctly: the warnings/errors from Sentry are only advisory and can be safely ignored?
George Bateman
@GKFX
That is correct, I think it is just a list of IPs who have installed poorly written browser extensions at the moment. Unfortunately there’s less context in the reports than I would like, but the idea is to check that I wrote the policy correctly before we set it to enforce in the next release.
Charlie Jonas
@CHTJonas
Cool - I assumed it was something like that from your commit messages
Charlie Jonas
@CHTJonas
Looks like one fo the recent releases has broken the OAuth2 API. Previously (when authenticated) you could use https://www.camdram.net/auth/account/organisations.json and https://www.camdram.net/auth/account/shows.json to obtain a list of shows/societies/venues that the user had admin rights for. This no longer seems to work and returns 404 instead.
I assume it's caused as a side effect of the transition from FOSRestController to AbstractFOSRestController
George Bateman
@GKFX
yep
fixing now.
Charlie Jonas
@CHTJonas
Ah thanks!
George Bateman
@GKFX
@CHTJonas once that's up would you be able to test it if you're free? I haven't used the OAuth2 API before so I just switched it back on without testing to see if it's right.
Charlie Jonas
@CHTJonas
Yep can do!
Are you about to deploy or should I? :smile:
George Bateman
@GKFX
Already deployed!
Charlie Jonas
@CHTJonas
So now it's returning HTTP 500 Internal Server Error
Which seems to have been picked up by Sentry
George Bateman
@GKFX
Does the shows url work?
typo appears only in the organisations code
Charlie Jonas
@CHTJonas
Yeah shows works :+1:
George Bateman
@GKFX
Wonderful, will push to master.dev for another test
any luck?
Charlie Jonas
@CHTJonas
Gimme a sec sorry!
More difficult to test on dev
Yeah it seems to work now. Returns blank arrays as the default admin user doesn't 'own' anything by default but at least it doesn't error now
Can you deploy to prod?
George Bateman
@GKFX
Yep I've started deployment. Thanks for spotting this!
Charlie Jonas
@CHTJonas
No worries!
Charlie Jonas
@CHTJonas
Anyone know what the point of the ExternalUser -> Person relationship is?
I totally get and understand both ExternalUser -> User and Person -> User, but ExternalUser -> Person doesn't make much sense to me. What's more is that sometimes this relationship is set but other times it isn't: SELECT id, user_id, service, username, name, email, person_id, last_login_at FROM acts_external_users WHERE person_id IS NOT NULL; isn't particularly revealing...
Stuart Cuthbertson
@philosophicles
Not certain but I think users can have a row in ExternalUser without a row in User?
At which point we need to be able to map from (EU xor U) to P.
George Bateman
@GKFX

Users can exist in ExternalUser with null user_id but I think that is a bug. If I go to my externaluser and set user_id = NULL it gets automatically fixed on my next login back to user_id = 4093. On the other hand if I also change my email address (so the software can't automatically fix the null user_id) it acts as though my externaluser doesn't exist and asks me to set up a new account.

I think we should go through the externaluser table and fix all the null user_id's that would be fixed if they logged in (should be an SQL one-liner) then delete the rest, set acts_external_user.user_id to non-nullable, and delete acts_external_user.person_id.

Peter Hoyes
@hoyes
@GKFX what was the issue with liip/imagine-bundle:2.3 out of interest (in the symfony4 branch)? I've just tried remove the version conflict here and it seems to work OK for me.
George Bateman
@GKFX
All the images on the home page disappear if you use version 2.3 - they put in liip/LiipImagineBundle@b77558c which strips all parts of the URL except the path. This means the library can't access images on external domains such as Twitter.
Peter Hoyes
@hoyes
ah that's annoying
Charlie Jonas
@CHTJonas
Was that intentional do you know and if so is there an open issue?
George Bateman
@GKFX
I opened a PR to revert it liip/LiipImagineBundle#1240 because it's a daft commit IMO but it's now been like that too long to just revert back change again. There's also discussion at liip/LiipImagineBundle#1172 but I never got around to following up.
Peter Hoyes
@hoyes
I agree the premise of liip/LiipImagineBundle#1116 is flawed. Could we fork and revert (as described in https://medium.com/swlh/using-your-own-forks-with-composer-699358db05d9) until it gets fixed upstream?
Charlie Jonas
@CHTJonas
So liip/LiipImagineBundle#1116 seems to be saying "if I give you an image with query params then strip those params for me because I was too lazy to myself"? That seems... odd.
George Bateman
@GKFX
I have made an updated fork at https://github.com/GKFX/LiipImagineBundle/tree/v2.3.0%2Bcamdram which would be suitable.