Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 17:53

    GKFX on npm_and_yarn

    (compare)

  • 17:53
    GKFX closed #1088
  • 17:53

    GKFX on master

    Bump node-sass from 4.14.1 to 5… (compare)

  • 17:35
    dependabot-preview[bot] synchronize #1088
  • 17:35

    dependabot-preview[bot] on npm_and_yarn

    Bump node-sass from 4.14.1 to 5… (compare)

  • 17:35
    dependabot-preview[bot] edited #1088
  • 17:34

    dependabot-preview[bot] on npm_and_yarn

    (compare)

  • 17:34
    dependabot-preview[bot] closed #1097
  • 17:34
    dependabot-preview[bot] edited #1097
  • 17:34
    dependabot-preview[bot] commented #1097
  • 17:34

    dependabot-preview[bot] on npm_and_yarn

    (compare)

  • 17:34
    dependabot-preview[bot] closed #1116
  • 17:34
    dependabot-preview[bot] edited #1116
  • 17:34
    dependabot-preview[bot] commented #1116
  • 17:33
    dependabot-preview[bot] edited #1097
  • 17:33
    dependabot-preview[bot] edited #1088
  • 17:33
    dependabot-preview[bot] edited #1116
  • 17:33

    GKFX on composer

    (compare)

  • 17:33
    GKFX closed #1135
  • 17:33

    GKFX on master

    Bump doctrine/doctrine-bundle f… Bump sass-loader from 9.0.3 to … Bump webpack-notifier from 1.10… (compare)

George Bateman
@GKFX
Already deployed!
Charlie Jonas
@CHTJonas
So now it's returning HTTP 500 Internal Server Error
Which seems to have been picked up by Sentry
George Bateman
@GKFX
Does the shows url work?
typo appears only in the organisations code
Charlie Jonas
@CHTJonas
Yeah shows works :+1:
George Bateman
@GKFX
Wonderful, will push to master.dev for another test
any luck?
Charlie Jonas
@CHTJonas
Gimme a sec sorry!
More difficult to test on dev
Yeah it seems to work now. Returns blank arrays as the default admin user doesn't 'own' anything by default but at least it doesn't error now
Can you deploy to prod?
George Bateman
@GKFX
Yep I've started deployment. Thanks for spotting this!
Charlie Jonas
@CHTJonas
No worries!
Charlie Jonas
@CHTJonas
Anyone know what the point of the ExternalUser -> Person relationship is?
I totally get and understand both ExternalUser -> User and Person -> User, but ExternalUser -> Person doesn't make much sense to me. What's more is that sometimes this relationship is set but other times it isn't: SELECT id, user_id, service, username, name, email, person_id, last_login_at FROM acts_external_users WHERE person_id IS NOT NULL; isn't particularly revealing...
Stuart Cuthbertson
@philosophicles
Not certain but I think users can have a row in ExternalUser without a row in User?
At which point we need to be able to map from (EU xor U) to P.
George Bateman
@GKFX

Users can exist in ExternalUser with null user_id but I think that is a bug. If I go to my externaluser and set user_id = NULL it gets automatically fixed on my next login back to user_id = 4093. On the other hand if I also change my email address (so the software can't automatically fix the null user_id) it acts as though my externaluser doesn't exist and asks me to set up a new account.

I think we should go through the externaluser table and fix all the null user_id's that would be fixed if they logged in (should be an SQL one-liner) then delete the rest, set acts_external_user.user_id to non-nullable, and delete acts_external_user.person_id.

Peter Hoyes
@hoyes
@GKFX what was the issue with liip/imagine-bundle:2.3 out of interest (in the symfony4 branch)? I've just tried remove the version conflict here and it seems to work OK for me.
George Bateman
@GKFX
All the images on the home page disappear if you use version 2.3 - they put in liip/LiipImagineBundle@b77558c which strips all parts of the URL except the path. This means the library can't access images on external domains such as Twitter.
Peter Hoyes
@hoyes
ah that's annoying
Charlie Jonas
@CHTJonas
Was that intentional do you know and if so is there an open issue?
George Bateman
@GKFX
I opened a PR to revert it liip/LiipImagineBundle#1240 because it's a daft commit IMO but it's now been like that too long to just revert back change again. There's also discussion at liip/LiipImagineBundle#1172 but I never got around to following up.
Peter Hoyes
@hoyes
I agree the premise of liip/LiipImagineBundle#1116 is flawed. Could we fork and revert (as described in https://medium.com/swlh/using-your-own-forks-with-composer-699358db05d9) until it gets fixed upstream?
Charlie Jonas
@CHTJonas
So liip/LiipImagineBundle#1116 seems to be saying "if I give you an image with query params then strip those params for me because I was too lazy to myself"? That seems... odd.
George Bateman
@GKFX
I have made an updated fork at https://github.com/GKFX/LiipImagineBundle/tree/v2.3.0%2Bcamdram which would be suitable.
Charlie Jonas
@CHTJonas
Just had a look at support ticket 2408 and it seems that I can't get search to work if I type prepositions or articles in
e.g. "nick time" gives the show "In The Nick of Time" but "nick of" and "in the nick" give nothing
also "midsummer" lists all the Shakespeares but "a midsummer" doesn't
Stuart Cuthbertson
@philosophicles
I get the same thing. Can’t explain this OTOH but my first thought is something to do with how stopwords are being handled: https://dev.mysql.com/doc/refman/8.0/en/fulltext-stopwords.html
In my MS SQL Server experience, stop words on full text searches don’t actually, literally, stop anything from working, they just get ignored. However, maybe MySQL is literally stopping when one is present?
George Bateman
@GKFX
It's because the query has plus signs added behind the scenes to introduce an and operator between the words rather than an or. If you do an advanced search without any changes to your query string then the results work fine. Should we just remove the stopword list (by setting innodb_ft_user_stopword_table) from the relevant indices? I don't think we need a stopword list for our application as we aren't indexing whole paragraphs of text and users aren't searching for questions.
Stuart Cuthbertson
@philosophicles
I think to a first approximation, no stopword list would be better for camdram requirements than the default stopword list
Even within the short (36 word) InnoDB default list, I can imagine quite a few potential new writing show titles which are composed solely of stopwords
“this or that”, “who is this?”, etc
Possibly, it’d be better to define a custom stopword list and start with it empty, but allow for potentially adding words in the future.
George Bateman
@GKFX
It looks to me like that’s obligatory anyway, you have to specify a stopword table that exists
Charlie Jonas
@CHTJonas
Yes let's go with the empty stopword list. That sounds like the most sensible thing
George Bateman
@GKFX
I couldn't see how to set session variables in a Doctrine Migration (just writing the set command had no effect) and the minimum token length (read-only variable) needed to be reduced to one anyway to make "a midsummer" return results, so I've set those variables in /etc/mysql/conf.d and rebuilt the indexes from the command line.
Stuart Cuthbertson
@philosophicles
Unrelated to anything above - we are acknowledging Pride Month with our site logo at the moment; can/should we acknowledge Black Lives Matter as well? E.g. left half the heart as-is but right half solid black? (Or black/yellow).
Charlie Jonas
@CHTJonas
Sorry for delay in replying! Yeah that would be a nice idea. I was thinking maybe we could make a static page with an 'official statement' and perhaps some links to educational material and/or petitions so that we're not engaging in slactivism too much?
(i.e. we're actually doing good by directing people to places where they can help rather than just being seen to do good with a symbol in our logo)
Charlie Jonas
@CHTJonas
Has the API news endpoint changed in the release today?
George Bateman
@GKFX
It’s most likely due to the FOSRestBundle upgrade which involved quite a bit of changes to routes. I diffed the full list if routes before and after but it looks like this one just slipped through the net
Stuart Cuthbertson
@philosophicles
Just discovered a bug while trying to create a society - camdram/camdram#942. Think this might be related to route changes as well, maybe?
George Bateman
@GKFX
Yes will look into that one too, you can fix it in your browser by replacing the action of the <form> with /societies.
Stuart Cuthbertson
@philosophicles
Aha, neat trick thanks!
I definitely wasn’t just about to write an insert into statement at the mysql console…