https://www.camdram.net/venues/adc-theatre/shows.json?from=2018-12-01&to=2018-12-03
Expected: return a blank array seeing as there are no performances at the ADC in this date range.
Actual: returns data for ETG because the show's venue matches and at least one of their performances is in the query date range.
https://www.camdram.net/auth/account/organisations.json and https://www.camdram.net/auth/account/shows.json to obtain a list of shows/societies/venues that the user had admin rights for. This no longer seems to work and returns 404 instead.
SELECT id, user_id, service, username, name, email, person_id, last_login_at FROM acts_external_users WHERE person_id IS NOT NULL; isn't particularly revealing...
Users can exist in ExternalUser with null user_id but I think that is a bug. If I go to my externaluser and set user_id = NULL it gets automatically fixed on my next login back to user_id = 4093. On the other hand if I also change my email address (so the software can't automatically fix the null user_id) it acts as though my externaluser doesn't exist and asks me to set up a new account.
I think we should go through the externaluser table and fix all the null user_id's that would be fixed if they logged in (should be an SQL one-liner) then delete the rest, set acts_external_user.user_id to non-nullable, and delete acts_external_user.person_id.