These are chat archives for canjs/canjs

29th
Jul 2015
dylanrtt
@dylanrtt
Jul 29 2015 13:19
@opolyo01 that's probably due to how you defined the Component's ViewModel. For instance, if you define a property on the VM as a new can.Map instead of a plain object, all instances of the VM will reference that map on the protoype instead of cloning it each time
opolyo01
@opolyo01
Jul 29 2015 15:30
Thanks, yes making plain object fixed it.
Guido Smeets
@gsmeets
Jul 29 2015 18:25
hmm, why didn't I find out this chatroom existed earlier? Would've saved me a few issues on Github I reckon
Matthew Phillips
@matthewp
Jul 29 2015 18:59
Hey @whitecolor could you rebase bitovi/canjs#1807 with minor?
Once you do the tests should pass and then I'll merge it in.
Alex
@whitecolor
Jul 29 2015 19:03
@matthewp how should I do it?
@matthewp I will probably make another PR, as I removed an old repo
@matthewp or you can do it yourself and close my
Matthew Phillips
@matthewp
Jul 29 2015 19:10
ok, wanted to give you the credit in the commit
looks like you removed that repo
Alex
@whitecolor
Jul 29 2015 19:16
@matthewp what credit?
Justin Meyer
@justinbmeyer
Jul 29 2015 19:25
@whitecolor I'm here now. Was getting lunch
give me a sec ... I'll make it easier to generate the canjs docs w/o having to get canjs.com
Alex
@whitecolor
Jul 29 2015 19:44
@justinbmeyer ok
Justin Meyer
@justinbmeyer
Jul 29 2015 19:50
@whitecolor I just pushed a change to master. I made it so you can run documentjs from the CanJS repo to get a close approximation of what the site will look like.
so if you merge your change with master
you can run ./node_modules/.bin/documentjs
and this will create a site at ../docs/index.html
Alex
@whitecolor
Jul 29 2015 19:51
@justinbmeyer and if in minor?
Justin Meyer
@justinbmeyer
Jul 29 2015 19:51
and you can navigate to the backup page
give me a second and I can merge the commit to minor as well
Justin Meyer
@justinbmeyer
Jul 29 2015 19:59
ok, added it to minor @whitecolor
after an npm install
you should be able to run
./node_modules/.bin/documentjs
Alex
@whitecolor
Jul 29 2015 20:00
will try now
Justin Meyer
@justinbmeyer
Jul 29 2015 20:00
and see a docs folder next to your canjs folder
Alex
@whitecolor
Jul 29 2015 21:02
@justinbmeyer have got an error while doc gen (on windows)
node_modules\documentjs\node_modules\q\q.js:126
                    throw e;
                          ^
Error: ENOENT, open '...\docs\can|view|autorender.html'
    at Error (native)
also warnings present like:
WARNING!!
There is no @disabletableofcontents tag. did you mean @deprecated ?
WARNING!!
There is no @disabletableofcontents tag. did you mean @deprecated ?
WARNING!!
There is no @siganture tag. did you mean @signature ?
WARNING!!
There is no @returns tag. did you mean @return ?