Is htmlbool types no longer supported in 4.x? like where I could have an attribute
active if set becomes true? The warnings in 3.x seem to indicate this should now be active:from="true"
btw @frank-dspeed I found the part of code that is causing the error from yesterday: It looks like this:
{{#if(isSaving)}}
<div class="loading"></div>
{{else}}
<can-slot this:from="this" name="submit">
<div class="btn-group" role="group" aria-label="Form Buttons">
<button type="button" class="btn btn-primary" on:el:click="dispatchEvent('submit')">
<i class="fa fa-floppy-o"></i> Submit</button>
<button type="button" class="btn btn-primary" on:el:click="dispatchEvent('cancel')">
<i class="fa fa-ban"></i> Cancel</button>
</div>
</can-slot>
{{/if}}
when isSaving gets set to true, the error occurs.
Here's the actual error trace: https://gist.github.com/roemhildtg/bee7fc1d34e8bc2e4dbeb45d649d346c
can-stache-bindings.js:257- can-slot element, attributeListener is undefined, which eventually causes the error
@roemhildtg 'htmlbool' still exists. We do still warn about
{{#if active}}active="active"{{/if}} forms for component tags but that is meant to discourage using the form for passing string values to components.
I think this has been overlooked in the 3->4 process, that stache bindings can set element attribute values using
el:some-attr:from="vmProp" forms but not add and remove the attribute based on truthiness.
Probably a good step for can-stache-bindings is to add
:if as a binding
so
el:active:if="active" would set the attribute if active was true in the parent scope.
but not add and remove the attribute based on truthiness
@bmomberger-bitovi why do you need bindings for that?
I think what we all want is for can-log to STFU.
The question is how.
that warning should only be displayed if
active is a property on the viewModel
which is what is actually deprecated and removed in 4.0
Okay, I misspoke. The htmlbool type works as expected. It was the case where active="true" I think.
So that error above, it seems like the
can-slot element is not getting an attributeListener assigned, but when the element is removed, it looks like can-stache-bindings is trying to remove the undefined attributeListener. Does it sound like I'm on the right track here?
guys
in bitballs its updated
you can look into it at any time :D
currentActive is a property now
does some one know how to debug such errors
Potentially unhandled rejection [4] renderInZone/zonePromise<@http://localhost:8080/src/index.stache:241:17
anonymous/</exports.then/</callback<@http://localhost:8080/node_modules/can-zone/lib/tasks.js:150:12
anonymous/</Task.prototype.run@http://localhost:8080/node_modules/can-zone/lib/zone.js:42:9
anonymous/</Zone.prototype.runTask@http://localhost:8080/node_modules/can-zone/lib/zone.js:184:9
anonymous/</Zone.prototype.waitFor/<@http://localhost:8080/node_modules/can-zone/lib/zone.js:285:10
wrapped@http://localhost:8080/node_modules/can-zone/lib/zones/debug.js:50:17
callWith/<@http://localhost:8080/node_modules/can-zone/lib/tasks.js:161:12
tryCatchReject@http://localhost:8080/node_modules/steal/steal.js:1183:28
runContinuation1@http://localhost:8080/node_modules/steal/steal.js:1142:4
makePromise/Rejected.prototype.when@http://localhost:8080/node_modules/steal/steal.js:963:4
makePromise/Pending.prototype.run@http://localhost:8080/node_modules/steal/steal.js:821:5
[3]</</</Scheduler.prototype._drain@http://localhost:8080/node_modules/steal/steal.js:97:4
Scheduler/this.drain@http://localhost:8080/node_modules/steal/steal.js:62:4
run@http://localhost:8080/node_modules/steal/steal.js:268:4
steal.js:140:22
unhandledRejection/logError<
http://localhost:8080/node_modules/steal/steal.js:140:22
report
http://localhost:8080/node_modules/steal/steal.js:167:5
flush
http://localhost:8080/node_modules/steal/steal.js:189:5
i always have something that fails in zone but i never get to the point where that is
I think you gotta set a breakpoint in the tasks.js, then figure out what is causing the error by tracing up the stack
which tasks js?
its a steal file or what?
can-zone/lib/tasks.js:150
ah good idea again a can-zone-debug :) is needed
I don't really have a great answer though. I've struggled with that myself a bunch. My situation was dealing with socket.io
did you got this break point stuff in can4 working?
which is NOT supported at this point
afaik
socket.io is supported
I haven't gotten 4.x to work yet
Ran into issues with can-util
but you need to wrap it with can-zone
ah do you want a can-util
compatible version?
for migration i have one wait
I wasn't even using can-util
i know i know
it was a fail befor
if you install now fresh it should be fixed
Okay
wait
maybe more easy fix is
simply install my compat version
as this can happen on many places
simply npm install https://github.com/frank-dspeed/can-util --save
till you upgraded all done-ssr and can packages via
npm outdated
to the latest versions
which can take some time
this can-util version uses can-dome-data-state latest
so you don't get this warnings and that
:D
fyi - we can't do this with the real can-util
since it will break canjs 3.0 apps
we can still release can-util 4
and simply pin olders down to 3.xx
i see no problem with that at all
we could, but we're not going to
ya no problem it works now all well
but this can-util version helps migrating
and getting things up fast
so no problem
when all is up to date simply can-util@latest and all is as it should be
so no pain i did the same flow
cool
but the new features
arn't working as expected out of the box
i get no autorender-breakpoints :(
updating donejs to work with canjs 4.0 is still in progress
i have done it
i see no open issues
it works i am using ssr all
The problem is can-util still uses https://github.com/canjs/can-util/blob/master/package.json#L60
and there's a conflict with multiple versions
yes... that's going to stay that way
Ah that's what you were discussing
but nothing in canjs 4.0 should be importing
can-util/dom/*
so nothing should be importing that version of
can-dom-data-state
and nothing did but done-ssr does
the new done-ssr does not
since some hours or 1 day
so now all is working without my git magic
:D
right... donejs might not be totally updated yet
with the done pre versions
@matthewp is working on it
@phillipskevin i did supply my working version as update to the generator
Hmm, So I'm pretty sure I clean installed everything and I'm NOT using done-ssr in a project but I'm getting
steal.js:7390 Error: Error loading "can-component@4.0.0#can-component" at http://192.168.9.83:8081/node_modules/can-component/can-component.js
Error loading "can-component@4.0.0#can-component" from "spectre-canjs@1.0.1#index" at http://192.168.9.83:8081/index.js
Did not find ./node_modules/can-dom-data-state/package.json
Unable to find a compatible version of can-dom-data-state
Wanted: ^1.0.0
Found: 0.2.0
major branch
do you have a package-lock @roemhildtg ?
@roemhildtg delete package-lock delete node_modules
I did delete that at one point. Try that again...
update all packages to latest version
it's a direct dependency of can-component: https://github.com/canjs/can-component/blob/master/package.json#L44
always use npm outdated
is outdated i think
you can also run
npm ls --depth=0 and it will give you scary warnings if dependencies are missing
yes can-component@4.0.1 is current
yes, you two are on the bleeding edge
yes i know :)
but it was anyway needed
the old app stoped working got to big to undebug able
to much time presure
so i choosed to directly migrate because of better errors
:D
at some places it helped!
Aha
i found some wirred stuff i did
+-- can-component@4.0.1
| +-- can-dom-data-state@1.0.1
| `-- can-stache-bindings@4.0.3
| `-- can-dom-data-state@1.0.1
+-- can-connect@2.0.1
| `-- can-view-import@4.0.1
| `-- can-dom-data-state@1.0.1
+-- can-stache@4.0.2
| `-- can-dom-data-state@1.0.1
`-- can-util@3.11.2
+-- can-dom-data-state@0.2.0
+-- can-event-dom-enter@1.0.4
| `-- can-dom-data-state@0.2.0 deduped
`-- can-event-dom-radiochange@1.0.5
`-- can-dom-data-state@0.2.0 deduped
that looks alright
install my can-util version
are you seeing an error with multiple versions of
can-dom-data-state?
Yep
if he sees that its because done-ssr version
are you using steal?
Yep
do npm ls done-ssr
in the browser console, look at
System._traceData.parentMap
Nope, no done-ssr
and see what is loading
can-dom-data-state@0.2.0
an-dom-data-state@0.2.0#can-dom-data-state:
can-util@3.11.2#dom/data/data
:
true
can-util@3.11.2#dom/mutation-observer/document/document
:
true
can-util@3.11.2#js/cid/get-cid
:
true
you're going to have to keep walking up
to see what in your app is loading those things
Okay
my tip for finding that was
sorry there's not an easier way
search inside node_modules for string
can-util/dom/data
also in your project
then you know the package that references it wrong
but also simply run npm outdated
and look if all is latest
then this shouldn't happen
there are things that haven't been updated
what do you mean?
can-connect-feathers 4.0.0-pre.2 4.0.0-pre.2 3.7.1 applications
can-define-backup 1.0.0-pre.1 1.0.0-pre.1 0.0.1 applications
can-util 3.11.2 git git applications
done-autorender 2.0.0-pre.11 2.0.0-pre.11 1.5.2 applications
done-component 2.0.0-pre.1 2.0.0-pre.1 1.0.1 applications
done-serve 2.0.0-pre.0 2.0.0-pre.0 1.5.0 applications
like a 1.0.0 of
can-define-backup hasn't been published
all is updated
ya
that works
with the pre version
i posted about that on the wip issue
i know
thank you for doing that
feathers and define-backup is left but we can use pre versions
they are working for me
but there are other ecosystem things that don't have pres even
i am not using them :D
they arn't importent
lol
but i want to use can-migrate
need to recode that complet
@roemhildtg might be, that's all I mean
found out it crashes badly
:D
why not just put in a PR?
instead of rewriting the whole thing
Alrighty, I'll look into this more tomorrow. Thanks guys!
because its fail by design needs to get rewriten using streams
it errors because to many args
over 2500 000
so
:D
because you didn't specify a glob for the files?
*/
wait
**/*
yeah... why?
was what i used as i got informed
only that works
maybe project to big files to big
i looked into the code for me it was a horror i do a lot of file processing devops tasks
no... you don't need to update your node_modules
i don't talk about node_modules
i have big projects
:D
**/* will update every file in node_modules
but i tryed also in a single component
ah thats not cool
then i got wrong instructions
:D
how would you run can migrate against the src folder?
can-migrate --apply src/*.js
fyi, there is a new version of can-migrate out
can-migrate@2
which has the transforms for canjs 3 -> 4
lets see what it does
at present it looks like looping forever
All done spawn workers
i am not sure what it does
now it finished
i think it did nothing
always unmodifyed
0 OK
did you expect it to change anything?
crazy util :)
no but i expect it tells me all OK
at present the syntax should be well i expect it well
but did it manual
Time elapsed: 0.415seconds
Processing 2 files...
Spawning 2 workers...
Sending 1 files to free worker...
Sending 1 files to free worker...
All done.
Results:
0 errors
2 unmodified
0 skipped
0 ok
it loops like this
and then after a long time stops
yes... so there are 2 js files in your src directory
lol
it ran them both through each of the transforms
and nothing was changed
no i get a endless list
like that with always 2 files
and in the src directory in sub directorys
are many files
ok, try
can-migrate --apply src/**/*.js
ya now it looks working
:D
i get errors
that helps thats what i expected
it shows me where i got typos
a linter might be better at that :smile:
but I'm glad it's working
i will still need to rewrite that
so it don't floods the console
and simply after end displays a result
:D
and i need to do that for stache also or not?
why i am doing only *.js?
there is a
--silent option
to not flood the console
you can do
src/**/* if you want all the files in your src directory
ah */ is still a dream
:D
**/*
throws
yeah
{ Error: spawn E2BIG
at _errnoException (util.js:1003:13)
at ChildProcess.spawn (internal/child_process.js:340:11)
at Object.exports.spawn (child_process.js:499:9)
at module.exports (/usr/local/lib/node_modules/can-migrate/node_modules/execa/index.js:201:26)
at series (/usr/local/lib/node_modules/can-migrate/bin/can-migrate.js:132:12)
at /usr/local/lib/node_modules/can-migrate/node_modules/promise-map-series/index.js:11:14
at tryCatch (/usr/local/lib/node_modules/can-migrate/node_modules/rsvp/dist/rsvp.js:525:12)
at invokeCallback (/usr/local/lib/node_modules/can-migrate/node_modules/rsvp/dist/rsvp.js:538:13)
at publish (/usr/local/lib/node_modules/can-migrate/node_modules/rsvp/dist/rsvp.js:508:7)
at flush (/usr/local/lib/node_modules/can-migrate/node_modules/rsvp/dist/rsvp.js:2415:5) errno: 'E2BIG', code: 'E2BIG', syscall: 'spawn' }
thats why i recode it
E2BIG isn't acepptable
out of my engineering view
E2BIG means over 2,6 million args
to the spawn process
every file in node_modules... recursively
thats why i sayed befor fail by design
no node modules my frind
src has only modlets
you did
src/**/* or just **/*?
src/**/*
any way this should never depend on args
and spawn and all that
i make it a single node process stream
no spawn magic
constant ram and mem usage
also needed on servers with less cpu ram
wow i found out it was less
inside a .component file
damn
this .component files are killing me maybe they are the root of all evil
promises that don't resolve
when i have types in them they fail with a to general error :)
i think they are evil i will replace them as fast as possible
it now first time renders with can-zone
can you open an issue?
in done-component
sure
ah your right
its done-component that loads .component files
tricky :)
evil done-component not component files :) but in general i understand that this will not get easy fix able
component files should get deprecated because they lead to parsing errors and all that
and not good debug able even with optimizing that done-component