These are chat archives for canjs/canjs

16th
Oct 2018
Justin Meyer
@justinbmeyer
Oct 16 2018 14:41
@ivospinheiro taking a look
Are you sure this has the latest can-event-queue?
nm
Ivo Pinheiro
@ivospinheiro
Oct 16 2018 15:05
the latest canjs release already includes the latest version from can-event-queue https://github.com/canjs/canjs/tree/v5.14.0

A different question.
On CanJS 5 is there a way to get the controller?
On CanJS 3 I was getting the controller like this:

const controller = domData.get.call(document.querySelector(selector), "controls")

But it seems that it doesn't work anymore

Justin Meyer
@justinbmeyer
Oct 16 2018 15:50
@ivospinheiro on the event-queue thing .... I need to fix teardown the same way I fixed setup ... will have a fix in a min
Ivo Pinheiro
@ivospinheiro
Oct 16 2018 15:51
Should I open a new ticket?
Justin Meyer
@justinbmeyer
Oct 16 2018 15:51
no, I'm fixing
on "controls" ... I'm not sure what happened there ... I can probably fix that, can you create an issue?
someone switched to using a weakMap
Ivo Pinheiro
@ivospinheiro
Oct 16 2018 16:04
Ticket opened canjs/can-control#128
Apparently it has been changed on this commit:
canjs/can-control@d6536e8
Justin Meyer
@justinbmeyer
Oct 16 2018 16:08
@ivospinheiro released can-event-queue@1.1.2 with a fix for the connect codepen
Ivo Pinheiro
@ivospinheiro
Oct 16 2018 16:14
Thanks @justinbmeyer
For future possible issues do you think that I should keep asking first here on gitter or should I start open a ticket on the github?
Justin Meyer
@justinbmeyer
Oct 16 2018 16:28
making an issue first is always nice
especially if I'm not around
(I was on vacation the last 4 days)
Ivo Pinheiro
@ivospinheiro
Oct 16 2018 16:50
I usually check here if it really is an issue or I was doing something wrong.
But from now on I will open the issue on github
Justin Meyer
@justinbmeyer
Oct 16 2018 17:29
either is fine really
With can-control@4.4.0 you can access the controls with:
import canSymbol from "can-symbol";

element[canSymbol.for("can.controls")] //-> controls
@ivospinheiro
Ivo Pinheiro
@ivospinheiro
Oct 16 2018 17:34
Great!!!
Thanks @justinbmeyer again!