These are chat archives for canjs/canjs

6th
Dec 2018
Frank Lemanschik
@frank-dspeed
Dec 06 2018 15:53
@roemhildtg dont forget to return the disconnected callback
inside of the connected callback
to tear down your listen stuff
else you get memory leaks
Kevin Phillips
@phillipskevin
Dec 06 2018 15:54
if you're only using listenTo it will be cleaned up for you
Frank Lemanschik
@frank-dspeed
Dec 06 2018 15:54
when?
and how
Kevin Phillips
@phillipskevin
Dec 06 2018 15:55
when it is disconnected
Frank Lemanschik
@frank-dspeed
Dec 06 2018 15:55
i am not sure how that works in what scope that runs then
so all code and vars get removed that don't got assigned to a outer scope?
the component is 100% self cleaning?
Kevin Phillips
@phillipskevin
Dec 06 2018 15:56
stopListening gets called, which cleans up everything that was set up with listenTo
Frank Lemanschik
@frank-dspeed
Dec 06 2018 15:56
or does listen to stops listing if the var it listens to don't exists anymore
Kevin Phillips
@phillipskevin
Dec 06 2018 15:56
I'm just talking about disconnected... so when the element is removed from the page
Frank Lemanschik
@frank-dspeed
Dec 06 2018 15:56
ah a function gets called with and without the disconnectedCallback?
Kevin Phillips
@phillipskevin
Dec 06 2018 15:57
as long as you don't return a disconnectedCallback, it will call the default one, which is stopListening
Frank Lemanschik
@frank-dspeed
Dec 06 2018 15:57
a now i understand it better
i am still not finished with my ES2018 fork and don't saw that code anywhere i am still refactoring it all so i can see the bigger picture
i should revisit all the guides i missed the logic guide complet
the code for it is right there
Frank Lemanschik
@frank-dspeed
Dec 06 2018 16:00
yes i have not started with component
i am still working on define define-map list
and observ observer and all this mix up
:D
can-queue all that component will be the last step
by the way do you know why can-define-map don't got finished
?
and can-define-list
you started splitting them out but it don't got finished for v5
Kevin Phillips
@phillipskevin
Dec 06 2018 16:04
yeah, we decided not to do it
Frank Lemanschik
@frank-dspeed
Dec 06 2018 16:05
ah ok i will still do it
Kevin Phillips
@phillipskevin
Dec 06 2018 16:06
there was a problem with how we would have to divide the code
let me try to find where I wrote it up
Frank Lemanschik
@frank-dspeed
Dec 06 2018 16:06
i will rewrite it all to es2018
so it don't matters
it will get a 100% refactored version
i only use the ideas and concepts
as i like it and matched it with most systems
Kevin Phillips
@phillipskevin
Dec 06 2018 16:07
ok
Frank Lemanschik
@frank-dspeed
Dec 06 2018 16:07
can-define gets only a util lib
for this 2 things
as i saw no use case for can-define alone
at the end i am happy when i get a map working that is stream only
and does type validation and so in a extra stream
so more plugin based
and remove the mixin stuff
the mixins made me headache
Kevin Phillips
@phillipskevin
Dec 06 2018 16:09
yeah, we've been talking about a stream-only viewmodel for a while
Frank Lemanschik
@frank-dspeed
Dec 06 2018 16:09
i know i got some working
but it was not as simple as the original
Kevin Phillips
@phillipskevin
Dec 06 2018 16:10
if you have an idea for what you want it to look like, would love to see it in a proposal
Frank Lemanschik
@frank-dspeed
Dec 06 2018 16:10
i need much more tooling
yes thats a good idea i could need some help
would speed up the overall result
i will write a good proposal maybe till end of next week
Kevin Phillips
@phillipskevin
Dec 06 2018 16:12
awesome
Julian
@pYr0x
Dec 06 2018 23:37
hey guys, does anybody used gitlab ci in combination with canjs / mocha and testee?