Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 14 17:40
    nlundquist edited #5424
  • Nov 14 17:40
    nlundquist edited #5424
  • Nov 14 17:39
    nlundquist opened #5424
  • Nov 14 17:39
    nlundquist review_requested #5424
  • Nov 14 17:39

    nlundquist on 107-update-converter-demos

    update can-stache-converters de… (compare)

  • Nov 14 14:32
    greenkeeper[bot] labeled #5423
  • Nov 14 14:32
    greenkeeper[bot] opened #5423
  • Nov 14 14:32

    greenkeeper[bot] on can-route-5.0.1

    fix(package): update can-route … (compare)

  • Nov 13 13:09

    greenkeeper[bot] on steal-tools-2.2.3

    (compare)

  • Nov 13 12:55

    greenkeeper[bot] on steal-tools-2.2.3

    chore(package): update steal-to… (compare)

  • Nov 13 01:44

    greenkeeper[bot] on @webcomponents

    (compare)

  • Nov 13 01:42

    greenkeeper[bot] on @webcomponents

    chore(package): update @webcomp… (compare)

  • Nov 12 05:28
    greenkeeper[bot] commented #5392
  • Nov 12 05:28

    greenkeeper[bot] on core-js-3.4.1

    chore(package): update core-js … (compare)

  • Nov 11 18:03
    greenkeeper[bot] labeled #5422
  • Nov 11 18:03
    greenkeeper[bot] opened #5422
  • Nov 11 18:03

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • Nov 11 18:02
    greenkeeper[bot] commented #5401
  • Nov 11 18:02

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • Nov 10 23:39

    greenkeeper[bot] on @octokit

    (compare)

Nikolay Nadorichev
@Luanre
in inserted event component already have rendered template
Matthew Phillips
@matthewp
it should be empty though, right?
unless you have stuff in your own template
you want to wrap your own template like
{{#if emptyContents}} ... {{/if}}
Nikolay Nadorichev
@Luanre
Ah, yeah, works like a charm, thank you!
my mistake was: {{#if emptyContents}}...{{else}}<content />{{/if}}
Paul Tichonczuk
@tracer99
If a key in a map is "watch", FF throws an error: 'TypeError: missing argument 1 when calling function this[prop]' because watch is a function in can.Map
should I file this as a bug or is there something I'm missing?
Matthew Phillips
@matthewp
there's a function named watch on can.Map?
is that your function?
Paul Tichonczuk
@tracer99
no
sec. I'll get you the details
Matthew Phillips
@matthewp
map = new can.Map
map.watch // -> undefined
Paul Tichonczuk
@tracer99
when I do this in FF I get function
I assumed it was a CanJS thing, but I can't actual find where this function is defined
Paul Tichonczuk
@tracer99
of course I wouldn't be accessing map.watch but running map.attr("watch"); which is when the error is thrown
Matthew Phillips
@matthewp
what happens if you try map.attr("toString") ? same behavior?
Paul Tichonczuk
@tracer99
hah
it returns the toString function reference
it does not throw an error
m.attr("toString", "something"); throws TypeError: [].slice is not a function
Chris Gomez
@akagomez
Can you print the fn with map.watch?
console.log(map.watch)
Paul Tichonczuk
@tracer99
"function watch()"
if you use get and set directly, it works fine
only when using attr does it not work correctly (or accessing the property directly like above)
Matthew Phillips
@matthewp
I would file an issue, might be able to do something about it
I bet we are not using hasOwnProperty
Paul Tichonczuk
@tracer99
I might just fix it and submit a patch
Guido Smeets
@gsmeets

hmm, I just noticed that my can.components don't unregister events when they're removed from the DOM
is that behaviour intentional?

Nothing in the docs state that you should add a remove event that calls this.off(), seems a bit weird to have to do that.

Chris Gomez
@akagomez
@gsmeets That is odd. I found this in component.js, but no calls to .off(): https://github.com/bitovi/canjs/blob/master/component/component.js#L272-L277
Guido Smeets
@gsmeets
hmm, the bug is actually a bit more subtle than I expected
it has to do with block statements being a direct child of a component
I'll see if I can create a simple testcase and I'll create a github issue
Chris Gomez
@akagomez
Groovy. Thanks!
Paul Tichonczuk
@tracer99
Created pull request to fix FF debugging function stupid bitovi/canjs#1877
@matthewp you were 100% correct on the lack of use of hasOwnProperty adding that in three places was the only fix
Guido Smeets
@gsmeets
@akagomez the issue seems to be worse than I thought, in canjs 2.2.7 no component's destroy method is called when removed from the DOM. in 2.2.6 it works fine
Chris Gomez
@akagomez
Eek!
Do you have a test written? If you do, submit a PR and we can bisect the issue.
Thanks for digging into that.
Guido Smeets
@gsmeets
I'll write a test this evening (CEST+1)
Guido Smeets
@gsmeets
I've also found the root cause now
bitovi/canjs@e9450fa
Chris Gomez
@akagomez
Beautiful! That will help.
Guido Smeets
@gsmeets
The solution is a one-liner :), I'll create a PR
Chris Gomez
@akagomez
@gsmeets Cool! Link it here when you do.