Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

canjs/canjs

We CAN build the impossible! https://codepen.io/justinbmeyer/pen/yEGGoK

People

Repo info

Activity

01:04

greenkeeper[bot] commented #5392
01:04

greenkeeper[bot] on core-js-3.5.0

chore(package): update core-js … (compare)
Dec 11 18:34

greenkeeper[bot] labeled #5444
Dec 11 18:34

greenkeeper[bot] opened #5444
Dec 11 18:34

greenkeeper[bot] on can-observable-mixin-1.0.7

fix(package): update can-observ… (compare)
Dec 11 18:30

cherifGsoul on update-infrastructure-page

(compare)
Dec 11 18:30

cherifGsoul on master

Update infrastructure page with… (compare)
Dec 11 18:30

cherifGsoul closed #5441
Dec 11 18:30

cherifGsoul closed #5417
Dec 10 17:40

cherifGsoul review_requested #5443
Dec 10 16:47

cherifGsoul review_requested #5441
Dec 10 16:35

cherifGsoul synchronize #5441
Dec 10 16:35

cherifGsoul on update-infrastructure-page

Fix typos (compare)
Dec 10 10:01

jkeruzec starred canjs/canjs
Dec 09 18:59

cherifGsoul review_requested #5443
Dec 09 18:59

cherifGsoul opened #5443
Dec 09 18:51

cherifGsoul on document-inserted-removed-can6

Add inserted/removed events to … (compare)
Dec 09 15:38

greenkeeper[bot] labeled #5442
Dec 09 15:38

greenkeeper[bot] opened #5442
Dec 09 15:38

greenkeeper[bot] on can-view-live-5.0.1

fix(package): update can-view-l… (compare)

Paul Tichonczuk

@tracer99

if you use get and set directly, it works fine

only when using attr does it not work correctly (or accessing the property directly like above)

Matthew Phillips

@matthewp

I would file an issue, might be able to do something about it

I bet we are not using hasOwnProperty

Paul Tichonczuk

@tracer99

I might just fix it and submit a patch

Guido Smeets

@gsmeets

hmm, I just noticed that my can.components don't unregister events when they're removed from the DOM
is that behaviour intentional?

Nothing in the docs state that you should add a remove event that calls this.off(), seems a bit weird to have to do that.

Chris Gomez

@akagomez

@gsmeets That is odd. I found this in component.js, but no calls to .off(): https://github.com/bitovi/canjs/blob/master/component/component.js#L272-L277

Guido Smeets

@gsmeets

hmm, the bug is actually a bit more subtle than I expected

it has to do with block statements being a direct child of a component

I'll see if I can create a simple testcase and I'll create a github issue

Chris Gomez

@akagomez

Groovy. Thanks!

Paul Tichonczuk

@tracer99

Created pull request to fix FF debugging function stupid bitovi/canjs#1877

@matthewp you were 100% correct on the lack of use of hasOwnProperty adding that in three places was the only fix

Guido Smeets

@gsmeets

@akagomez the issue seems to be worse than I thought, in canjs 2.2.7 no component's destroy method is called when removed from the DOM. in 2.2.6 it works fine

Chris Gomez

@akagomez

Eek!

Do you have a test written? If you do, submit a PR and we can bisect the issue.

Thanks for digging into that.

Guido Smeets

@gsmeets

I'll write a test this evening (CEST+1)

Guido Smeets

@gsmeets

I've also found the root cause now

bitovi/canjs@e9450fa

Chris Gomez

@akagomez

Beautiful! That will help.

Guido Smeets

@gsmeets

The solution is a one-liner :), I'll create a PR

Chris Gomez

@akagomez

@gsmeets Cool! Link it here when you do.

Matthew Phillips

@matthewp

@tracer99 will that work with inherited properties?

Terry

@tmcdonnell87

Hi - I'm wondering if can.js models can be used in a node.js environment. (I haven't found anything solid online either way.) We'd like to do some server-side orchestration - think collecting order data from various different services - and it would be great to re-use code. However, it doesn't seem to be as straightforward as I hoped, as steal is throwing some errors trying to pull in can. Is there an example somewhere in the docs, or is this a bad idea in general?

Chris Gomez

@akagomez

@tmcdonnell87 We recently started a project for dealing with this exact scenario. Check it out: http://donejs.com/

One of the beautiful aspects of the DoneJS project is that you can re-use ALL of your code on client and server (templates, components, models, etc)

@justinbmeyer @daffl and @matthewp can speak more to it if you have specific questions.

Terry

@tmcdonnell87

sweet, I'll take a look

It doesn't seem that done has been updated in a couple years - is it actively maintained?

Chris Gomez

@akagomez

@tmcdonnell87 Are you referring to the repo?

https://github.com/bitovi/donejs

I don’t think that’s the codebase that backs http://donejs.com

I should had been clear, DoneJS is currently in an alpha/beta state.

(not sure which unfortunately)

To that point it’s primarly made up of CanJS/StealJS/DocumentJS and all of those are actively maintained.

Terry

@tmcdonnell87

ah, found the repo from npm

David Luecke

@daffl

@tmcdonnell87 The repository is at https://github.com/donejs/donejs. Working on cleaning that up a little. If you are only looking for server side rendering you also might want to have a look at the CanJS minor branch and https://github.com/canjs/can-ssr

Terry

@tmcdonnell87

we'd want both. we currently have a can.js project that's a pure-client webapp, and we're looking to add some server-side orchestration. When you say donejs is in alpha/beta, which parts are you talking about? (Canjs, steal, etc. are all released)

David Luecke

@daffl

DoneJS is the combination of CanJS + Steal + DocumentJS + FuncUnit and some other glue projects. CanJS 2.3 - which adds support for server-side rendering - is due around the end of the month. There are alpha releases for DoneJS and beta for can-ssr

Paul Tichonczuk

@tracer99

@matthewp I'm not clear on the question. In what circumstance would we care about a map inheriting? The event one might be an issue however.

avg6003

@avg6003

Can anyone tell me what is the use of ' ! ' in defining the routes?

Chris Gomez

@akagomez

Where is it documented that you should use “!” to define routes?

avg6003

@avg6003

i am reading from here http://canjs.com/guides/Routing.html

It says to define a route I have to use '#!' in begining of the rout

what is the reason to use '!' ?

I tried without using !

its working but it automatically takes !

when i press back button then it first adds ! and then I press again the back button then it goes to previous route

Chris Gomez

@akagomez

Ah! I see. I can’t say. I’ve only worked with pushstate routing.