Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 18:27
    greenkeeper[bot] labeled #5392
  • 18:27
    greenkeeper[bot] opened #5392
  • 18:27

    greenkeeper[bot] on core-js-3.3.3

    chore(package): update core-js … (compare)

  • Oct 18 22:20
    greenkeeper[bot] labeled #5391
  • Oct 18 22:20
    greenkeeper[bot] opened #5391
  • Oct 18 22:20

    greenkeeper[bot] on can-observable-mixin-1.0.3

    fix(package): update can-observ… (compare)

  • Oct 18 19:08
    cherifGsoul labeled #5390
  • Oct 18 19:07
    cherifGsoul opened #5390
  • Oct 18 18:45
    greenkeeper[bot] labeled #5389
  • Oct 18 18:45
    greenkeeper[bot] opened #5389
  • Oct 18 18:45

    greenkeeper[bot] on can-observable-bindings-1.3.0

    fix(package): update can-observ… (compare)

  • Oct 18 18:29

    matthewp on master

    Update dist for release (compare)

  • Oct 18 18:29

    matthewp on v6.1.3

    Update dist for release 6.1.3 (compare)

  • Oct 18 17:59

    matthewp on can-observable-array-1.0.2

    (compare)

  • Oct 18 17:59

    matthewp on master

    fix(package): update can-observ… Merge pull request #5388 from c… (compare)

  • Oct 18 17:59
    matthewp closed #5388
  • Oct 18 16:46
    greenkeeper[bot] labeled #5388
  • Oct 18 16:46
    greenkeeper[bot] opened #5388
  • Oct 18 16:46

    greenkeeper[bot] on can-observable-array-1.0.2

    fix(package): update can-observ… (compare)

  • Oct 18 12:45
    greenkeeper[bot] labeled #5387
Paul Tichonczuk
@tracer99
I might just fix it and submit a patch
Guido Smeets
@gsmeets

hmm, I just noticed that my can.components don't unregister events when they're removed from the DOM
is that behaviour intentional?

Nothing in the docs state that you should add a remove event that calls this.off(), seems a bit weird to have to do that.

Chris Gomez
@akagomez
@gsmeets That is odd. I found this in component.js, but no calls to .off(): https://github.com/bitovi/canjs/blob/master/component/component.js#L272-L277
Guido Smeets
@gsmeets
hmm, the bug is actually a bit more subtle than I expected
it has to do with block statements being a direct child of a component
I'll see if I can create a simple testcase and I'll create a github issue
Chris Gomez
@akagomez
Groovy. Thanks!
Paul Tichonczuk
@tracer99
Created pull request to fix FF debugging function stupid bitovi/canjs#1877
@matthewp you were 100% correct on the lack of use of hasOwnProperty adding that in three places was the only fix
Guido Smeets
@gsmeets
@akagomez the issue seems to be worse than I thought, in canjs 2.2.7 no component's destroy method is called when removed from the DOM. in 2.2.6 it works fine
Chris Gomez
@akagomez
Eek!
Do you have a test written? If you do, submit a PR and we can bisect the issue.
Thanks for digging into that.
Guido Smeets
@gsmeets
I'll write a test this evening (CEST+1)
Guido Smeets
@gsmeets
I've also found the root cause now
bitovi/canjs@e9450fa
Chris Gomez
@akagomez
Beautiful! That will help.
Guido Smeets
@gsmeets
The solution is a one-liner :), I'll create a PR
Chris Gomez
@akagomez
@gsmeets Cool! Link it here when you do.
Matthew Phillips
@matthewp
@tracer99 will that work with inherited properties?
Terry
@tmcdonnell87
Hi - I'm wondering if can.js models can be used in a node.js environment. (I haven't found anything solid online either way.) We'd like to do some server-side orchestration - think collecting order data from various different services - and it would be great to re-use code. However, it doesn't seem to be as straightforward as I hoped, as steal is throwing some errors trying to pull in can. Is there an example somewhere in the docs, or is this a bad idea in general?
Chris Gomez
@akagomez
@tmcdonnell87 We recently started a project for dealing with this exact scenario. Check it out: http://donejs.com/
One of the beautiful aspects of the DoneJS project is that you can re-use ALL of your code on client and server (templates, components, models, etc)
@justinbmeyer @daffl and @matthewp can speak more to it if you have specific questions.
Terry
@tmcdonnell87
sweet, I'll take a look
It doesn't seem that done has been updated in a couple years - is it actively maintained?
Chris Gomez
@akagomez
@tmcdonnell87 Are you referring to the repo?
I don’t think that’s the codebase that backs http://donejs.com
I should had been clear, DoneJS is currently in an alpha/beta state.
(not sure which unfortunately)
To that point it’s primarly made up of CanJS/StealJS/DocumentJS and all of those are actively maintained.
Terry
@tmcdonnell87
ah, found the repo from npm
David Luecke
@daffl
@tmcdonnell87 The repository is at https://github.com/donejs/donejs. Working on cleaning that up a little. If you are only looking for server side rendering you also might want to have a look at the CanJS minor branch and https://github.com/canjs/can-ssr
Terry
@tmcdonnell87
we'd want both. we currently have a can.js project that's a pure-client webapp, and we're looking to add some server-side orchestration. When you say donejs is in alpha/beta, which parts are you talking about? (Canjs, steal, etc. are all released)
David Luecke
@daffl
DoneJS is the combination of CanJS + Steal + DocumentJS + FuncUnit and some other glue projects. CanJS 2.3 - which adds support for server-side rendering - is due around the end of the month. There are alpha releases for DoneJS and beta for can-ssr
Paul Tichonczuk
@tracer99
@matthewp I'm not clear on the question. In what circumstance would we care about a map inheriting? The event one might be an issue however.
avg6003
@avg6003
Can anyone tell me what is the use of ' ! ' in defining the routes?
Chris Gomez
@akagomez
Where is it documented that you should use “!” to define routes?
avg6003
@avg6003
i am reading from here http://canjs.com/guides/Routing.html
It says to define a route I have to use '#!' in begining of the rout
what is the reason to use '!' ?
I tried without using !
its working but it automatically takes !
when i press back button then it first adds ! and then I press again the back button then it goes to previous route
Chris Gomez
@akagomez
Ah! I see. I can’t say. I’ve only worked with pushstate routing.
avg6003
@avg6003
do you know any source where I can find the reason?
Chris Gomez
@akagomez
avg6003
@avg6003
thanx
let me check