Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 21 15:43
    denazebiz starred canjs/canjs
  • Jun 17 00:44
    boticello starred canjs/canjs
  • Jun 15 16:39
  • Jun 07 16:47
    justinbmeyer assigned #5517
  • Jun 07 16:44
    bmomberger-bitovi labeled #5517
  • Jun 07 16:44
    bmomberger-bitovi opened #5517
  • Jun 07 16:44
    bmomberger-bitovi labeled #5517
  • Jun 07 16:44
    bmomberger-bitovi labeled #5517
  • Jun 07 11:52
    maxloh starred canjs/canjs
  • Jun 04 04:31
    MarymagdalenaX86 starred canjs/canjs
  • Jun 03 05:09
    JonReppDirectOneDesign starred canjs/canjs
  • May 20 21:13
    justinbmeyer opened #5516
  • May 19 10:38
    Heartnett starred canjs/canjs
  • May 14 20:56
    leodutra starred canjs/canjs
  • May 11 09:07
    frank-dspeed edited #5515
  • May 11 09:05
    frank-dspeed edited #5515
  • May 11 09:01
    frank-dspeed edited #5515
  • May 11 08:52
    frank-dspeed opened #5515
  • May 07 12:16
    eddyralston starred canjs/canjs
  • May 03 20:07
    Jakedalus starred canjs/canjs
Julian
@pYr0x
@RALifeCoach can you reproduce this issue with lazymap on a simple and short example
Christopher Oliphant
@RALifeCoach
I knew someone was going to ask that. Yes I can.
Julian
@pYr0x
;) we have to make tests for CI
so a test that reproduce this problem is the first step to fix this
btw. can-map-lazy is currently for canjs 3.0
not for 2.x
Kevin Phillips
@phillipskevin
thanks, I was trying to figure that out
Christopher Oliphant
@RALifeCoach
I know it’s scheduled for 3.0, but gave me the best performance improvement so far
Kevin Phillips
@phillipskevin
require(‘can/map/lazy'); without installing can-map-lazy
there is a can.LazyMap plugin for 2.x also
right @pYr0x ?
Julian
@pYr0x
lazymap is currently (in canjs 2.x) integrated.
if i understand right, you have problems with nested properties?
Kevin Phillips
@phillipskevin
Christopher Oliphant
@RALifeCoach
yes - nested properties are causing the problem
Julian
@pYr0x
@phillipskevin yep, lazymap extends can.map
@RALifeCoach this stache isnt very short
and the test also
Christopher Oliphant
@RALifeCoach
Sorry - I can pare it down
Julian
@pYr0x
why?
this code isnt a testable code...
Christopher Oliphant
@RALifeCoach
it is much shorter now
Julian
@pYr0x
so we need the component?
can you remove that
Christopher Oliphant
@RALifeCoach
Better?
Julian
@pYr0x
didnt see any changes?
still a component
Christopher Oliphant
@RALifeCoach
yes there is still a component
how’s how my code works
Julian
@pYr0x
can you remove that too
Christopher Oliphant
@RALifeCoach
When I removed the component it stopped crashing
Julian
@pYr0x
;)
good to know
so the problem is not lazymap
it is the component?
Christopher Oliphant
@RALifeCoach
the line of code that is throwing the exception is in lazy map
Julian
@pYr0x
yes.. but the problem can come from other code
Kevin Phillips
@phillipskevin
the component probably causes lazyMap to set up the binding
the component binds, and lazymap tries to initialize the data
Christopher Oliphant
@RALifeCoach
it has to do with observables - and the component is the one telling lazy map to create the observable. If I knew the canJS code better, I could probably re-create without the component.
Kevin Phillips
@phillipskevin
just do theMap.bind(‘whatever.data.that.fails’, function() { … })
to bind to the map manually
Christopher Oliphant
@RALifeCoach
that didn’t crash either
At this point, the code is as small as I can make it and still have it crash. The bug may be in lazy map, it may be in component, it may be somewhere else altogether.
here is the latest - I will also post the link in the issue