Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 17:39
    JuanFelix88 starred canjs/canjs
  • Feb 26 05:49
    hawk-ee starred canjs/canjs
  • Feb 25 18:23
    jxjxnyc starred canjs/canjs
  • Feb 25 14:59
    simondarke starred canjs/canjs
  • Feb 24 04:06
    BenitoJedai starred canjs/canjs
  • Feb 21 16:19
    cherifGsoul labeled #5427
  • Feb 21 16:19
    cherifGsoul labeled #5427
  • Feb 21 16:15
    cherifGsoul labeled #5433
  • Feb 21 16:15
    cherifGsoul commented #5433
  • Feb 21 15:53
    cherifGsoul labeled #5464
  • Feb 21 15:51
    cherifGsoul labeled #5465
  • Feb 21 15:51
    cherifGsoul labeled #5466
  • Feb 21 15:49
    cherifGsoul labeled #5467
  • Feb 21 15:45
    cherifGsoul labeled #5468
  • Feb 21 15:44
    cherifGsoul labeled #5468
  • Feb 20 20:57
  • Feb 20 20:42
    greenkeeper[bot] labeled #5469
  • Feb 20 20:42
    greenkeeper[bot] opened #5469
  • Feb 20 20:42

    greenkeeper[bot] on @octokit

    chore(package): update @octokit… (compare)

  • Feb 18 23:43
    1d0n7kn0w starred canjs/canjs
Christopher Oliphant
@RALifeCoach
I knew someone was going to ask that. Yes I can.
Julian
@pYr0x
;) we have to make tests for CI
so a test that reproduce this problem is the first step to fix this
btw. can-map-lazy is currently for canjs 3.0
not for 2.x
Kevin Phillips
@phillipskevin
thanks, I was trying to figure that out
Christopher Oliphant
@RALifeCoach
I know it’s scheduled for 3.0, but gave me the best performance improvement so far
Kevin Phillips
@phillipskevin
require(‘can/map/lazy'); without installing can-map-lazy
there is a can.LazyMap plugin for 2.x also
right @pYr0x ?
Julian
@pYr0x
lazymap is currently (in canjs 2.x) integrated.
if i understand right, you have problems with nested properties?
Kevin Phillips
@phillipskevin
Christopher Oliphant
@RALifeCoach
yes - nested properties are causing the problem
Julian
@pYr0x
@phillipskevin yep, lazymap extends can.map
@RALifeCoach this stache isnt very short
and the test also
Christopher Oliphant
@RALifeCoach
Sorry - I can pare it down
Julian
@pYr0x
why?
this code isnt a testable code...
Christopher Oliphant
@RALifeCoach
it is much shorter now
Julian
@pYr0x
so we need the component?
can you remove that
Christopher Oliphant
@RALifeCoach
Better?
Julian
@pYr0x
didnt see any changes?
still a component
Christopher Oliphant
@RALifeCoach
yes there is still a component
how’s how my code works
Julian
@pYr0x
can you remove that too
Christopher Oliphant
@RALifeCoach
When I removed the component it stopped crashing
Julian
@pYr0x
;)
good to know
so the problem is not lazymap
it is the component?
Christopher Oliphant
@RALifeCoach
the line of code that is throwing the exception is in lazy map
Julian
@pYr0x
yes.. but the problem can come from other code
Kevin Phillips
@phillipskevin
the component probably causes lazyMap to set up the binding
the component binds, and lazymap tries to initialize the data
Christopher Oliphant
@RALifeCoach
it has to do with observables - and the component is the one telling lazy map to create the observable. If I knew the canJS code better, I could probably re-create without the component.
Kevin Phillips
@phillipskevin
just do theMap.bind(‘whatever.data.that.fails’, function() { … })
to bind to the map manually
Christopher Oliphant
@RALifeCoach
that didn’t crash either
At this point, the code is as small as I can make it and still have it crash. The bug may be in lazy map, it may be in component, it may be somewhere else altogether.
here is the latest - I will also post the link in the issue