Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 25 14:39
    joe-no-body starred canjs/canjs
  • Jan 23 02:23
    kl1010 starred canjs/canjs
  • Jan 15 07:57
    rjgotten commented #5511
  • Jan 14 19:48
    cherifGsoul commented #5511
  • Dec 30 2020 17:45
    cherifGsoul assigned #5513
  • Dec 29 2020 15:54

    cherifGsoul on upgrade-docs-html-canjs

    (compare)

  • Dec 29 2020 15:48

    cherifGsoul on master

    Upgrade the site theme for new … (compare)

  • Dec 29 2020 15:48
    cherifGsoul closed #5514
  • Dec 29 2020 13:26
    hameema starred canjs/canjs
  • Dec 28 2020 19:16
    cherifGsoul opened #5514
  • Dec 28 2020 19:11

    cherifGsoul on upgrade-docs-html-canjs

    Upgrade the site theme for new … (compare)

  • Dec 14 2020 06:24
    bozaigao starred canjs/canjs
  • Dec 11 2020 16:25
    cherifGsoul reopened #5495
  • Dec 10 2020 20:45
    cherifyazid starred canjs/canjs
  • Dec 10 2020 20:34
    chaouanabil starred canjs/canjs
  • Dec 10 2020 20:31
    cherifGsoul closed #5508
  • Dec 10 2020 20:31
    cherifGsoul commented #5508
  • Dec 10 2020 19:42
    cherifGsoul closed #5491
  • Dec 10 2020 19:42
    cherifGsoul commented #5491
Julian
@pYr0x
btw. can-map-lazy is currently for canjs 3.0
not for 2.x
Kevin Phillips
@phillipskevin
thanks, I was trying to figure that out
Christopher Oliphant
@RALifeCoach
I know it’s scheduled for 3.0, but gave me the best performance improvement so far
Kevin Phillips
@phillipskevin
require(‘can/map/lazy'); without installing can-map-lazy
there is a can.LazyMap plugin for 2.x also
right @pYr0x ?
Julian
@pYr0x
lazymap is currently (in canjs 2.x) integrated.
if i understand right, you have problems with nested properties?
Kevin Phillips
@phillipskevin
Christopher Oliphant
@RALifeCoach
yes - nested properties are causing the problem
Julian
@pYr0x
@phillipskevin yep, lazymap extends can.map
@RALifeCoach this stache isnt very short
and the test also
Christopher Oliphant
@RALifeCoach
Sorry - I can pare it down
Julian
@pYr0x
why?
this code isnt a testable code...
Christopher Oliphant
@RALifeCoach
it is much shorter now
Julian
@pYr0x
so we need the component?
can you remove that
Christopher Oliphant
@RALifeCoach
Better?
Julian
@pYr0x
didnt see any changes?
still a component
Christopher Oliphant
@RALifeCoach
yes there is still a component
how’s how my code works
Julian
@pYr0x
can you remove that too
Christopher Oliphant
@RALifeCoach
When I removed the component it stopped crashing
Julian
@pYr0x
;)
good to know
so the problem is not lazymap
it is the component?
Christopher Oliphant
@RALifeCoach
the line of code that is throwing the exception is in lazy map
Julian
@pYr0x
yes.. but the problem can come from other code
Kevin Phillips
@phillipskevin
the component probably causes lazyMap to set up the binding
the component binds, and lazymap tries to initialize the data
Christopher Oliphant
@RALifeCoach
it has to do with observables - and the component is the one telling lazy map to create the observable. If I knew the canJS code better, I could probably re-create without the component.
Kevin Phillips
@phillipskevin
just do theMap.bind(‘whatever.data.that.fails’, function() { … })
to bind to the map manually
Christopher Oliphant
@RALifeCoach
that didn’t crash either
At this point, the code is as small as I can make it and still have it crash. The bug may be in lazy map, it may be in component, it may be somewhere else altogether.
here is the latest - I will also post the link in the issue
Kevin Phillips
@phillipskevin
@RALifeCoach so your performace is better now using LazyMap?
Christopher Oliphant
@RALifeCoach
I am working through the changes now and I will keep you posted
the update is now down to 1 second