Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 21:13
    greenkeeper[bot] labeled #5378
  • 21:12
    greenkeeper[bot] opened #5378
  • 21:12

    greenkeeper[bot] on can-simple-map-4.3.3

    fix(package): update can-simple… (compare)

  • 20:19
    greenkeeper[bot] labeled #5377
  • 20:19
    greenkeeper[bot] opened #5377
  • 20:19

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • 20:18
    greenkeeper[bot] labeled #5376
  • 20:18
    greenkeeper[bot] opened #5376
  • 20:18

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • 14:43
    greenkeeper[bot] closed #5373
  • 14:43

    greenkeeper[bot] on can-deep-observable-1.0.1

    (compare)

  • 14:42

    m-mujica on update-deep-observable

    (compare)

  • 14:42

    m-mujica on master

    Update can-deep-observable to l… Merge pull request #5374 from c… (compare)

  • 14:42
    m-mujica closed #5374
  • 14:42
    m-mujica closed #5365
  • 14:09
    f-ricci starred canjs/canjs
  • 13:55
    greenkeeper[bot] commented #5375
  • 13:55

    greenkeeper[bot] on core-js-3.3.2

    chore(package): update core-js … (compare)

  • 10:51
    m-mujica review_requested #5374
  • 07:43
    rjgotten commented #5358
Dovid Bleier
@dbleier
@cherifGsoul not in stache, on VM methods that are not stache related, for internal non-visual processing
related to that, when can-connect fall-through-cache updates the List after retrieving updates from the server, I want it to call methods in my VM
I am currently sifting thru can-connect code to understand how it updates the list
Mohamed Cherif Bouchelaghem
@cherifGsoul
you should bind an event handler on that compute
Dovid Bleier
@dbleier
how do I do that inside of a map? all the examples I saw use bind as an external line of code
Mohamed Cherif Bouchelaghem
@cherifGsoul
@dbleier do you use can.map.define plugin?
Dovid Bleier
@dbleier
do you mean in viewModel: { events: { {someprop change}: function()
yes
Mohamed Cherif Bouchelaghem
@cherifGsoul
so you can have set setter on that prop that invoke your method
Dovid Bleier
@dbleier
ah right, let me think about how that would work in my design
Mohamed Cherif Bouchelaghem
@cherifGsoul
ok
Dovid Bleier
@dbleier
@cherifGsoul do you know if when fall-through-cache updates, it calls the setter of the prop that called getList?
for example
signPromise: {
   get(lastval, set) {
      return Sign.getList({...});
  },
  set(newval) {
  }
},
sign: {
   get(lastval, set) {
    this.attr('signPromise').then(function(signs) { set(signs[0]);}
  },
  set(newval) {
  }
}
Christopher Oliphant
@RALifeCoach

further to this discussion, I have a component with it’s internal viewModel i.e.

can.Component.extend({
tag: ‘my-component’,
template: can.view(‘#some-template’),
viewModel: {
    define: {
        xxx: { type: ‘string’ }
    }
}
});

I add the component to my page via:

var template = can.stache(‘<my-component id="me"></my-component>’)
$(‘body”).append(template());
var myComponent = $(‘#me’);
myComponent.bind(??????);

I want to bind to the component to know when the value of xxx changes.

Dovid Bleier
@dbleier
what would I bind to to emit a change event when the List is updated?
Mohamed Cherif Bouchelaghem
@cherifGsoul
@dbleier I think you should listen to sign changes
Dovid Bleier
@dbleier
sign the VM prop or the connect prop?
I don't think the sign getter is called again after the list is updated
at least I don't see that happening
Mohamed Cherif Bouchelaghem
@cherifGsoul
the setter should be called
@RALifeCoach we can not make it like that
@dbleier sorry I didnt have a closer look at fall-through-cachebehavior so I dont know how it realy does things :/
Dovid Bleier
@dbleier
@cherifGsoul I just but a debugger; line in set for both signPromise and sign and neither got hit
Mohamed Cherif Bouchelaghem
@cherifGsoul
@dbleier can you make a jsbin?
Dovid Bleier
@dbleier
ok
Christopher Oliphant
@RALifeCoach
@cherifGsoul okay, that’s what I thought. What I have done is trigger an event from within the component and listen for the event in the owning module. That works.
Mohamed Cherif Bouchelaghem
@cherifGsoul
@RALifeCoach
   can.Component.extend({
tag: ‘my-component’,
template: can.view(‘#some-template’),
viewModel: {
    define: {
        xxx: { type: ‘string’ }
    }
},
events: {
"{viewModel} xxx":function(){
}
}
});
Justin Meyer
@justinbmeyer
@RALifeCoach was unable to read all of what you wrote ... but I want to address one thing you said .... CanJS, and most frameworks, make your life easier, but that always comes at some performance cost
C makes your life easier than assembly, but at some cost
JavaScript makes your life easier than C, but at some cost
CanJS makes your life easier than plain JS, but at some cost
Why does CanJS's observables covert the entire object into an observable? Because when MOST properties are used (which is the case for MOST apps), its faster to do all of them right away instead of progressively convert them like LazyMap
Christopher Oliphant
@RALifeCoach
@justinbmeyer I am willing to accept some performance hit when initially creating the page. I was surprised when updating the page took even longer. My expectation was that Can JS would be quick and efficient especially when no DOM updates were required.
Justin Meyer
@justinbmeyer
CanJS's observables are "quick" but not quick compared to plain JS objects
they have been worked on a lot to make performance as fast as possible
btw, if you have objects that you don't need observable, you can define their type like "type": "*"
with the define plugin
those objects will not be converted to Maps / Lists
Christopher Oliphant
@RALifeCoach
When I strip down the big object to be an object that contains only needed properties, there is slight improvement on initial load and a huge improvement on update.
I did make use of type: ‘*’ - that gave some improvement
Justin Meyer
@justinbmeyer
the improvement on update doesn't make sense
I wonder if this is what @Bajix was talking about
are you listening to "change" events?
the number of props shouldn't matter to update
ah ... if you are listening to "change" events ... then @Bajix is also right that additional slowness will be introduced
in the initial render
b/c bubbling will need to be setup
Christopher Oliphant
@RALifeCoach
I don’t have a need to fire events on data changing. The only events would be internal to the UI. (Updating the DOM when a value changed.)
Justin Meyer
@justinbmeyer
not sure what that means ... does that mean no, you are not binding on "change" events?