Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 07:26

    greenkeeper[bot] on webpack-cli-3.3.9

    (compare)

  • 07:18

    greenkeeper[bot] on webpack-cli-3.3.9

    chore(package): update webpack-… (compare)

  • 04:54
    justinbmeyer commented #5290
  • Sep 16 20:45
    matthewp commented #5291
  • Sep 16 20:44
    matthewp synchronize #5291
  • Sep 16 20:44

    matthewp on type8

    Increase bundlesize for core T… (compare)

  • Sep 16 20:30
    matthewp opened #5291
  • Sep 16 20:29

    matthewp on type8

    Upgrade to can-type 1.0.0-pre.8 (compare)

  • Sep 16 20:23
    phillipskevin labeled #5290
  • Sep 16 20:23
    phillipskevin labeled #5290
  • Sep 16 20:23
    phillipskevin opened #5290
  • Sep 16 19:56

    chasenlehara on major

    Bump can-connect version (compare)

  • Sep 16 18:12
    greenkeeper[bot] labeled #5289
  • Sep 16 18:12
    greenkeeper[bot] opened #5289
  • Sep 16 18:11

    greenkeeper[bot] on can-map-4.3.10

    fix(package): update can-map to… (compare)

  • Sep 16 17:51

    chasenlehara on major

    Update dependencies for 5.33.1 Update dist for release Merge branch 'master' into major (compare)

  • Sep 16 17:34

    chasenlehara on master

    Update dist for release (compare)

  • Sep 16 17:34

    chasenlehara on v5.33.1

    Update dist for release 5.33.1 (compare)

  • Sep 16 17:20
    greenkeeper[bot] closed #5285
  • Sep 16 17:20

    greenkeeper[bot] on can-stache-4.17.21

    (compare)

Christopher Oliphant
@RALifeCoach
Leath Cooper
@IcculusC
yep
going to draft up an issue soon
back in a bit
Christopher Oliphant
@RALifeCoach
That should be simple - point to the demo on their docs page. It has the same result.
Mason Shin
@minsooshin
if I route from A to B, component A’s removed event called later than component B’s inserted event. Is there a way to make sure previous page’s component removed event called first?
Leath Cooper
@IcculusC
lol @RALifeCoach guess waht
I went to start writing a detailed explanation of the issue and I go to the repo
and it's been fixed, just not released
Christopher Oliphant
@RALifeCoach
When is the release scheduled?
Leath Cooper
@IcculusC
haven't looked lol but it was fixed 7 hours ago
Matthew Phillips
@matthewp
@RALifeCoach yes, you define it as a definemap
no more regular Maps
var ViewModel = DefineMap.extend({
  prop: "string"
});

var vm = new ViewModel();
vm.prop = 'foo';
Christopher Oliphant
@RALifeCoach
Thanks @matthewp I was finally able to get it all working.
Matthew Phillips
@matthewp
there's some examples in the major branch you might want to look at
kind of show how DefineMaps are used as vms
Leath Cooper
@IcculusC
will be nice if there's a warning for viewModel vs ViewModel too
Christopher Oliphant
@RALifeCoach
It turned out I had an error in one of my sub-maps. I discovered that by defining the map outside of the component.
Matthew Phillips
@matthewp
viewModel still exists, what would the warning be?
Leath Cooper
@IcculusC
well if you use a DefineMap it doesn't act as expected
Matthew Phillips
@matthewp
right
i forgot why exactly that was
Christopher Oliphant
@RALifeCoach
Also I had to use ViewModel in my component, not viewModel
Leath Cooper
@IcculusC
so maybe the distinction between an instance of Map vs DefineMap and vM vs V
M
Matthew Phillips
@matthewp
maybe we should just warn against using viewModel at all
Leath Cooper
@IcculusC
and a warning if you're using them wrong
also @matthewp good to see those new releases I banged my head against the wall over that expr.hash issue for 3 days before I decided to track it down... then you fix it on the same day lol
Matthew Phillips
@matthewp
ah, sorry
that stuff was broken for a little while
Leath Cooper
@IcculusC
was typing up a detailed issue for you and I went to check the line number and you'd fixed it
Matthew Phillips
@matthewp
I think you're right about viewModel vs ViewModel but I'm not sure what the solution is
can you post an issue in can-component?
Leath Cooper
@IcculusC
nah I was more amused than anything
yeah I'll recreate it and get some details
Christopher Oliphant
@RALifeCoach
Leath and I worked it out
Leath Cooper
@IcculusC
I think if you instantiate an instance of your DefineMap with viewModel it works
but if you just pass the constructor you extended it doesn't
Matthew Phillips
@matthewp
the problem is that can-component doesn't depend on DefineMap so it wouldn't have a way to detect that viewModel is a DefineMap
Christopher Oliphant
@RALifeCoach
But I do have questions regarding getting production ready when using StealJS.
Leath Cooper
@IcculusC
yeah I suppose there's no really good way to do that
without including them so you can do instanceof
and bloat dependencies
Matthew Phillips
@matthewp
yeah
Justin Meyer
@justinbmeyer

@IcculusC

and when I wa susing map I had to create an instance of the view model manually

what do you mean by that?
Christopher Oliphant
@RALifeCoach
I don’t want my production page retrieving 80 small files. Can CanJS and all my JS files be merged for production?
Justin Meyer
@justinbmeyer
generally speaking, one should not be using a single instance for every component