Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 17 20:12

    matthewp on master

    Update dist for release (compare)

  • Oct 17 20:12

    matthewp on v6.1.2

    Update dist for release 6.1.2 (compare)

  • Oct 17 20:04

    matthewp on master

    Update dist for release (compare)

  • Oct 17 20:04

    matthewp on v6.1.2-0

    Update dist for release 6.1.2-0 (compare)

  • Oct 17 19:17
    akbaruddin starred canjs/canjs
  • Oct 17 17:25
    matthewp edited #5384
  • Oct 17 17:00

    matthewp on can-dom-mutate-2.0.7

    (compare)

  • Oct 17 17:00

    matthewp on master

    fix(package): update can-dom-mu… Merge pull request #5386 from c… (compare)

  • Oct 17 17:00
    matthewp closed #5386
  • Oct 17 16:27
    greenkeeper[bot] labeled #5386
  • Oct 17 16:27
    greenkeeper[bot] opened #5386
  • Oct 17 16:27

    greenkeeper[bot] on can-dom-mutate-2.0.7

    fix(package): update can-dom-mu… (compare)

  • Oct 17 16:25

    matthewp on can-dom-mutate-2.0.6

    (compare)

  • Oct 17 16:24
    matthewp closed #5379
  • Oct 17 16:24
    matthewp commented #5379
  • Oct 17 15:26

    greenkeeper[bot] on can-type-1.1.2

    (compare)

  • Oct 17 15:26

    matthewp on master

    fix(package): update can-type t… Merge pull request #5385 from c… (compare)

  • Oct 17 15:26
    matthewp closed #5385
  • Oct 17 14:11
    matthewp closed #5377
  • Oct 17 14:11
    matthewp closed #5376
Thomas Sieverding
@Bajix
So onlineAt would be the time my connection goes online
This was pre can-connect
My models were setup to emit newInstance on prototype.init on their constructor
I was combining the two data sets manually
Christopher Oliphant
@RALifeCoach
back to steal-tools - I have in my package.son
  "system": {
    "main": "modules/page.players-redesign/player-bio/components/player-bio.js"
  },
/git/pgatour-cq-v2/front-end/node_modules/steal-tools/lib/graph/make_graph_with_bundles.js:83
    if( Array.isArray(cfg.main) ) {
                         ^

TypeError: Cannot read property 'main' of undefined
    at module.exports (/git/pgatour-cq-v2/front-end/node_modules/steal-tools/lib/graph/make_graph_with_bundles.js:83:23)
Leath Cooper
@IcculusC
not in system
it's a top level package.json field
Thomas Sieverding
@Bajix
@IcculusC It’s in both
Leath Cooper
@IcculusC
oh
Thomas Sieverding
@Bajix
He should be doing this in system.main
the top level main is a fallback
Leath Cooper
@IcculusC
weird, in my experience it only works under the top level package.json object
Christopher Oliphant
@RALifeCoach
I removed it from the system object and I am getting the same result
This message was deleted
Leath Cooper
@IcculusC
well I learned something just now
Thomas Sieverding
@Bajix
@RALifeCoach Your paths are likely the issue
Christopher Oliphant
@RALifeCoach
how so?
Thomas Sieverding
@Bajix
What’s your package.json name & system.directories
Christopher Oliphant
@RALifeCoach
my package is package.json and it’s in the same folder as build.js
not sure what you mean by system.directories
Thomas Sieverding
@Bajix
Do you have a src folder
Or are you using a different naming convention?
Christopher Oliphant
@RALifeCoach
a different naming convention - legacy code
Thomas Sieverding
@Bajix
What’s your main asset directory
Leath Cooper
@IcculusC
@matthewp @justinbmeyer is it okay for me to close my issue referring to the expr.hash bug you fixed with the most recent release of can-stache-bindings
Justin Meyer
@justinbmeyer
yeah
Christopher Oliphant
@RALifeCoach
modules
Justin Meyer
@justinbmeyer
@Bajix that is very rough, but check it out. Maybe lets move this convo to the forums.
Christopher Oliphant
@RALifeCoach
modules has many sub directories - none of which use CanJS
except for the one I reference in main
Thomas Sieverding
@Bajix
@justinbmeyer kk. I’ll do that
So you should have system.directories.lib = modules
Justin Meyer
@justinbmeyer
On a high level, I created a behavior that you should just be able to call Todo.getList() and it should do whatever it can ... regardless if the connection is established or not
it should wait until it is
Thomas Sieverding
@Bajix
And then your main should be “{name}/page.players-redesign/player-bio/components/player-bio.js"
Where {name} is package.json name
Ideally though, your main file would be a stache file using done-autorender
@justinbmeyer So essentially the trick would be to use the behavior to prevent any race conditions on findAll
Christopher Oliphant
@RALifeCoach
I don’t have one of those. My html to show the component looks like this:
<!DOCTYPE html>
<html>
<head>
    <title>PGAT</title>
</head>
<body>
<script type="text/javascript" src="/js/vendor/jquery-1.10.2.min.js"></script>
<script type="text/javascript" src="/js/pgatour.base.js"></script>
<script type="text/javascript" src="/js/pgatour.eventEmitter.js"></script>
<script type="text/javascript" src="/js/pgatour.baseModule.js"></script>
<script type="text/javascript" src="/js/pgatour.asyncScriptLoader.js"></script>
<script type="text/javascript" src="/js/pgatour.adTimer.js"></script>
<script type="text/javascript" src="/js/pgatour.adGroup.js"></script>
<script type="text/javascript" src="/js/pgatour.ad.js"></script>
<script type="text/javascript" src="/js/pgatour.browserActivityWatcher.js"></script>
<script src="../../../node_modules/steal/steal.js"
        main="modules/page.players-redesign/player-bio/components/player-bio"></script>
</body>
</html>
That runs okay
Thomas Sieverding
@Bajix
You should convert that into a stache file, and make it your main instead
Christopher Oliphant
@RALifeCoach
My package.json now includes this:
  "system": {
    "directories": {
      "lib": "modules"
    },
    "main": "pga-tour/page.players-redesign/player-bio/components/player-bio.js"
  },
But you want me to convert to stache.
Thomas Sieverding
@Bajix
<!DOCTYPE html>
<html>
<head>
    <title>PGAT</title>
</head>
<body>
  <can-import from="./vendor/jquery-1.10.2.min"></can-import>
  <can-import from="./pgatour.base"></can-import>
  <can-import from="./pgatour.eventEmitter"></can-import>
  <can-import from="./pgatour.baseModule"></can-import>
  <can-import from="./pgatour.asyncScriptLoader"></can-import>
  <can-import from="./pgatour.adTimer"></can-import>
  <can-import from="./pgatour.adGroup"></can-import>
  <can-import from="./pgatour.ad"></can-import>
  <can-import from="./pgatour.browserActivityWatcher"></can-import>

  {{#switch env.NODE_ENV}}
    {{#case "production"}}
      <script src="{{joinBase 'node_modules/steal/steal.production.js'}}"  main="acme/index.stache!done-autorender"></script>
    {{/case}}
    {{#default}}
      <script src="/node_modules/steal/steal.js"></script>
    {{/default}}
  {{/switch}}
</body>
</html>
Something like that
You can use can-import to load stylesheets too
This part should refer to itself main="acme/index.stache!done-autorender”
Leath Cooper
@IcculusC
is that better than using steal-css
Thomas Sieverding
@Bajix
@IcculusC steal-css is a plugin