Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 17 20:12

    matthewp on master

    Update dist for release (compare)

  • Oct 17 20:12

    matthewp on v6.1.2

    Update dist for release 6.1.2 (compare)

  • Oct 17 20:04

    matthewp on master

    Update dist for release (compare)

  • Oct 17 20:04

    matthewp on v6.1.2-0

    Update dist for release 6.1.2-0 (compare)

  • Oct 17 19:17
    akbaruddin starred canjs/canjs
  • Oct 17 17:25
    matthewp edited #5384
  • Oct 17 17:00

    matthewp on can-dom-mutate-2.0.7

    (compare)

  • Oct 17 17:00

    matthewp on master

    fix(package): update can-dom-mu… Merge pull request #5386 from c… (compare)

  • Oct 17 17:00
    matthewp closed #5386
  • Oct 17 16:27
    greenkeeper[bot] labeled #5386
  • Oct 17 16:27
    greenkeeper[bot] opened #5386
  • Oct 17 16:27

    greenkeeper[bot] on can-dom-mutate-2.0.7

    fix(package): update can-dom-mu… (compare)

  • Oct 17 16:25

    matthewp on can-dom-mutate-2.0.6

    (compare)

  • Oct 17 16:24
    matthewp closed #5379
  • Oct 17 16:24
    matthewp commented #5379
  • Oct 17 15:26

    greenkeeper[bot] on can-type-1.1.2

    (compare)

  • Oct 17 15:26

    matthewp on master

    fix(package): update can-type t… Merge pull request #5385 from c… (compare)

  • Oct 17 15:26
    matthewp closed #5385
  • Oct 17 14:11
    matthewp closed #5377
  • Oct 17 14:11
    matthewp closed #5376
JigneshVasoya3292
@JigneshVasoya3292
The issue is the way obj is getting ipdated with obj.attr({'someattr': attrvalue}) & obj.attr('someattr', attrvalue).
If you clook at Jsbin, you can see the issue.
Btw which JSbin you're referring to?
Julian
@pYr0x
the frist one
sorry cant follow, waht is the problem?
map.attr(key, value)
map.attr(obj[, removeOthers])
Assigns each value in obj to a property on this can.Map named after the corresponding key in obj, effectively merging obj into the Map.
JigneshVasoya3292
@JigneshVasoya3292
Yes, you're right, but while merging, if the updated list has lesser value than exsiting list, then it should be removed. The old value is staying in this case.
Julian
@pYr0x
i dont think merging mean "deep merging"
JigneshVasoya3292
@JigneshVasoya3292
If I pass plain object to .attr(), removed values stays , while if I use .attr(key, value'), the object getts overwritten
is that what u prefer?
JigneshVasoya3292
@JigneshVasoya3292
Yes, But in my case , I blindly pass the plain object, i.e my object ahs multiple attributes, so I don't want to use 'remove' flag as true for all.
Julian
@pYr0x
so what do you want instead?
JigneshVasoya3292
@JigneshVasoya3292
While merging it should give the same result as setting to true, in my case (when udpated list has less values than original ).
Should merging remove the attributes when obj is merged with updated obj?
Julian
@pYr0x
and why do you cant use true
i dont understand
JigneshVasoya3292
@JigneshVasoya3292
That's one solution, I understand taht.
But my doubt is , whether the current implementation has a flaw or Am I misunderstanding it?
'Should merging remove the attributes when obj is merged with updated obj?'
This is my doubt
Christopher Oliphant
@RALifeCoach
@phillipskevin Are you around to assist with a karma question?
Kevin Phillips
@phillipskevin
sure
if I can :smile:
Christopher Oliphant
@RALifeCoach
It is trying to load /base/541225d08418bb4185e186840ac3f6c72470ff3e/541225d08418bb4185e186840ac3f6c72470ff3e.js
I have no idea what that file is. I was hoping you might know
Kevin Phillips
@phillipskevin
hmm, no idea
Christopher Oliphant
@RALifeCoach
and running it against 3.0 and steal 1.0
okay - thanks
Kevin Phillips
@phillipskevin
can you open the debugger and look at the sources?
Christopher Oliphant
@RALifeCoach
yes - which source would you like me to open?
Kevin Phillips
@phillipskevin
I assume that folder doesn’t exist?
Christopher Oliphant
@RALifeCoach
no it does not
Kevin Phillips
@phillipskevin
ok
I can’t really guess what would cause that without seeing the project
can’t think of anything off the top of my head
Christopher Oliphant
@RALifeCoach
I’ll create a stripped down version on my code and see if it continues to happen
Kevin Phillips
@phillipskevin
sounds good
Christopher Oliphant
@RALifeCoach
If it does then I’ll store it on github
then you can have a look at the project
Kevin Phillips
@phillipskevin
:thumbsup:
Christopher Oliphant
@RALifeCoach
@phillipskevin The code is available now.
It is the same code I used when working with Justin on another issue.
To run the tests run: grunt karma-canjs
If I run tests/test.html in the browser, the test runs successfully
Kevin Phillips
@phillipskevin
ok, I will take a look later today
busy with some other stuff so it will be a few hours probably
Christopher Oliphant
@RALifeCoach
Thank-you