Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 12:45
    greenkeeper[bot] labeled #5387
  • 12:45
    greenkeeper[bot] opened #5387
  • 12:45

    greenkeeper[bot] on can-stache-element-1.0.2

    fix(package): update can-stache… (compare)

  • 09:49
    chasenlehara edited #5384
  • 09:47
    chasenlehara edited #3864
  • 09:46
    chasenlehara edited #5383
  • Oct 17 20:12

    matthewp on master

    Update dist for release (compare)

  • Oct 17 20:12

    matthewp on v6.1.2

    Update dist for release 6.1.2 (compare)

  • Oct 17 20:04

    matthewp on master

    Update dist for release (compare)

  • Oct 17 20:04

    matthewp on v6.1.2-0

    Update dist for release 6.1.2-0 (compare)

  • Oct 17 19:17
    akbaruddin starred canjs/canjs
  • Oct 17 17:25
    matthewp edited #5384
  • Oct 17 17:00

    matthewp on can-dom-mutate-2.0.7

    (compare)

  • Oct 17 17:00

    matthewp on master

    fix(package): update can-dom-mu… Merge pull request #5386 from c… (compare)

  • Oct 17 17:00
    matthewp closed #5386
  • Oct 17 16:27
    greenkeeper[bot] labeled #5386
  • Oct 17 16:27
    greenkeeper[bot] opened #5386
  • Oct 17 16:27

    greenkeeper[bot] on can-dom-mutate-2.0.7

    fix(package): update can-dom-mu… (compare)

  • Oct 17 16:25

    matthewp on can-dom-mutate-2.0.6

    (compare)

  • Oct 17 16:24
    matthewp closed #5379
Christopher Oliphant
@RALifeCoach
yes - which source would you like me to open?
Kevin Phillips
@phillipskevin
I assume that folder doesn’t exist?
Christopher Oliphant
@RALifeCoach
no it does not
Kevin Phillips
@phillipskevin
ok
I can’t really guess what would cause that without seeing the project
can’t think of anything off the top of my head
Christopher Oliphant
@RALifeCoach
I’ll create a stripped down version on my code and see if it continues to happen
Kevin Phillips
@phillipskevin
sounds good
Christopher Oliphant
@RALifeCoach
If it does then I’ll store it on github
then you can have a look at the project
Kevin Phillips
@phillipskevin
:thumbsup:
Christopher Oliphant
@RALifeCoach
@phillipskevin The code is available now.
It is the same code I used when working with Justin on another issue.
To run the tests run: grunt karma-canjs
If I run tests/test.html in the browser, the test runs successfully
Kevin Phillips
@phillipskevin
ok, I will take a look later today
busy with some other stuff so it will be a few hours probably
Christopher Oliphant
@RALifeCoach
Thank-you
Kevin Phillips
@phillipskevin
@RALifeCoach I finally got back to trying this and I can’t get the grunt task to run Warning: EMFILE: too many open files, scandir ‘/path/to/project/for-justin/node_modules’
I tried increasing the ulimit but no luck
Christopher Oliphant
@RALifeCoach
I increased to 65535 files before it would work
Kevin Phillips
@phillipskevin
ok
i’ll try that
Christopher Oliphant
@RALifeCoach
Who is reading all those files? Is that glob or steal? Or some other code?
Kevin Phillips
@phillipskevin
I’m not sure… I would guess karma
if I comment out some of the glob patterns in the karma conf the error goes away
it might be steal also… reading all of the package.jsons
Christopher Oliphant
@RALifeCoach
I was thinking steal as well, because it often errors on package.json files
Christopher Oliphant
@RALifeCoach
Any luck with that?
Kevin Phillips
@phillipskevin
yeah, I was able to reproduce it by just creating an html file that loads steal with a cache buster similar to how karma does it: <script src="./node_modules/steal/steal.js?541225d08418bb4185e186840ac3f6c72470ff3e"></script>
Christopher Oliphant
@RALifeCoach
does that mean you were able to get the test to run?
Kevin Phillips
@phillipskevin
no
oh
I got karma to run, yeah
and changed the browser to firefox
Christopher Oliphant
@RALifeCoach
and show the jasmine output?
Kevin Phillips
@phillipskevin
no, it still fails with the same error
Kevin Phillips
@phillipskevin
steal sets whatever is on the query param of the steal script tag as System.main
I’m not sure if it’s alway done that
might be worth opening an issue
Christopher Oliphant
@RALifeCoach
but my file didn’t have a query param
Kevin Phillips
@phillipskevin
yeah, Karma appends one
Christopher Oliphant
@RALifeCoach
right - what if you append the actual main file name?
Kevin Phillips
@phillipskevin
then their glob pattern breaks
karma.png
18 08 2016 20:25:57.565:INFO [Firefox 47.0.0 (Mac OS X 10.11.0)]: Connected on socket /#E_x2IhUavpKxCIAEAAAA with id 93396999
18 08 2016 20:25:58.059:WARN [web-server]: 404: /base/e9864da5cfc8ad5eddeb7342f526c63f6820478e/e9864da5cfc8ad5eddeb7342f526c63f6820478e.js
so that’s what led me to try
yeah, I was able to reproduce it by just creating an html file that loads steal with a cache buster similar to how karma does it: <script src="./node_modules/steal/steal.js?541225d08418bb4185e186840ac3f6c72470ff3e"></script>
Kevin Phillips
@phillipskevin
maybe someone on the steal channel can help think of a way to prevent this until you can set the System.main in the karma bootstrap file