Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 01:04
    greenkeeper[bot] commented #5392
  • 01:04

    greenkeeper[bot] on core-js-3.5.0

    chore(package): update core-js … (compare)

  • Dec 11 18:34
    greenkeeper[bot] labeled #5444
  • Dec 11 18:34
    greenkeeper[bot] opened #5444
  • Dec 11 18:34

    greenkeeper[bot] on can-observable-mixin-1.0.7

    fix(package): update can-observ… (compare)

  • Dec 11 18:30

    cherifGsoul on update-infrastructure-page

    (compare)

  • Dec 11 18:30

    cherifGsoul on master

    Update infrastructure page with… (compare)

  • Dec 11 18:30
    cherifGsoul closed #5441
  • Dec 11 18:30
    cherifGsoul closed #5417
  • Dec 10 17:40
    cherifGsoul review_requested #5443
  • Dec 10 16:47
    cherifGsoul review_requested #5441
  • Dec 10 16:35
    cherifGsoul synchronize #5441
  • Dec 10 16:35

    cherifGsoul on update-infrastructure-page

    Fix typos (compare)

  • Dec 10 10:01
    jkeruzec starred canjs/canjs
  • Dec 09 18:59
    cherifGsoul review_requested #5443
  • Dec 09 18:59
    cherifGsoul opened #5443
  • Dec 09 18:51

    cherifGsoul on document-inserted-removed-can6

    Add inserted/removed events to … (compare)

  • Dec 09 15:38
    greenkeeper[bot] labeled #5442
  • Dec 09 15:38
    greenkeeper[bot] opened #5442
  • Dec 09 15:38

    greenkeeper[bot] on can-view-live-5.0.1

    fix(package): update can-view-l… (compare)

Nico R.
@nriesco
@roemhildtg if you have “access” to the event you might use preventDefault (https://developer.mozilla.org/en/docs/Web/API/Event/preventDefault)
Gregg Roemhildt
@roemhildtg
I think what's going on is an error is thrown somewhere along the line.
Then the return false isn't being executed and the page is redirected
Nico R.
@nriesco
well you can try with a console log before the return line and see if it is executed
Gregg Roemhildt
@roemhildtg
Just stepping through it... it looks like the return is being executed, but somewhere in a parent component its throwing an error. Its looking like something I'm doing wrong.
Gregg Roemhildt
@roemhildtg
@nriesco you're right, preventDefault does fix the issue. :+1:
Nico R.
@nriesco
Great!
Eben
@eben-roux
mope.io
Frank Lemanschik
@frank-dspeed
Eben
is this your project?
Gregg Roemhildt
@roemhildtg
Good day, quick question on canjs 3. (I know I have a lot of questions) In the previous version, can.Map.define objects could have a set function which would be called when the property is initialized (like with a default value) or set. But does this still happen in version 3? http://jsbin.com/kepixenonu/edit?html,js,console,output
Frank Lemanschik
@frank-dspeed
maybe you should watch the fresh new stylish guids and page for it? :D
go on the left side to infrastructure ecosystem and all that
and you will have a much better understanding and overview about the options and whats used
if you have any questions that this don't solves plz tell it here so some one can write something about that
Kevin Phillips
@phillipskevin
@roemhildtg can-map-define is the same as what you’re talking about from 2.3
Frank Lemanschik
@frank-dspeed
@phillipskevin but the name changed a bit var DefineMap = require("can-define/map/map");
Kevin Phillips
@phillipskevin
no
can-map-define is the same
can-define/map/map is a slightly different thing
Frank Lemanschik
@frank-dspeed
ah now we are on the same point :)
Gregg Roemhildt
@roemhildtg
Oh, I see.
Kevin Phillips
@phillipskevin
can-map/can-map-define has attr() and works the same as the Map and define plugin in 2.3
Frank Lemanschik
@frank-dspeed
DifineMap nativ should get depricated or not?
Kevin Phillips
@phillipskevin
DefineMap you don’t need to use attr()
Gregg Roemhildt
@roemhildtg
I like using DefineMap since there's no need for attr
Kevin Phillips
@phillipskevin
DefineMap is the new way
Gregg Roemhildt
@roemhildtg
But can you confirm whether or not the set behavior has changed?
Kevin Phillips
@phillipskevin
set works the same
it’s the value that is not working in your example I think
Frank Lemanschik
@frank-dspeed
the old works but should complain when using attr
Kevin Phillips
@phillipskevin
no can-map-define is a different module
you have to use attr
@roemhildtg
let a = can.DefineMap.extend('a', {
  init(){
    console.log(arguments);
  },
  val: {
    set(val){
      console.log('hey there', val);
      return val;
    }
  }
})
let b = new a();
b.val = 'Hello';
console.log(b.val)
that does what you’re expecting
Frank Lemanschik
@frank-dspeed
ya but you agre with me that we don't use that this way any more as we do var DefineMap = require("can-define/map/map");
Kevin Phillips
@phillipskevin
don’t use what this way?
can-map and can-map-define are legacy modules
for backward compatibility
Frank Lemanschik
@frank-dspeed
we don't use can-map-define in donejs examples
ya
thats what i mean they are still updated but not used any more
Kevin Phillips
@phillipskevin
the donejs examples will be updated to use DefineMap, yeah
Frank Lemanschik
@frank-dspeed
they get replaced by the lazy models
Kevin Phillips
@phillipskevin
and generators, etc
Frank Lemanschik
@frank-dspeed
ya thats what i mean :)
Gregg Roemhildt
@roemhildtg
Okay, but I can provide a default value still, its just this doesn't call the set method anymore?
Frank Lemanschik
@frank-dspeed
i depricated it and throw it out all over