Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 18:59
    cherifGsoul review_requested #5443
  • 18:59
    cherifGsoul opened #5443
  • 18:51

    cherifGsoul on document-inserted-removed-can6

    Add inserted/removed events to … (compare)

  • 15:38
    greenkeeper[bot] labeled #5442
  • 15:38
    greenkeeper[bot] opened #5442
  • 15:38

    greenkeeper[bot] on can-view-live-5.0.1

    fix(package): update can-view-l… (compare)

  • Dec 08 21:21
    greenkeeper[bot] commented #5392
  • Dec 08 21:21

    greenkeeper[bot] on core-js-3.4.8

    chore(package): update core-js … (compare)

  • Dec 06 18:40
    cherifGsoul review_requested #5441
  • Dec 06 18:39
    cherifGsoul opened #5441
  • Dec 06 18:22

    cherifGsoul on update-infrastructure-page

    Update infrastructure page with… (compare)

  • Dec 06 18:14
    greenkeeper[bot] commented #5422
  • Dec 06 18:14

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • Dec 06 18:11
    greenkeeper[bot] commented #5401
  • Dec 06 18:11

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • Dec 04 22:03
    chasenlehara opened #5440
  • Dec 04 22:03
    chasenlehara labeled #5440
  • Dec 04 19:18
    cherifGsoul review_requested #5432
  • Dec 04 14:09
    m-ahmadi starred canjs/canjs
  • Dec 04 10:52
    ansyeow starred canjs/canjs
Kevin Phillips
@phillipskevin
let me see if I can get added to steal-stache
Thomas Sieverding
@Bajix
Cool thanks
Kevin Phillips
@phillipskevin
any reason to use ^3.1.1 || ^2.2.4 instead of 2.x - 3.x
Thomas Sieverding
@Bajix
When I had tested it on steal-stache, 2.x - 3.x was installing 2.2.4, but perhaps that was from the circular reference with can-view-imports
There doesn’t seem to be any good reason to support older 3.x or 2.x
I was hoping that this syntax would be better for Travis CI
Kevin Phillips
@phillipskevin
just that people might already have them as dependencies
Thomas Sieverding
@Bajix
That wouldn’t matter
Kevin Phillips
@phillipskevin
I don’t think I’ll be able to release them today
Thomas Sieverding
@Bajix
Is that just because of the above?
What I mean to say is that it’s a non-issue with people already having them as dependencies as the existing projects would be semantically compatible anyway
Kevin Phillips
@phillipskevin
yeah, I understand what you mean
just not sure if @justinbmeyer cares one way or the other
so I’d rather have him dismiss his review
also, it’s time for dinner
Thomas Sieverding
@Bajix
I can just do 2.x - 3.x if that means we can release ASAP
Kevin Phillips
@phillipskevin
ok, sure
Thomas Sieverding
@Bajix
Done
Kevin Phillips
@phillipskevin
Thomas Sieverding
@Bajix
Sweeetness
Thank you sir! Now I can live in the world of real Promises :D
Kevin Phillips
@phillipskevin
:thumbsup:
Thomas Sieverding
@Bajix
@phillipskevin Could you release https://github.com/donejs/autorender/tree/can3 as 0.9.0-pre.2?
Thomas Sieverding
@Bajix
@phillipskevin another dependency PR canjs/can-map-define#22
Kevin Phillips
@phillipskevin
@Bajix can we just remove jquery from that one?
we did just enable greenkeeper also, so that should take care of the rest of the dependencies
just bumping to the latest versions
I’m slowly going through the 50+ PRs from greenkeeper
for autorender, the "got the appstate” test is failing for me
Gira Minus
@gKreator
blob
Just took off steal-build-tools for testing and I see this... but the app still runs
Cleared cache
Thomas Sieverding
@Bajix
@phillipskevin Greenkeeper doesn’t work for your jQuery use case - I think the wide range though might just mean it never includes jQuery in updates, so that’s moot
Kevin Phillips
@phillipskevin
yeah, I meant for the non-jquery stuff
it won’t put in a PR if the latest is covered by the semver range
Thomas Sieverding
@Bajix
I’ll take another look at done-autorender
Gira Minus
@gKreator
Thanks, I'll check it out
Kevin Phillips
@phillipskevin
@Bajix I can release a pre of autorender tomorrow if it gets fixed up
Thomas Sieverding
@Bajix
What about doing a can-map-define release tonight?
Kevin Phillips
@phillipskevin
does it need jQuery?
Thomas Sieverding
@Bajix
It has jquery in it’s dependencies
Whether it needs it can wait
Gira Minus
@gKreator
@phillipskevin Thnaks, that worked!
Thomas Sieverding
@Bajix
done-autorender is going to load in the wrong jquery version until can-map-define is released
So at least if I put up a patch, it would be 3.x compat
Kevin Phillips
@phillipskevin
why not just remove it?
Kevin Phillips
@phillipskevin
@Bajix
Thomas Sieverding
@Bajix
Yea sorry had stepped away