Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 20:07
    matthewp commented #5384
  • 20:06
    matthewp labeled #5384
  • 20:06
    matthewp opened #5384
  • 19:53
    matthewp opened #5383
  • 16:23
    phillipskevin closed #4841
  • Oct 15 21:43

    phillipskevin on master

    Update dist for release (compare)

  • Oct 15 21:43

    phillipskevin on v6.1.1

    Update dist for release 6.1.1 (compare)

  • Oct 15 21:34

    phillipskevin on can-observable-mixin-1.0.2

    (compare)

  • Oct 15 21:34

    phillipskevin on master

    fix(package): update can-observ… Merge branch 'master' into gree… Merge pull request #5382 from c… (compare)

  • Oct 15 21:34
    phillipskevin closed #5382
  • Oct 15 21:34

    phillipskevin on can-make-map-1.2.2

    (compare)

  • Oct 15 21:34

    phillipskevin on master

    fix(package): update can-make-m… Merge pull request #5380 from c… (compare)

  • Oct 15 21:34
    phillipskevin closed #5380
  • Oct 15 20:30
    phillipskevin synchronize #5382
  • Oct 15 20:30

    phillipskevin on can-observable-mixin-1.0.2

    fix(package): update can-observ… fix(package): update can-simple… Merge pull request #5372 from c… and 2 more (compare)

  • Oct 15 20:30
    phillipskevin opened #5382
  • Oct 15 20:28

    phillipskevin on can-simple-map-4.3.3

    (compare)

  • Oct 15 20:28

    phillipskevin on master

    fix(package): update can-simple… Merge pull request #5378 from c… (compare)

  • Oct 15 20:28
    phillipskevin closed #5378
  • Oct 15 20:26

    phillipskevin on can-observable-mixin-1.0.1

    (compare)

Kevin Phillips
@phillipskevin
I don’t think I’ll be able to release them today
Thomas Sieverding
@Bajix
Is that just because of the above?
What I mean to say is that it’s a non-issue with people already having them as dependencies as the existing projects would be semantically compatible anyway
Kevin Phillips
@phillipskevin
yeah, I understand what you mean
just not sure if @justinbmeyer cares one way or the other
so I’d rather have him dismiss his review
also, it’s time for dinner
Thomas Sieverding
@Bajix
I can just do 2.x - 3.x if that means we can release ASAP
Kevin Phillips
@phillipskevin
ok, sure
Thomas Sieverding
@Bajix
Done
Kevin Phillips
@phillipskevin
Thomas Sieverding
@Bajix
Sweeetness
Thank you sir! Now I can live in the world of real Promises :D
Kevin Phillips
@phillipskevin
:thumbsup:
Thomas Sieverding
@Bajix
@phillipskevin Could you release https://github.com/donejs/autorender/tree/can3 as 0.9.0-pre.2?
Thomas Sieverding
@Bajix
@phillipskevin another dependency PR canjs/can-map-define#22
Kevin Phillips
@phillipskevin
@Bajix can we just remove jquery from that one?
we did just enable greenkeeper also, so that should take care of the rest of the dependencies
just bumping to the latest versions
I’m slowly going through the 50+ PRs from greenkeeper
for autorender, the "got the appstate” test is failing for me
Gira Minus
@gKreator
blob
Just took off steal-build-tools for testing and I see this... but the app still runs
Cleared cache
Thomas Sieverding
@Bajix
@phillipskevin Greenkeeper doesn’t work for your jQuery use case - I think the wide range though might just mean it never includes jQuery in updates, so that’s moot
Kevin Phillips
@phillipskevin
yeah, I meant for the non-jquery stuff
it won’t put in a PR if the latest is covered by the semver range
Thomas Sieverding
@Bajix
I’ll take another look at done-autorender
Gira Minus
@gKreator
Thanks, I'll check it out
Kevin Phillips
@phillipskevin
@Bajix I can release a pre of autorender tomorrow if it gets fixed up
Thomas Sieverding
@Bajix
What about doing a can-map-define release tonight?
Kevin Phillips
@phillipskevin
does it need jQuery?
Thomas Sieverding
@Bajix
It has jquery in it’s dependencies
Whether it needs it can wait
Gira Minus
@gKreator
@phillipskevin Thnaks, that worked!
Thomas Sieverding
@Bajix
done-autorender is going to load in the wrong jquery version until can-map-define is released
So at least if I put up a patch, it would be 3.x compat
Kevin Phillips
@phillipskevin
why not just remove it?
Kevin Phillips
@phillipskevin
@Bajix
Thomas Sieverding
@Bajix
Yea sorry had stepped away
Sweeeeet!
Thank you sir
Gira Minus
@gKreator
blob
blob
This worked with steal-tools, I am assuming this is bad lol
I am trying to pass a template to another component. I know I can pass it as a string, but I want for steal-tools to bundle it with the parent.
Gira Minus
@gKreator
Found out it was my child component... I wansn't using the define { value: }
Thomas Sieverding
@Bajix
@gKreator I think I found that error earlier. The tests pass in the browser, but the one fails when done from the cli - upon further inspection, I think this line is breaking StealJS