Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 04:24

    greenkeeper[bot] on @octokit

    (compare)

  • 04:23

    greenkeeper[bot] on @octokit

    chore(package): update @octokit… (compare)

  • Jan 28 17:46

    greenkeeper[bot] on @octokit

    (compare)

  • Jan 28 17:44

    greenkeeper[bot] on @octokit

    chore(package): update @octokit… (compare)

  • Jan 28 16:41
    cherifGsoul edited #5465
  • Jan 28 16:40
    cherifGsoul labeled #5465
  • Jan 28 16:40
    cherifGsoul opened #5465
  • Jan 27 21:03
    justinbmeyer commented #5464
  • Jan 27 20:33
    bmomberger-bitovi opened #5464
  • Jan 27 19:13

    greenkeeper[bot] on @octokit

    (compare)

  • Jan 27 19:12

    greenkeeper[bot] on @octokit

    chore(package): update @octokit… (compare)

  • Jan 27 14:09
    rjgotten edited #5463
  • Jan 27 13:57
    rjgotten edited #5463
  • Jan 27 13:48
    rjgotten edited #5463
  • Jan 27 13:45
    rjgotten edited #5463
  • Jan 27 12:20
    rjgotten edited #5463
  • Jan 27 09:42
    rjgotten edited #5463
  • Jan 27 09:04
    rjgotten opened #5463
  • Jan 26 16:06
    chamsou123 starred canjs/canjs
  • Jan 25 20:18

    greenkeeper[bot] on @octokit

    (compare)

Kevin Phillips
@phillipskevin
for autorender, the "got the appstate” test is failing for me
Gira Minus
@gKreator
blob
Just took off steal-build-tools for testing and I see this... but the app still runs
Cleared cache
Thomas Sieverding
@Bajix
@phillipskevin Greenkeeper doesn’t work for your jQuery use case - I think the wide range though might just mean it never includes jQuery in updates, so that’s moot
Kevin Phillips
@phillipskevin
yeah, I meant for the non-jquery stuff
it won’t put in a PR if the latest is covered by the semver range
Thomas Sieverding
@Bajix
I’ll take another look at done-autorender
Gira Minus
@gKreator
Thanks, I'll check it out
Kevin Phillips
@phillipskevin
@Bajix I can release a pre of autorender tomorrow if it gets fixed up
Thomas Sieverding
@Bajix
What about doing a can-map-define release tonight?
Kevin Phillips
@phillipskevin
does it need jQuery?
Thomas Sieverding
@Bajix
It has jquery in it’s dependencies
Whether it needs it can wait
Gira Minus
@gKreator
@phillipskevin Thnaks, that worked!
Thomas Sieverding
@Bajix
done-autorender is going to load in the wrong jquery version until can-map-define is released
So at least if I put up a patch, it would be 3.x compat
Kevin Phillips
@phillipskevin
why not just remove it?
Kevin Phillips
@phillipskevin
@Bajix
Thomas Sieverding
@Bajix
Yea sorry had stepped away
Sweeeeet!
Thank you sir
Gira Minus
@gKreator
blob
blob
This worked with steal-tools, I am assuming this is bad lol
I am trying to pass a template to another component. I know I can pass it as a string, but I want for steal-tools to bundle it with the parent.
Gira Minus
@gKreator
Found out it was my child component... I wansn't using the define { value: }
Thomas Sieverding
@Bajix
@gKreator I think I found that error earlier. The tests pass in the browser, but the one fails when done from the cli - upon further inspection, I think this line is breaking StealJS
Gira Minus
@gKreator
Nice, for me it was just my miss use of DefineMap
I just ran into a bug with <can-import>
<can-import from="scripts/components/datatable/">
<component-datatable {(options)}="datatable"></component-datatable>
</can-import>
I have to manually import the component somewhere... otherwise I get an error
Gira Minus
@gKreator
import "scripts/components/datatable/";
GET /traceur.js 404 (Not Found)
It seems to only do this if can-import is nested
this error only shows up in steal-tools
Thomas Sieverding
@Bajix
@phillipskevin I’ve got a fix for the done-autorender test
canjs/can-stache#127
It was breaking because of a bundle override on can-stache
Gira Minus
@gKreator
What was breaking?
Thomas Sieverding
@Bajix
can-stache had a path override that was breaking steal’s ability to load can-stache, but only during npm test
Gira Minus
@gKreator
Ohh
Nice find!
Thomas Sieverding
@Bajix
this was because done-autorender no longer has can as a dependency, and the path override in can-stache tries to map to can
Gira Minus
@gKreator
Got any clue on my can-import issue?
:D
Thomas Sieverding
@Bajix
Hmmm
Gira Minus
@gKreator
Seems to be an issue with nested <can-import>