Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 14:43
    greenkeeper[bot] closed #5373
  • 14:43

    greenkeeper[bot] on can-deep-observable-1.0.1

    (compare)

  • 14:42

    m-mujica on update-deep-observable

    (compare)

  • 14:42

    m-mujica on master

    Update can-deep-observable to l… Merge pull request #5374 from c… (compare)

  • 14:42
    m-mujica closed #5374
  • 14:42
    m-mujica closed #5365
  • 14:09
    f-ricci starred canjs/canjs
  • 13:55
    greenkeeper[bot] commented #5375
  • 13:55

    greenkeeper[bot] on core-js-3.3.2

    chore(package): update core-js … (compare)

  • 10:51
    m-mujica review_requested #5374
  • 07:43
    rjgotten commented #5358
  • Oct 13 15:14
    greenkeeper[bot] commented #5375
  • Oct 13 15:14

    greenkeeper[bot] on core-js-3.3.1

    chore(package): update core-js … (compare)

  • Oct 13 14:49
    greenkeeper[bot] labeled #5375
  • Oct 13 14:49
    greenkeeper[bot] opened #5375
  • Oct 13 14:49

    greenkeeper[bot] on core-js-3.3.0

    chore(package): update core-js … (compare)

  • Oct 12 18:35
    matthewp commented #5358
  • Oct 12 18:15
    chasenlehara commented #5358
  • Oct 12 06:41

    greenkeeper[bot] on @octokit

    (compare)

  • Oct 12 06:39

    greenkeeper[bot] on @octokit

    chore(package): update @octokit… (compare)

Kevin Phillips
@phillipskevin
@Bajix I can release a pre of autorender tomorrow if it gets fixed up
Thomas Sieverding
@Bajix
What about doing a can-map-define release tonight?
Kevin Phillips
@phillipskevin
does it need jQuery?
Thomas Sieverding
@Bajix
It has jquery in it’s dependencies
Whether it needs it can wait
Gira Minus
@gKreator
@phillipskevin Thnaks, that worked!
Thomas Sieverding
@Bajix
done-autorender is going to load in the wrong jquery version until can-map-define is released
So at least if I put up a patch, it would be 3.x compat
Kevin Phillips
@phillipskevin
why not just remove it?
Kevin Phillips
@phillipskevin
@Bajix
Thomas Sieverding
@Bajix
Yea sorry had stepped away
Sweeeeet!
Thank you sir
Gira Minus
@gKreator
blob
blob
This worked with steal-tools, I am assuming this is bad lol
I am trying to pass a template to another component. I know I can pass it as a string, but I want for steal-tools to bundle it with the parent.
Gira Minus
@gKreator
Found out it was my child component... I wansn't using the define { value: }
Thomas Sieverding
@Bajix
@gKreator I think I found that error earlier. The tests pass in the browser, but the one fails when done from the cli - upon further inspection, I think this line is breaking StealJS
Gira Minus
@gKreator
Nice, for me it was just my miss use of DefineMap
I just ran into a bug with <can-import>
<can-import from="scripts/components/datatable/">
<component-datatable {(options)}="datatable"></component-datatable>
</can-import>
I have to manually import the component somewhere... otherwise I get an error
Gira Minus
@gKreator
import "scripts/components/datatable/";
GET /traceur.js 404 (Not Found)
It seems to only do this if can-import is nested
this error only shows up in steal-tools
Thomas Sieverding
@Bajix
@phillipskevin I’ve got a fix for the done-autorender test
canjs/can-stache#127
It was breaking because of a bundle override on can-stache
Gira Minus
@gKreator
What was breaking?
Thomas Sieverding
@Bajix
can-stache had a path override that was breaking steal’s ability to load can-stache, but only during npm test
Gira Minus
@gKreator
Ohh
Nice find!
Thomas Sieverding
@Bajix
this was because done-autorender no longer has can as a dependency, and the path override in can-stache tries to map to can
Gira Minus
@gKreator
Got any clue on my can-import issue?
:D
Thomas Sieverding
@Bajix
Hmmm
Gira Minus
@gKreator
Seems to be an issue with nested <can-import>
Thomas Sieverding
@Bajix
Why’re you loading it from scripts?
I think your path setup isn’t right
Gira Minus
@gKreator
the folder? Is all my js files and stache files in there
Thomas Sieverding
@Bajix
I mean to say that you’re importing it from scripts, whereas the import statement shouldn’t need ‘scripts'
Gira Minus
@gKreator
It only breaks when you use steal-tools to build
hmm
ohh this screenshot might explain it
Thomas Sieverding
@Bajix
The paths configuration of your project wouldn’t make sense, not necessarily a comment on your file structure
Gira Minus
@gKreator
blob
Thomas Sieverding
@Bajix
Yea so then your package.json isn’t setup right