Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 14 21:13
    greenkeeper[bot] labeled #5378
  • Oct 14 21:12
    greenkeeper[bot] opened #5378
  • Oct 14 21:12

    greenkeeper[bot] on can-simple-map-4.3.3

    fix(package): update can-simple… (compare)

  • Oct 14 20:19
    greenkeeper[bot] labeled #5377
  • Oct 14 20:19
    greenkeeper[bot] opened #5377
  • Oct 14 20:19

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • Oct 14 20:18
    greenkeeper[bot] labeled #5376
  • Oct 14 20:18
    greenkeeper[bot] opened #5376
  • Oct 14 20:18

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • Oct 14 14:43
    greenkeeper[bot] closed #5373
  • Oct 14 14:43

    greenkeeper[bot] on can-deep-observable-1.0.1

    (compare)

  • Oct 14 14:42

    m-mujica on update-deep-observable

    (compare)

  • Oct 14 14:42

    m-mujica on master

    Update can-deep-observable to l… Merge pull request #5374 from c… (compare)

  • Oct 14 14:42
    m-mujica closed #5374
  • Oct 14 14:42
    m-mujica closed #5365
  • Oct 14 14:09
    f-ricci starred canjs/canjs
  • Oct 14 13:55
    greenkeeper[bot] commented #5375
  • Oct 14 13:55

    greenkeeper[bot] on core-js-3.3.2

    chore(package): update core-js … (compare)

  • Oct 14 10:51
    m-mujica review_requested #5374
  • Oct 14 07:43
    rjgotten commented #5358
Gira Minus
@gKreator
blob
blob
This worked with steal-tools, I am assuming this is bad lol
I am trying to pass a template to another component. I know I can pass it as a string, but I want for steal-tools to bundle it with the parent.
Gira Minus
@gKreator
Found out it was my child component... I wansn't using the define { value: }
Thomas Sieverding
@Bajix
@gKreator I think I found that error earlier. The tests pass in the browser, but the one fails when done from the cli - upon further inspection, I think this line is breaking StealJS
Gira Minus
@gKreator
Nice, for me it was just my miss use of DefineMap
I just ran into a bug with <can-import>
<can-import from="scripts/components/datatable/">
<component-datatable {(options)}="datatable"></component-datatable>
</can-import>
I have to manually import the component somewhere... otherwise I get an error
Gira Minus
@gKreator
import "scripts/components/datatable/";
GET /traceur.js 404 (Not Found)
It seems to only do this if can-import is nested
this error only shows up in steal-tools
Thomas Sieverding
@Bajix
@phillipskevin I’ve got a fix for the done-autorender test
canjs/can-stache#127
It was breaking because of a bundle override on can-stache
Gira Minus
@gKreator
What was breaking?
Thomas Sieverding
@Bajix
can-stache had a path override that was breaking steal’s ability to load can-stache, but only during npm test
Gira Minus
@gKreator
Ohh
Nice find!
Thomas Sieverding
@Bajix
this was because done-autorender no longer has can as a dependency, and the path override in can-stache tries to map to can
Gira Minus
@gKreator
Got any clue on my can-import issue?
:D
Thomas Sieverding
@Bajix
Hmmm
Gira Minus
@gKreator
Seems to be an issue with nested <can-import>
Thomas Sieverding
@Bajix
Why’re you loading it from scripts?
I think your path setup isn’t right
Gira Minus
@gKreator
the folder? Is all my js files and stache files in there
Thomas Sieverding
@Bajix
I mean to say that you’re importing it from scripts, whereas the import statement shouldn’t need ‘scripts'
Gira Minus
@gKreator
It only breaks when you use steal-tools to build
hmm
ohh this screenshot might explain it
Thomas Sieverding
@Bajix
The paths configuration of your project wouldn’t make sense, not necessarily a comment on your file structure
Gira Minus
@gKreator
blob
Thomas Sieverding
@Bajix
Yea so then your package.json isn’t setup right
Gira Minus
@gKreator
blob
Anything stick out?
Thomas Sieverding
@Bajix
Yea, under system you should have "directories": { "lib": “public/scripts" },
Gira Minus
@gKreator
package.json is in public/
so "scripts"
Thomas Sieverding
@Bajix
Yea sure
Gira Minus
@gKreator
Ok thx
Thomas Sieverding
@Bajix
I have mine setup differently such that my package.json isn’t in my assets folder
I then do some more custom static serving
Such that my assets folder goes to /assets, node_modules to /node_modules, and package.json
W/ a redacted node_modules to protect private modules
Gira Minus
@gKreator
Very interesting
I'd like to see this somehow
Thomas Sieverding
@Bajix
app.use('/node_modules', function( req, res, next ) {
  var pathname = req.originalUrl;

  for (var i = 0; i < protectedDirs.length; i++) {
    if (~pathname.indexOf(protectedDirs[i])) {
      return next(new handler.NotAuthorizedError());
    }
  }

  next();
});

app.use('/css', express.static(path.join(__dirname, '../css')));
app.use('/dist', express.static(path.join(__dirname, '../dist')));
app.use('/assets', express.static(path.join(__dirname, '../assets')));
app.use('/package.json', express.static(path.join(__dirname, '../package.json')));
app.use('/node_modules', express.static(path.join(__dirname, '../node_modules')));