Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 19:22

    matthewp on can-observable-bindings-1.3.0

    (compare)

  • 19:22

    matthewp on master

    fix(package): update can-observ… Set new bundle sizes Merge pull request #5389 from c… (compare)

  • 19:22
    matthewp closed #5389
  • 19:09
    matthewp commented #5389
  • 18:33

    matthewp on can-attribute-observable-2.0.1

    (compare)

  • 18:33

    matthewp on master

    fix(package): update can-attrib… Increase the bundlesize Merge pull request #5394 from c… (compare)

  • 18:33
    matthewp closed #5394
  • 17:59
    matthewp synchronize #5394
  • 17:59

    matthewp on can-attribute-observable-2.0.1

    Increase the bundlesize (compare)

  • 17:42
    matthewp synchronize #5389
  • 17:42

    matthewp on can-observable-bindings-1.3.0

    fix(package): update can-observ… Set new bundle sizes (compare)

  • 17:26
    greenkeeper[bot] labeled #5394
  • 17:26
    greenkeeper[bot] opened #5394
  • 17:26

    greenkeeper[bot] on can-attribute-observable-2.0.1

    fix(package): update can-attrib… (compare)

  • 17:15

    matthewp on can-stache-element-1.0.2

    (compare)

  • 17:15

    matthewp on master

    fix(package): update can-stache… Merge pull request #5387 from c… (compare)

  • 17:15
    matthewp closed #5387
  • 17:15

    matthewp on can-observable-mixin-1.0.3

    (compare)

  • 17:15

    matthewp on master

    fix(package): update can-observ… Merge pull request #5391 from c… (compare)

  • 17:15
    matthewp closed #5391
Thomas Sieverding
@Bajix
@phillipskevin I’ve got a fix for the done-autorender test
canjs/can-stache#127
It was breaking because of a bundle override on can-stache
Gira Minus
@gKreator
What was breaking?
Thomas Sieverding
@Bajix
can-stache had a path override that was breaking steal’s ability to load can-stache, but only during npm test
Gira Minus
@gKreator
Ohh
Nice find!
Thomas Sieverding
@Bajix
this was because done-autorender no longer has can as a dependency, and the path override in can-stache tries to map to can
Gira Minus
@gKreator
Got any clue on my can-import issue?
:D
Thomas Sieverding
@Bajix
Hmmm
Gira Minus
@gKreator
Seems to be an issue with nested <can-import>
Thomas Sieverding
@Bajix
Why’re you loading it from scripts?
I think your path setup isn’t right
Gira Minus
@gKreator
the folder? Is all my js files and stache files in there
Thomas Sieverding
@Bajix
I mean to say that you’re importing it from scripts, whereas the import statement shouldn’t need ‘scripts'
Gira Minus
@gKreator
It only breaks when you use steal-tools to build
hmm
ohh this screenshot might explain it
Thomas Sieverding
@Bajix
The paths configuration of your project wouldn’t make sense, not necessarily a comment on your file structure
Gira Minus
@gKreator
blob
Thomas Sieverding
@Bajix
Yea so then your package.json isn’t setup right
Gira Minus
@gKreator
blob
Anything stick out?
Thomas Sieverding
@Bajix
Yea, under system you should have "directories": { "lib": “public/scripts" },
Gira Minus
@gKreator
package.json is in public/
so "scripts"
Thomas Sieverding
@Bajix
Yea sure
Gira Minus
@gKreator
Ok thx
Thomas Sieverding
@Bajix
I have mine setup differently such that my package.json isn’t in my assets folder
I then do some more custom static serving
Such that my assets folder goes to /assets, node_modules to /node_modules, and package.json
W/ a redacted node_modules to protect private modules
Gira Minus
@gKreator
Very interesting
I'd like to see this somehow
Thomas Sieverding
@Bajix
app.use('/node_modules', function( req, res, next ) {
  var pathname = req.originalUrl;

  for (var i = 0; i < protectedDirs.length; i++) {
    if (~pathname.indexOf(protectedDirs[i])) {
      return next(new handler.NotAuthorizedError());
    }
  }

  next();
});

app.use('/css', express.static(path.join(__dirname, '../css')));
app.use('/dist', express.static(path.join(__dirname, '../dist')));
app.use('/assets', express.static(path.join(__dirname, '../assets')));
app.use('/package.json', express.static(path.join(__dirname, '../package.json')));
app.use('/node_modules', express.static(path.join(__dirname, '../node_modules')));
Gira Minus
@gKreator
ohh I see
Thomas Sieverding
@Bajix
I like to have the url /assets where I put everything using a modlet scheme; mixed assets within each modlet
Keeping those separate makes it easier to resolve the url patterns
The default setup has the unintended consequence of serving the app in liee of static assets whenever there’s a 404
I’ll probably follow up w/ this feedback w/ the DoneJS contrib or on github
Gira Minus
@gKreator
Is the meeting online?
Thomas Sieverding
@Bajix
They do a weekly hangouts
Gira Minus
@gKreator
ENOENT: no such file or directory, open '/usr/share/nginx/drivetrain/public/undefined#main.js'
whenver I set the lib:
it just passes it as undefined
Thomas Sieverding
@Bajix
You may have other issues
Considering all of your paths were already broken
Gira Minus
@gKreator
lol :D
Thomas Sieverding
@Bajix
You’d need to go through and update anything using improper path conventions