Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 21:21
    greenkeeper[bot] commented #5392
  • 21:21

    greenkeeper[bot] on core-js-3.4.8

    chore(package): update core-js … (compare)

  • Dec 06 18:40
    cherifGsoul review_requested #5441
  • Dec 06 18:39
    cherifGsoul opened #5441
  • Dec 06 18:22

    cherifGsoul on update-infrastructure-page

    Update infrastructure page with… (compare)

  • Dec 06 18:14
    greenkeeper[bot] commented #5422
  • Dec 06 18:14

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • Dec 06 18:11
    greenkeeper[bot] commented #5401
  • Dec 06 18:11

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • Dec 04 22:03
    chasenlehara opened #5440
  • Dec 04 22:03
    chasenlehara labeled #5440
  • Dec 04 19:18
    cherifGsoul review_requested #5432
  • Dec 04 14:09
    m-ahmadi starred canjs/canjs
  • Dec 04 10:52
    ansyeow starred canjs/canjs
  • Dec 03 14:53
    matthewp commented #5439
  • Dec 03 14:30
    frank-dspeed opened #5439
  • Dec 02 18:13
    greenkeeper[bot] commented #5392
  • Dec 02 18:13

    greenkeeper[bot] on core-js-3.4.7

    chore(package): update core-js … (compare)

  • Dec 02 17:48
    greenkeeper[bot] commented #5392
  • Dec 02 17:48

    greenkeeper[bot] on core-js-3.4.6

    chore(package): update core-js … (compare)

Frank Lemanschik
@frank-dspeed
and maybe writen down your opinion about that?
write lol not writen
i need a way to write proper english my autocorrection don't works well on gitter
Chasen Le Hara
@chasenlehara
I don’t have any additional comments on it that the core team hasn’t already discussed in the last contributors meeting or in this issue: donejs/donejs#792
Frank Lemanschik
@frank-dspeed
?
Chasen Le Hara
@chasenlehara
Frank Lemanschik
@frank-dspeed
yes i know what got discussed i was there :)
there was spoken about generator-donejs
but now i have thrown in that there is a long years existing project that would better fit
and no one commented on that something other then generate a new issue for that and i did that now in CanJS
so out of my view nothing got discussed
For me the result of the last meeting was generator-donejs can be splitted but no one was sure how far and what is donejs what is canjs
and i think this solves all that generator-donejs gets splitted does all donejs related and generator-canjs gets splitted and does all canjs related
Chasen Le Hara
@chasenlehara
Thanks for creating that issue. I think it falls under the discussion we had about the DoneJS generator, which we essentially tabled to discuss for a future version of DoneJS.
I don’t think it’s a priority for the core team until we have more time to think through and discuss what we want to do.
Frank Lemanschik
@frank-dspeed
I don't wanted to finish it i only needed to bring that up so i know what to do with that
as it also is in use
51 downloads last month :)
Chasen Le Hara
@chasenlehara
I’m not sure what to tell you about “what to do with that.”
If you find value in that project and want to contribute to it, go for it!
I don’t think it’s something the core team has time to put effort into right now.
Frank Lemanschik
@frank-dspeed
ok thats a point :)
Gregg Roemhildt
@roemhildtg
@frank-dspeed I'll play around with it a bit and post an update :smile:
Marc Godard
@MarcGodard

I am trying to track routes, I want to call google analytics when a route is changed.

I created the following js file..

import can from 'can';
import 'can/map/define/';
import 'can/route/pushstate/';

export default can.Control({
    'route': function() {
        // Matches every routing change, but gets passed no data.
        console.log("Something changed!")
    },
    ':page route': function(data) {
        console.log("page change", data);
        // Matches routes like #!todos/5,
        // and will get passed {id: 5} as data.
    },
    ':page/:item': function(data) {
        console.log("page change", data);
        // Matches routes like #!recipes/5,
        // and will get passed {id: 5, type: 'recipes'} as data.
    }
});

Then I import it into my app viewModal like this:

import 'app/utils/routing';

This doesn't work. I tried putting it on the bottom of the app view model with new Router(window); like this page has https://v2.canjs.com/docs/can.Control.route.html However that also didn't work.

Could someone help me with what I am missing?

Gira Minus
@gKreator
How to shim an AMD module using stealjs 1?
Kevin Phillips
@phillipskevin
@MarcGodard if you’re using done-autorender, I don’t think you can use Control based routing
all of your route properties will be on your appViewModel already
so you can just use setters there
page: {
    set function(val) {
        console.log(‘page changed’, val);
        return val;
    }
}
should be the same as steal 0.16
Marc Godard
@MarcGodard
@phillipskevin thanks, will play with that.
Marc Godard
@MarcGodard
@phillipskevin It doesn't seem to work for subpages...
        page: {
            set(newVal) {
                if (newVal == 'listing') {
                    ga('set', { page: newVal + '/' + this.attr("item") , title: this.attr('title') });
                    ga('send', 'pageview');
                } else {
                    ga('set', { page: newVal, title: this.attr('title') });
                    ga('send', 'pageview');
                }
                return newVal;
            }
        },
Kevin Phillips
@phillipskevin
there will be different events for the other properties
Marc Godard
@MarcGodard
I got it to work by using can.route.attr('item')
However, now this set property make my url domain.com/home/ instead of just domain.com/
Marc Godard
@MarcGodard
@phillipskevin I really only need to track subpages... so it seems to work fine when I do the
item: { set(val) {} }
Kevin Phillips
@phillipskevin
yeah, that should work
if that’s all you need
I don’t think that setter should cause your route to change
Marc Godard
@MarcGodard
Yeah. Kinda disappointed in the route stuff. I hope when I move to donejs 1 it is better
It was because I set a default as 'home' so because of the set value for some reason, it would add it to the URL
Kevin Phillips
@phillipskevin
if you have suggestions on how we could improve it, please feel free to open issues
yeah, that sounds like a bug, but I’m not sure
Marc Godard
@MarcGodard
I will once I get into donejs v1.
It wouldn't be fair to report issues on old versions.
My new site is looking real good though. I can't wait to figure out the SSR and all that so I don't run from a build.
Frank Lemanschik
@frank-dspeed
Ehm you should in Production always run from a build
even if your using ssr