Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 03:58

    greenkeeper[bot] on @octokit

    (compare)

  • 03:57

    greenkeeper[bot] on @octokit

    chore(package): update @octokit… (compare)

  • Sep 20 21:04
    m-mujica commented #5303
  • Sep 20 20:23
    m-mujica opened #5303
  • Sep 20 20:23

    m-mujica on upgrade-deps

    Update can-type and can-stache-… (compare)

  • Sep 20 20:05
    m-mujica edited #5302
  • Sep 20 20:03
    m-mujica synchronize #5302
  • Sep 20 20:03

    m-mujica on upgrade

    Upgrade routing guide to Can 6 Fix incorrect highlight Use svg images (instead of .png) (compare)

  • Sep 20 19:32
    m-mujica opened #5302
  • Sep 20 19:29

    m-mujica on upgrade

    Upgrade routing guide to Can 6 Fix incorrect highlight (compare)

  • Sep 20 17:42

    m-mujica on upgrade

    WIP: Upgrade (compare)

  • Sep 20 17:06
    do-adams starred canjs/canjs
  • Sep 20 13:34

    chasenlehara on 5119-testing-guide

    Update the Testing guide for Ca… (compare)

  • Sep 20 13:21
    cherifGsoul commented #5295
  • Sep 20 13:18
    cherifGsoul synchronize #5295
  • Sep 20 13:18

    cherifGsoul on update-theme-new-buttons

    Theme pre-release 2 (compare)

  • Sep 20 10:29

    greenkeeper[bot] on socket.io-client-2.3.0

    (compare)

  • Sep 20 10:26

    greenkeeper[bot] on socket.io-client-2.3.0

    chore(package): update socket.i… (compare)

  • Sep 20 06:40
    HellMagic starred canjs/canjs
  • Sep 19 20:42
    m-mujica commented #5119
Frank Lemanschik
@frank-dspeed
if you want to know more about the logging in canJS
that is a t present part of can-util/dev/dev
that is depricated and now
can-log/dev/dev :)
but to make it more short done-autorender which uses zones has a option called no-zone
which bypasses zones complet :)
Gregg Roemhildt
@roemhildtg
@bmomberger-bitovi So I'm working on this can symbol observability stuff again today, and I'm back at a point where I'm not sure what's wrong. I've found out that the watch function doesn't always work, when working with nested objects, so to workaround that, I've modified my function to use .watch('center.longitude'...) which does work. The template renders the initial value, but the template still isn't getting updated when the values change. My onKeyValue handler is getting called. But my getKeyValue is not getting called after that which is where I believe the problem lies.
Kevin Phillips
@phillipskevin
I haven't really been following what you're trying to do, but from looking at that code it looks like your onKeyValue doesn't actually call your handlers
Gregg Roemhildt
@roemhildtg
Line 42, I think it does, unless I'm missing something.
Kevin Phillips
@phillipskevin
but that's just when the watch is triggered, right?
sorry, maybe that makes sense
so you're saying onKeyValue is called, then whatever triggers watch happens, and your handlers don't update the template?
Gregg Roemhildt
@roemhildtg
Right
Kevin Phillips
@phillipskevin
ok
getKeyValue shouldn't have to be called after that in order for it to work
Gregg Roemhildt
@roemhildtg
I think I have it working pretty much like I have in my dev setup
Brad Momberger
@bmomberger-bitovi
I think you might be doing too many handler dispatches. You make a watch for every onKeyValue, but each watch handler goes over the entire handlers list.
I don't know that this is the root of the live problem, but it couldn't hurt to clean that up.
Oh! I do see one thing that might be a problem with your @@can.getKeyValue. It's using can-util/js/get/get, which doesn't use canReflect.getKeyValue to access properties.
Brad Momberger
@bmomberger-bitovi
If you want to read deep paths on an object, I would recommend trying can-stache-key.get instead.
Gregg Roemhildt
@roemhildtg

You make a watch for every onKeyValue, but each watch handler goes over the entire handlers list.

I'm not following, shouldn't each watch handler call each handler that is listening for that key's changes?

Brad Momberger
@bmomberger-bitovi
If you have two watches on one key, and that key changes, then two watches each call two handlers.
Gregg Roemhildt
@roemhildtg
Ohh, I see
Yes that would happen
Gregg Roemhildt
@roemhildtg
I'm not sure how to use can-stache-key, but what if I just add observation.add(obj, key) to the get function from can-util?
wouldn't that trigger the getKeyValue
Brad Momberger
@bmomberger-bitovi
Yeah, if you want to just copy and modify the get function, that should work too
Frank Lemanschik
@frank-dspeed
does somebody in here maybe know the behavier of steal optimized bundels from done-autorender (done-apps)?
the bundels are including the needed code but i think some init stuff is needed that not done automaticly
i think as steal optimize gets the index.stache!done-autorender
it should autorender as expected behavier right?
Chasen Le Hara
@chasenlehara
^ I don’t think we’ve finished making the optimized builds work in a regular DoneJS app, maybe @matthewp can comment though
Matthew Phillips
@matthewp
Optimized builds do not work with done-autorender apps, that is correct.
Going to start working on it soon hopefully.
Nico R.
@nriesco
Hi, I found this in the docs: https://canjs.com/doc/can-validate.html but couldn’t understand how to use it in a form, any ideas?
I was looking for an easy way to support HTML “required” fields
Nico R.
@nriesco
or providing a custom method
swipie
@swipie
We get a lot of warnings about a property that is not in the current scope and that the property is read from the parent scope. It is resolved when we do {{ ../myprop}} instead of {{myprop}} but is this the right way to solve these warnings?
Kevin Phillips
@phillipskevin
Sorry the docs that warning links to haven't been published yet. There are a few ways to resolve this
image.png
Hopefully you can read that. Yes, if you want to read the prop from the parent scope, ../myProp is the correct way to do it.
Kevin Phillips
@phillipskevin
if there are places where you think ../myprop isn't the right way to do it, let us know @swipie
Brad Momberger
@bmomberger-bitovi
Got ninja'd by @phillipskevin, but I was going to add that reading explicitly from the scope level where your prop exists will help ease the upgrade process to future major revisions of can-stache
Frank Lemanschik
@frank-dspeed
lol ninjaed
new term :)
i use normaly outsmartned
Brad Momberger
@bmomberger-bitovi
It's not quite outsmarted, just that someone else got in a correct or agreeing response while you were composing your own.
Frank Lemanschik
@frank-dspeed
ok if you say so