Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 14 20:01
    greenkeeper[bot] labeled #5450
  • Dec 14 20:01
    greenkeeper[bot] opened #5450
  • Dec 14 20:00

    greenkeeper[bot] on semver-7.0.0

    chore(package): update semver t… (compare)

  • Dec 14 16:58
    millette starred canjs/canjs
  • Dec 14 00:14
    greenkeeper[bot] labeled #5449
  • Dec 14 00:14
    greenkeeper[bot] opened #5449
  • Dec 14 00:14

    greenkeeper[bot] on can-super-model-2.0.0

    fix(package): update can-super-… (compare)

  • Dec 14 00:13
    greenkeeper[bot] labeled #5448
  • Dec 14 00:13
    greenkeeper[bot] opened #5448
  • Dec 14 00:13

    greenkeeper[bot] on can-define-rest-model-2.0.0

    fix(package): update can-define… (compare)

  • Dec 14 00:12
    greenkeeper[bot] labeled #5447
  • Dec 14 00:12
    greenkeeper[bot] opened #5447
  • Dec 14 00:12

    greenkeeper[bot] on can-define-realtime-rest-model-2.0.0

    fix(package): update can-define… (compare)

  • Dec 14 00:07
    greenkeeper[bot] labeled #5446
  • Dec 14 00:07
    greenkeeper[bot] opened #5446
  • Dec 14 00:07

    greenkeeper[bot] on can-connect-ndjson-2.0.0

    fix(package): update can-connec… (compare)

  • Dec 13 21:27

    greenkeeper[bot] on @octokit

    (compare)

  • Dec 13 21:25

    greenkeeper[bot] on @octokit

    chore(package): update @octokit… (compare)

  • Dec 13 21:21

    greenkeeper[bot] on @octokit

    (compare)

  • Dec 13 21:20

    greenkeeper[bot] on @octokit

    chore(package): update @octokit… (compare)

Frank Lemanschik
@frank-dspeed
as long as it works simply consider it is intended to do so :)
would be my way of thinking else this is fast search replaced
Viktor Busko
@Lighttree

@DaveO-Home about the strip in other bundlers you need to code addons for them that simply strip the steal remove comments

@frank-dspeed maybe you know the place in stealjs srcs where I can find how steal detects this comment blocks (I guess there is some regex)? I was going to add webpack loader to my prod build for this, but postponed this.

Oh I found it. It's in steal-tools
Nico R.
@nriesco
I have a button like this: <button type="button" on:click="saveAndClose(this)">Save changes</button>
is within a component’s stache
Frank Lemanschik
@frank-dspeed
i have such buttons also
they rock
:D
Nico R.
@nriesco
and the saveAndClose function receives the correct object so everything is ok
But I have a modal that I want to close after saving
Frank Lemanschik
@frank-dspeed
yes thats cool i agree total
then fire save
Nico R.
@nriesco
So how can I send the current element information without setting an inserted event?
Frank Lemanschik
@frank-dspeed
like this.dispatch('save')
Nico R.
@nriesco
where?
Frank Lemanschik
@frank-dspeed
and then do listeh this.on('save')
don't know your code
Viktor Busko
@Lighttree

Guys, I'm working with can.js + webpack and currently trying to create analogs of donejs cli. I already created generators for canjs + webpack stack, but there is something that as far as I can see webpack can't reproduce:

I have plugin with component and there is file like:
entity-details-component.html - purpose of this file is demo it's functionality. And in donejs it uses can-autorender to render component in html without any...entry point.

<script type="text/stache" can-autorender>
  <can-import from="<%= module %>/" />
  <<%= tag %>></<%= tag %>>
</script>
<script src="<%= root %>node_modules/steal/steal.js"
        main="can-view-autorender"></script>

I can't use something like this, because can-autorender works in steal builds. (same issue valid for test.html)
Only way that I can see for now is create..some kind of renderer.js file and include it to development build:

import stache from 'can-stache';
import './award-details-component';

document.body.appendChild(stache('<entity-details-component entity:from="data"></entity-details-component>')({data}));

and then:

 <script src="main.bundle.js"></script>

This works...but this "renderer" file annoys me :) Maybe you can see more elegant way to do this ?

DaveO
@DaveO-Home

@frank-dspeed @Lighttree One solution at least for Webpack and Browserify could be
//!steal-remove-start
/ develblock:start /
//removeIf(production)

...dev code

//endRemoveIf(production)
/ develblock:end /
//!steal-remove-end

and uglify could strip remaining comments.

Viktor Busko
@Lighttree
This will work only if you use strip-block-loader for webpack, so I doubt that something like this will be added to can.js source :)
Or maybe I miss something, anyway modifying canjs source code not really good option.
DaveO
@DaveO-Home
No, I wouldn't the code myself
How do I edit a typeo -- I meant No, I wouldn't change the code myself
Brad Momberger
@bmomberger-bitovi
"Edit" is in the kebab menu that shows up when you hover your pointer over the message you sent.
Justin Meyer
@justinbmeyer
Viktor Busko
@Lighttree
@DaveO-Home If you interested in how to remove this //!steal-remove-start with web-pack. I think its possible to write simple loader like this one: https://github.com/jballant/webpack-strip-block/blob/master/index.js (maybe fork) and replace regex with the same sued here: https://github.com/stealjs/steal-tools/blob/master/lib/build/clean.js
DaveO
@DaveO-Home
@Lighttree No problem, I've done that but you would think that canjs could be used seamlessly.
Viktor Busko
@Lighttree
Yeah sure
Brad Momberger
@bmomberger-bitovi
@Lighttree for the component generation, you'd probably want to just create a done-cli generator for components that uses a Webpack compatible script in the .html (most of the code from donejs-generator/component can be reused). So then you could just do, e.g., donejs add webpack-component and go through the same steps.
Nico R.
@nriesco
when using a model to store data in the database, I see that when .save() is used a PUT request is sent with all the information. How can I force it not to do a PUT but a PATCH and send only changes instead of the whole object? Is this part of can-connect. I define my models using superMap + can-connect-feathers
Brad Momberger
@bmomberger-bitovi
If you want to do every PUT as a PATCH, it's easier to set up the feathers service to do this instead of the client.
So your before hooks would include this:
      update: [
        context => {
          return context.service.patch(context.id, context.data, context.params)
            .then(result => {
              context.result = result
              return context
            })
        }
      ],
Nico R.
@nriesco
but it will still send all the data, even if it has not been modified
I’m just being lazy, I thought forcing .save to try first to do a sort of .update only on thinks that change
it would be great and save a lot of data traffic
But it works right now so its just for optimizing
it could be usefull for mobile devices though
@bmomberger-bitovi do you know who is responsible for doing that update? Can-connect? Can-connect-feathers?
Supermap?
Brad Momberger
@bmomberger-bitovi
Supermap and can-connect-feathers are really just collections of can-connect behaviors.
If you want to pare down your update set to just what changed, you can implement your own behavior for that.
Nico R.
@nriesco
so who decides that .save should result in a PUT/UPDATE? or in a CREATE?
because a new element will be created when using .save
and updated if it exists
so I guess it would be the same place to decide to patch instead of update
just wondering
Brad Momberger
@bmomberger-bitovi
That comes from the constructor behavior.
So your patch diffing would have to go somewhere up the proto chain from constructor in your connection.