Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 00:14
    greenkeeper[bot] labeled #5449
  • 00:14
    greenkeeper[bot] opened #5449
  • 00:14

    greenkeeper[bot] on can-super-model-2.0.0

    fix(package): update can-super-… (compare)

  • 00:13
    greenkeeper[bot] labeled #5448
  • 00:13
    greenkeeper[bot] opened #5448
  • 00:13

    greenkeeper[bot] on can-define-rest-model-2.0.0

    fix(package): update can-define… (compare)

  • 00:12
    greenkeeper[bot] labeled #5447
  • 00:12
    greenkeeper[bot] opened #5447
  • 00:12

    greenkeeper[bot] on can-define-realtime-rest-model-2.0.0

    fix(package): update can-define… (compare)

  • 00:07
    greenkeeper[bot] labeled #5446
  • 00:07
    greenkeeper[bot] opened #5446
  • 00:07

    greenkeeper[bot] on can-connect-ndjson-2.0.0

    fix(package): update can-connec… (compare)

  • Dec 13 21:27

    greenkeeper[bot] on @octokit

    (compare)

  • Dec 13 21:25

    greenkeeper[bot] on @octokit

    chore(package): update @octokit… (compare)

  • Dec 13 21:21

    greenkeeper[bot] on @octokit

    (compare)

  • Dec 13 21:20

    greenkeeper[bot] on @octokit

    chore(package): update @octokit… (compare)

  • Dec 12 19:26
    cherifGsoul review_requested #5443
  • Dec 12 18:34
    cherifGsoul synchronize #5443
  • Dec 12 18:34

    cherifGsoul on document-inserted-removed-can6

    Update after review (compare)

  • Dec 12 17:44

    cherifGsoul on theme-3.0.0-pre.5

    (compare)

Frank Lemanschik
@frank-dspeed
are there new callbacks for can4?
i remember something but find no entry points about that
Kevin Phillips
@phillipskevin
@runn-vermel that is just setting up a https://developer.mozilla.org/en-US/docs/Web/Events/change event
@frank-dspeed https://canjs.github.io/next/doc/migrate-4.html has a section on inserted/removed
there is a new connectedCallback, or you can add back in support for inserted
import "can-3-4-compat/dom-mutation-events";
Gregg Roemhildt
@roemhildtg
Hey guys, I often run into this error:
Potentially unhandled rejection [2] TypeError: Cannot define property _instanceDefinitions, object is not extensible
Finding the cause isn't hard, its usually I forgot to define a property, so I usually just set a console.log breakpoint on the line with the prop name..but I think having some sort of warning for newbies would be really helpful
Kevin Phillips
@phillipskevin
I agree - that warning is really unhelpful
can you open an issue in can-define?
we should be able to give the name of the prop and the name of the DefineMap
Gregg Roemhildt
@roemhildtg
Yep, will do.
Gregg Roemhildt
@roemhildtg
canjs/can-define#309
Gregg Roemhildt
@roemhildtg
Anyone ever created a "batch save" method in can-connect? Instead of model.save(oneItem) saving multiple items in one requestmodel.save([item1, item2, item3]);?
I gotta create about a thousand records in one go...and I think calling .save x1000 would not be pretty
feathersClient accepts an array of data though...so maybe a custom behavior with a special function like saveBatch would be the way to go.
sound about right?
Nico R.
@nriesco
@roemhildtg the Potentially unhandled rejecttion … object is not extensible error occurs when that variable is not defined in the viewmodel
usually happens when you are trying to get a property from the wrong place
Kevin Phillips
@phillipskevin
the problem he is pointing out is that _instanceDefinitions is not the name of the property that is being set
Nico R.
@nriesco
or you just forgot to define it, I think the difficutly is that it only occurs when trying to save or when you don’t load an inital content
Oh, I see
Gregg Roemhildt
@roemhildtg
Hey, calling a definMap.get should return all its properties, right? Even if serialize:false is set on a property?
Or does serialize: false affect .get() as well as .serialize()?
Kevin Phillips
@phillipskevin
get also just returns enumerable properties
Runn Vermel
@runn-vermel
@phillipskevin - the problem is that i can't data bind it - long story. there's something that's preventing the select from knwoing there's been a change in the option selected. i know (vaguely) that canJs has something that adds a value property to a select - but that doesn't seem to get updated. it knows there's a change, but the value on the select doesn't change, so i was hoping that maybe there's a way to access the change event that is generated with the ($change) function call
Gregg Roemhildt
@roemhildtg
Okay gotcha.
Kevin Phillips
@phillipskevin
<select> has value without CanJS
Runn Vermel
@runn-vermel
@phillipskevin i humbly disagree: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select - it has selectedIndex but no value.
that's why I tried it in the JSBin... because it wasn't readily available on the docs you pointed out
it's in the DOM Interface link though
Runn Vermel
@runn-vermel
ha - thanks MDN. 2 docs for the same thing with different attributes on them. either way, value isn't being updated when i make a new selection... any ideas?
Kevin Phillips
@phillipskevin
the value isn't? or the property you're binding it to isn't?
Runn Vermel
@runn-vermel
the value isn't
i can't bind to a property because of how the data is structured.
so, i just wanna be notified when there's a change, and check for the (hopefully) changed value, and act accordingly
Kevin Phillips
@phillipskevin
  <select class="form-control"
          {($value)}="trainsByPlatform[platform.name]"
          ($change)="upsertInitialRelease(platform.name, scope.element.value)">
    <option></option>
    {{#each trains[platform.name] as train}}
    <option value="{{train.name}}">{{train.name}}</option>
    {{/each}}
  </select>
is that the code you have?
Runn Vermel
@runn-vermel
yup
Kevin Phillips
@phillipskevin
and you're saying that upsertInitialRelease isn't being called?
Runn Vermel
@runn-vermel
it is, but scope.element.value is NEVER changed
Kevin Phillips
@phillipskevin
ok
so... I would first change {($value)} to be only one-way bound
{$value}
so you only have one handler element->viewModel and one handler viewModel->element
right now you have a two-way binding and a one-way binding
Runn Vermel
@runn-vermel
at first we thought perhaps it was a timing issue - but it NEVER changes, and the select doesn't actaully show the new option - it always stays at the empty first option
Kevin Phillips
@phillipskevin
did you try changing it to
          {$value}="trainsByPlatform[platform.name]"
          ($change)="upsertInitialRelease(platform.name, scope.element.value)">