Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 21:27

    greenkeeper[bot] on @octokit

    (compare)

  • 21:25

    greenkeeper[bot] on @octokit

    chore(package): update @octokit… (compare)

  • 21:21

    greenkeeper[bot] on @octokit

    (compare)

  • 21:20

    greenkeeper[bot] on @octokit

    chore(package): update @octokit… (compare)

  • Dec 12 19:26
    cherifGsoul review_requested #5443
  • Dec 12 18:34
    cherifGsoul synchronize #5443
  • Dec 12 18:34

    cherifGsoul on document-inserted-removed-can6

    Update after review (compare)

  • Dec 12 17:44

    cherifGsoul on theme-3.0.0-pre.5

    (compare)

  • Dec 12 17:44

    cherifGsoul on master

    Update bit-doc-html-canjs (#544… (compare)

  • Dec 12 17:44
    cherifGsoul closed #5445
  • Dec 12 17:01
    cherifGsoul opened #5445
  • Dec 12 17:01

    cherifGsoul on theme-3.0.0-pre.5

    Update bit-doc-html-canjs Upda… (compare)

  • Dec 12 16:40

    cherifGsoul on update-api-page

    (compare)

  • Dec 12 16:39

    cherifGsoul on master

    Update API page (#5432) * Upda… (compare)

  • Dec 12 16:39
    cherifGsoul closed #5432
  • Dec 12 16:39
    cherifGsoul closed #5304
  • Dec 12 01:04
    greenkeeper[bot] commented #5392
  • Dec 12 01:04

    greenkeeper[bot] on core-js-3.5.0

    chore(package): update core-js … (compare)

  • Dec 11 18:34
    greenkeeper[bot] labeled #5444
  • Dec 11 18:34
    greenkeeper[bot] opened #5444
Matthew Phillips
@matthewp
I've never done that personally... but helpers would be a way to escape from stache in hot areas...
Justin Meyer
@justinbmeyer
Are extra scopes a perf problem?
Guido Smeets
@gsmeets
well I'm creating a table with pagination here
going from not rendering the table body to rendering it is going from 25-50ms on page swapping to 200-350ms
so I was hoping to avoid some subtemplate calls and scope creation by optimizing
Justin Meyer
@justinbmeyer
are you sure it's the scope creation?
I guess if you have some time, @gsmeets , I'd love to see your app and do some profiling
Justin Meyer
@justinbmeyer
or, if you could export the profiling and send it to me, that would be awesome too
Guido Smeets
@gsmeets
@justinbmeyer sure, I got time
It seems about 100ms is just rendering the table cell contents
so I'm wondering if there's actually any way to speed that up
Gregg Roemhildt
@roemhildtg
Did something break recently with can-stache each loops?
{{#each(objects, object=value)}}
{{#each(scope.vm.fields, field=value)}}
{{../object[field]}} // not working because object is undefined?
{{/each}}
{{/each}}
Kevin Phillips
@phillipskevin
@roemhildtg can you run npm ls --depth=0
and paste the results
Gregg Roemhildt
@roemhildtg
I think I know what the issue is. I deleted my package-lock.json and node_modules and updated to try and fix some webpack issue I was having
I got the latest can-stache 4.11 then, which maybe changed syntax?
Kevin Phillips
@phillipskevin
shouldn't have
I'll take a look
Kevin Phillips
@phillipskevin
definitely a bug in can-stache or can-view-scope
going back to can-stache@4.10.5 and can-view-scope@4.7.1 works
we'll look into this right away, thanks for reporting
Gregg Roemhildt
@roemhildtg
Sounds good :100:
Julian
@pYr0x
is conncet.tag deprecated?
https://github.com/canjs/can-connect/blob/master/all.js should contain connect.tag = require('./can/tag/tag');
i can create a hotfix if you want
Julian
@pYr0x
this indexNum helper is not working anymore
scope.indexNum should be indexNum ?
Matthew Phillips
@matthewp
@pYr0x yeah, it was removed from 3.x
it's there now
Julian
@pYr0x
so why the source is still in master branch?
Julian
@pYr0x
@justinbmeyer @phillipskevin is it not possible to use </content> to own a inner html block as the view and pass the VM to this view
it would be nice to have some html file that has a custom compnent (e.g. <x-import>) and its content is the stache view and the VM gets passed into this view
currently, <x-entnahmestelle-list> will be rendered but {{bar}} or vm:msg:to="bar"will not work
it does not have to content maybe some new special tag
^^ New can-route is out which makes using it much easier thanks to DefineMap.
No more serialize: false!!!
Gregg Roemhildt
@roemhildtg
Question - in the newest can-stache does #with still create a new scope?
I know #for of does not
Kevin Phillips
@phillipskevin
#with does, yes
we're going to add a #let helper that can be used like #with but without creating a new scope
Gregg Roemhildt
@roemhildtg
That'll be nice and easy
Kevin Phillips
@phillipskevin
that bug you found yesterday is fixed now also: https://github.com/canjs/can-view-scope/releases/tag/v4.8.1
Gregg Roemhildt
@roemhildtg
:+1: