Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 14 17:40
    nlundquist edited #5424
  • Nov 14 17:40
    nlundquist edited #5424
  • Nov 14 17:39
    nlundquist opened #5424
  • Nov 14 17:39
    nlundquist review_requested #5424
  • Nov 14 17:39

    nlundquist on 107-update-converter-demos

    update can-stache-converters de… (compare)

  • Nov 14 14:32
    greenkeeper[bot] labeled #5423
  • Nov 14 14:32
    greenkeeper[bot] opened #5423
  • Nov 14 14:32

    greenkeeper[bot] on can-route-5.0.1

    fix(package): update can-route … (compare)

  • Nov 13 13:09

    greenkeeper[bot] on steal-tools-2.2.3

    (compare)

  • Nov 13 12:55

    greenkeeper[bot] on steal-tools-2.2.3

    chore(package): update steal-to… (compare)

  • Nov 13 01:44

    greenkeeper[bot] on @webcomponents

    (compare)

  • Nov 13 01:42

    greenkeeper[bot] on @webcomponents

    chore(package): update @webcomp… (compare)

  • Nov 12 05:28
    greenkeeper[bot] commented #5392
  • Nov 12 05:28

    greenkeeper[bot] on core-js-3.4.1

    chore(package): update core-js … (compare)

  • Nov 11 18:03
    greenkeeper[bot] labeled #5422
  • Nov 11 18:03
    greenkeeper[bot] opened #5422
  • Nov 11 18:03

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • Nov 11 18:02
    greenkeeper[bot] commented #5401
  • Nov 11 18:02

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • Nov 10 23:39

    greenkeeper[bot] on @octokit

    (compare)

Paul Tichonczuk
@tracer99
Thanks. That last one worked!
nmingneau
@nmingneau
Hi, this codepen gives a different result in edge compared to other browsers. https://codepen.io/nmingneau/pen/PxWPLm?editors=1010
nmingneau
@nmingneau
Can.construct also seems to be looping through init and newInstance long after rendering seems to be complete for my project. This is not the case in chrome, firefox or safari.
Andrei Balmus
@abalmush
hi guys can someone help me with can-migrate? for some reasons html files are not updated for example: {product}=“dataProduct” needs to be change to product:bind=“dataProduct” but it’s still the old one
I’m runningthis command can-migrate -a src/**/*.{js,md,html,stache,component} -t can-stache-bindings/
Kevin Phillips
@phillipskevin
you need to wrap your glob patterns in quotes @abalmush
otherwise bash will automatically try to expand them before passing them to can-migrate
Andrei Balmus
@abalmush
ah ok thank you very much!
Andrei Balmus
@abalmush
@phillipskevin sorry to bother you again. Do you know if ther are any codemods that fix Controls events. Before in CanJs2 I used something like this: ':input:not(:button) focusout': 'onFocusoutEventHandler’, in my Controls to exclude buttons, but now it looks like it is not working and I need to fix it somehow
Kevin Phillips
@phillipskevin
does it work if you do '{element} :input:not(:button) focusout'?
Andrei Balmus
@abalmush
let me check
Andrei Balmus
@abalmush
no luck, I’m trying to debug it and it still shows :input:not(:button) without {element}
Screen Shot 2018-11-13 at 5.43.01 PM.png
node_modules/can-dom-events/helpers/-make-delegate-event-tree.js - line 31
Kevin Phillips
@phillipskevin
is the {element} inside your quotes?
I messed it up when I typed it originally
Andrei Balmus
@abalmush
yes it is inside and I think this is because of jquery is not a part of canjs anymore, so the selectors I used worked with jQuery but they are not working in document.querySelector I will try using vanilla queries that works in document.querySelector
Kevin Phillips
@phillipskevin
oh, yeah, good catch
Andrei Balmus
@abalmush
for example '{element} [type="checkbox"] change’: onCheckboxChanged worked ok
Gregg Roemhildt
@roemhildtg
Hi guys, I've got a side project I've dabbled with in the past and would like to try integrating more tightly with Canjs. Its using Openlayers - a sort of observable mapping library. It has these observable list-like objects called collections, and I'm having issues getting it to work with canjs templates for of, each, etc.
Can anyone lend any tips? Here's the main file where I am adding canjs symbols to the list-like element: https://github.com/roemhildtg/can-ol-symbol/blob/master/lib/assignCanListSymbols.js
There's also a basic demo that can be ran with steal/http-server here: https://github.com/roemhildtg/can-ol-symbol/blob/master/index.html
nmingneau
@nmingneau
Hi, can someone please help me with this issue in edge? https://codepen.io/nmingneau/pen/PxWPLm?editors=1010 It seems to be a bug in can.js but i'm unable to fix it in a reasonable timeframe.
nmingneau
@nmingneau
I made an issue: canjs/can-construct#68
Viktor Busko
@Lighttree
Guys maybe someone use some technique for CSS encapsulation in CanJS ? As far as I know CanJS componenents can't encapsulate styles (not sure about DoneJS).
For now I can see only "CSS Modules" as possible technique.
Gregg Roemhildt
@roemhildtg

I typically use less, and I wrap each compoennt's styles in something like this:

component-name {
    .child-classname { ...}
}

So the output css is always

component-name .child-classname {}
Viktor Busko
@Lighttree

Well this is not true encapsulation, such issue we can handle using something like BEM.

I'm talking about different thing:
Imagine you have page with two components componentA and componentB, both of them use component custom-button, but in componentA we have button v1 and in componentB button v2 they both may have same CSS class names and this is valid, but the code inside might be different. As result in stylesheet we will have custom-button twice with different styles.

Currently we solve this by putting all shared styles as peerDependencies for host app. So its like app where you use custom-button decides which version it will use and injects only one version of any stylesheet. But this adds some field to make mistakes, if you publish something incorrectly.
Chasen Le Hara
@chasenlehara
@nmingneau Thanks for the issue. I whittled down the CodePen a little bit more. I’ll see if I can spend some more time on it tomorrow.
nmingneau
@nmingneau
Does anyone know if there is a way to disable the logging in fixtures when they receive a call?
Justin Meyer
@justinbmeyer
There is not. Easy to add. Why do you want it?
nmingneau
@nmingneau
yes please, it takes a lot of space in my unit tests
Justin Meyer
@justinbmeyer
@nmingneau can you create an issue to enable a fixture.log(false) ?

generally speaking, it will be as simple to add as finding these logs:

https://github.com/canjs/can-fixture/blob/master/core.js#L197

and wrapping them with a check if(fixture._log) { ... }
RyanMilligan
@RyanMilligan

Has anyone seen an error like this before?

Uncaught DOMException: Failed to execute 'pushState' on 'History': A history state object with URL 'http:/#admin/posts' cannot be created in a document with origin 'http://localhost:8080' and URL 'http://localhost:8080/#admin/posts'.

It's coming from can-route-pushstate. I'm trying to figure out why it's happening, but if anyone knows where to look and can save me some time, that would be great. The router works fine in this application in development mode, but throws that error when using steal.production.js.
Matthew Phillips
@matthewp
@RyanMilligan you don't have a property named route on your viewModel do you?
RyanMilligan
@RyanMilligan
Hrm, a very interesting question. On the app view model? Not that I see.
Matthew Phillips
@matthewp
ok, that was a bit of a guess
I remember running into something like this and that was the problem
route is a semi-reserved word
RyanMilligan
@RyanMilligan
I just did a search for route and I don't see any properties with that name. Just references to can-route.
RyanMilligan
@RyanMilligan
We have app, page, slug, action, actionTwo and env.
RyanMilligan
@RyanMilligan
And because it only happens when we build, it's very difficult to diagnose.
Matthew Phillips
@matthewp
i saw something similar a while back and there was a loop occuring
ever time the route was set something in the route.data viewmodel was setting another property
I would check if something like that occurs
RyanMilligan
@RyanMilligan
Hrm. I have logs on all the setters for the viewmodel properties and they're only getting called the one time.
Matthew Phillips
@matthewp
hm, im out of ideas then