Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 12:56
    matthewp edited #5119
  • Sep 15 18:40
    lateshift starred canjs/canjs
  • Sep 13 21:53
    chasenlehara closed #5207
  • Sep 13 21:28

    chasenlehara on major

    Update dist for release (compare)

  • Sep 13 21:28

    chasenlehara on v6.0.0-pre.14

    Update dist for release 6.0.0-pre.14 (compare)

  • Sep 13 21:22

    chasenlehara on 5207-remove-can-define

    (compare)

  • Sep 13 21:22

    chasenlehara on major

    Remove can-define usage in CanJ… (compare)

  • Sep 13 21:22
    chasenlehara closed #5282
  • Sep 13 21:08

    m-mujica on playlist

    WIP: Upgrade playlist editor to… (compare)

  • Sep 13 20:19
    m-mujica commented #5119
  • Sep 13 17:36
    m-mujica edited #5119
  • Sep 13 17:15
    m-mujica edited #5119
  • Sep 13 16:34
    chasenlehara review_requested #5282
  • Sep 13 16:34
    chasenlehara review_requested #5282
  • Sep 13 16:33
    chasenlehara ready_for_review #5282
  • Sep 13 15:04

    greenkeeper[bot] on webpack-4.40.2

    (compare)

  • Sep 13 14:47

    greenkeeper[bot] on webpack-4.40.2

    chore(package): update webpack … (compare)

  • Sep 13 14:36
    chasenlehara synchronize #5282
  • Sep 13 14:36

    chasenlehara on 5207-remove-can-define

    Remove can-define usage in CanJ… (compare)

  • Sep 13 13:56
    chasenlehara synchronize #5282
Kevin Phillips
@phillipskevin
we never updated can-util to use newer can-dom-data-state, but we aren't using any of the can-util/dom packages that import it
Ivo Pinheiro
@ivospinheiro
I'm still having issues, even after removing node_modules and npm-shrinkwrap.json
When I run npm ls can-dom-data-state I get this:
├─┬ can-attribute-observable@1.2.1
│ └── can-dom-data-state@1.0.5  deduped
├─┬ can-component@4.4.10
│ └── can-dom-data-state@1.0.5  deduped
├─┬ can-connect@2.1.0
│ └─┬ can-view-import@4.2.0
│   └── can-dom-data-state@1.0.5  deduped
├── can-dom-data-state@1.0.5 
├─┬ can-stache@4.15.12
│ └── can-dom-data-state@1.0.5  deduped
├─┬ can-stache-bindings@4.8.0
│ └── can-dom-data-state@1.0.5  deduped
└─┬ can-util@3.14.0
  ├── can-dom-data-state@0.2.0 
  ├─┬ can-event-dom-enter@1.0.4
  │ └── can-dom-data-state@0.2.0  deduped
  └─┬ can-event-dom-radiochange@1.0.5
    └── can-dom-data-state@0.2.0  deduped
Kevin Phillips
@phillipskevin
can you check what is importing from can-util/dom
either search your project
or you can use System._traceData.parentMap if you're using steal
Ivo Pinheiro
@ivospinheiro
Currently I'm not using any can-util/dom
How do I use System._traceData.parentMap?
Kevin Phillips
@phillipskevin
once your app is loaded, you can type that in the devtools console
and look for can-dom-data-state@0.2.0
it should show you the modules that load it
Ivo Pinheiro
@ivospinheiro
I have this:
image.png
Ivo Pinheiro
@ivospinheiro
Could it be related with can-event?
It seems that it depends on can-util/dom
Matthew Phillips
@matthewp
yes, you dont need can-event in a canjs 4/5 app
Ivo Pinheiro
@ivospinheiro
It was the usage of can-event/batch/batch
I'm working on a branch to upgrade the application to canjs@4 and on the rebase to get the latest changes I've forgot to change this
Is there any guide how to debug this kind of conflicts?
It happens once in a while when we upgrade some can dependency
Gregg Roemhildt
@roemhildtg
I delete the package-lock.json and the node_modules. Then npm i
Ivo Pinheiro
@ivospinheiro
In my case it wasn't the solution
I had to analyse the System._traceData.parentMap information in order to understand why there were two different versions of can-dom-data-state being imported
Ivo Pinheiro
@ivospinheiro
I have a question in can-connect/contructor/store
Should in this case be used canBatch?
https://github.com/canjs/can-connect/blob/4f284fc8b9026767e7cf0f69968a94319b559f13/constructor/store/store.js#L524-L533
Justin Meyer
@justinbmeyer
@ivospinheiro maybe ... is updatedInstance not already in a batch?
store is really supposed to mostly ignorant of canjs ... it's possible that hydrateInstance should be overwritten in can-connect/can/map
though I think queues is probably ok for store to know about
Gregg Roemhildt
@roemhildtg
Anyone have any debugging tips for troubleshooting this error? Chrome freezes up with Paused before potential out of memory crash and then this happens a couple of minutes later:
image.png
Manuel Mujica
@m-mujica
@roemhildtg do you have can-debug installed? I wonder if doing something like this https://canjs.com/doc/guides/debugging.html#Debugwhatcausedaobservableeventorupdatetohappen_ could help you figure out if you have some sort of binding-cycle.
can.queues.logStack(); might help you figure out why that code keeps executing... There are other debugging tips in that guide as well.
Gregg Roemhildt
@roemhildtg
I can't get that to run once this happens. It's like the whole browser is locked up
Manuel Mujica
@m-mujica
Screen Shot 2018-12-14 at 9.06.33 AM.png
hmm I see. One thing I've done when stuff like that happens is, since it's likely you have a code path executing in a cycle... Before the browser dies, you can pause the code execution.
sometimes the stack trace helps me figure out what's going on.
Gregg Roemhildt
@roemhildtg
Yeah, that pause button doesn't become available in this case. Whatever's causing this appears to be locking up the browser immediately perhaps a loop with a memory leak that immediately allocates all of the available memory?
Manuel Mujica
@m-mujica
well, then I would start commenting out code... in there is a specific template you're rendering, try removing components and see if that makes the problem go away.
Gregg Roemhildt
@roemhildtg
Yeah Ill start looking into it that way
Gregg Roemhildt
@roemhildtg
Okay, I've narrowed down the issue
Its a partial that has a let helper used
{{let url = object.attributes[field.name]}}
{{#if(url)}}
<a href="{{#if(field.urlPrefix)}}{{field.urlPrefix}}{{/if}}{{url}}{{#if(field.urlSuffix)}}{{field.urlSuffix}}{{/if}}" 
    target="_blank">
    <i class="{{#if(field.iconClass}}{{field.iconClass}}{{else}}fa fa-external-link{{/if}}"></i>
    {{#if(field.linkText)}}{{field.linkText}}{{else}}Link{{/if}}
</a>
{{else}}
<p>None</p>
{{/if}}
It renders fine the first time, but when object changes it freezes up
It actually renders fine the first time object changes, but the second time it freezes up
qantourisc
@qantourisc
BTW is there a way to do <{{{somefield}}/> ?
@roemhildtg Do you get an error, or just nothing ?
Justin Meyer
@justinbmeyer
@qantourisc the best way of doing that is via component constructors
@roemhildtg I've fixed the bug ... getting a PR and release together now
Justin Meyer
@justinbmeyer
Gregg Roemhildt
@roemhildtg
Sounds good! Thanks for the quick fix!
released