Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 13:07
    matthewp opened #5292
  • 13:06

    matthewp on setupguide

    Current static Update setting up canjs The setting up guide (compare)

  • 07:26

    greenkeeper[bot] on webpack-cli-3.3.9

    (compare)

  • 07:18

    greenkeeper[bot] on webpack-cli-3.3.9

    chore(package): update webpack-… (compare)

  • 04:54
    justinbmeyer commented #5290
  • Sep 16 20:45
    matthewp commented #5291
  • Sep 16 20:44
    matthewp synchronize #5291
  • Sep 16 20:44

    matthewp on type8

    Increase bundlesize for core T… (compare)

  • Sep 16 20:30
    matthewp opened #5291
  • Sep 16 20:29

    matthewp on type8

    Upgrade to can-type 1.0.0-pre.8 (compare)

  • Sep 16 20:23
    phillipskevin labeled #5290
  • Sep 16 20:23
    phillipskevin labeled #5290
  • Sep 16 20:23
    phillipskevin opened #5290
  • Sep 16 19:56

    chasenlehara on major

    Bump can-connect version (compare)

  • Sep 16 18:12
    greenkeeper[bot] labeled #5289
  • Sep 16 18:12
    greenkeeper[bot] opened #5289
  • Sep 16 18:11

    greenkeeper[bot] on can-map-4.3.10

    fix(package): update can-map to… (compare)

  • Sep 16 17:51

    chasenlehara on major

    Update dependencies for 5.33.1 Update dist for release Merge branch 'master' into major (compare)

  • Sep 16 17:34

    chasenlehara on master

    Update dist for release (compare)

  • Sep 16 17:34

    chasenlehara on v5.33.1

    Update dist for release 5.33.1 (compare)

Kevin Phillips
@phillipskevin
can you check what is importing from can-util/dom
either search your project
or you can use System._traceData.parentMap if you're using steal
Ivo Pinheiro
@ivospinheiro
Currently I'm not using any can-util/dom
How do I use System._traceData.parentMap?
Kevin Phillips
@phillipskevin
once your app is loaded, you can type that in the devtools console
and look for can-dom-data-state@0.2.0
it should show you the modules that load it
Ivo Pinheiro
@ivospinheiro
I have this:
image.png
Ivo Pinheiro
@ivospinheiro
Could it be related with can-event?
It seems that it depends on can-util/dom
Matthew Phillips
@matthewp
yes, you dont need can-event in a canjs 4/5 app
Ivo Pinheiro
@ivospinheiro
It was the usage of can-event/batch/batch
I'm working on a branch to upgrade the application to canjs@4 and on the rebase to get the latest changes I've forgot to change this
Is there any guide how to debug this kind of conflicts?
It happens once in a while when we upgrade some can dependency
Gregg Roemhildt
@roemhildtg
I delete the package-lock.json and the node_modules. Then npm i
Ivo Pinheiro
@ivospinheiro
In my case it wasn't the solution
I had to analyse the System._traceData.parentMap information in order to understand why there were two different versions of can-dom-data-state being imported
Ivo Pinheiro
@ivospinheiro
I have a question in can-connect/contructor/store
Should in this case be used canBatch?
https://github.com/canjs/can-connect/blob/4f284fc8b9026767e7cf0f69968a94319b559f13/constructor/store/store.js#L524-L533
Justin Meyer
@justinbmeyer
@ivospinheiro maybe ... is updatedInstance not already in a batch?
store is really supposed to mostly ignorant of canjs ... it's possible that hydrateInstance should be overwritten in can-connect/can/map
though I think queues is probably ok for store to know about
Gregg Roemhildt
@roemhildtg
Anyone have any debugging tips for troubleshooting this error? Chrome freezes up with Paused before potential out of memory crash and then this happens a couple of minutes later:
image.png
Manuel Mujica
@m-mujica
@roemhildtg do you have can-debug installed? I wonder if doing something like this https://canjs.com/doc/guides/debugging.html#Debugwhatcausedaobservableeventorupdatetohappen_ could help you figure out if you have some sort of binding-cycle.
can.queues.logStack(); might help you figure out why that code keeps executing... There are other debugging tips in that guide as well.
Gregg Roemhildt
@roemhildtg
I can't get that to run once this happens. It's like the whole browser is locked up
Manuel Mujica
@m-mujica
Screen Shot 2018-12-14 at 9.06.33 AM.png
hmm I see. One thing I've done when stuff like that happens is, since it's likely you have a code path executing in a cycle... Before the browser dies, you can pause the code execution.
sometimes the stack trace helps me figure out what's going on.
Gregg Roemhildt
@roemhildtg
Yeah, that pause button doesn't become available in this case. Whatever's causing this appears to be locking up the browser immediately perhaps a loop with a memory leak that immediately allocates all of the available memory?
Manuel Mujica
@m-mujica
well, then I would start commenting out code... in there is a specific template you're rendering, try removing components and see if that makes the problem go away.
Gregg Roemhildt
@roemhildtg
Yeah Ill start looking into it that way
Gregg Roemhildt
@roemhildtg
Okay, I've narrowed down the issue
Its a partial that has a let helper used
{{let url = object.attributes[field.name]}}
{{#if(url)}}
<a href="{{#if(field.urlPrefix)}}{{field.urlPrefix}}{{/if}}{{url}}{{#if(field.urlSuffix)}}{{field.urlSuffix}}{{/if}}" 
    target="_blank">
    <i class="{{#if(field.iconClass}}{{field.iconClass}}{{else}}fa fa-external-link{{/if}}"></i>
    {{#if(field.linkText)}}{{field.linkText}}{{else}}Link{{/if}}
</a>
{{else}}
<p>None</p>
{{/if}}
It renders fine the first time, but when object changes it freezes up
It actually renders fine the first time object changes, but the second time it freezes up
qantourisc
@qantourisc
BTW is there a way to do <{{{somefield}}/> ?
@roemhildtg Do you get an error, or just nothing ?
Justin Meyer
@justinbmeyer
@qantourisc the best way of doing that is via component constructors
@roemhildtg I've fixed the bug ... getting a PR and release together now
Justin Meyer
@justinbmeyer
Gregg Roemhildt
@roemhildtg
Sounds good! Thanks for the quick fix!
released
Justin Meyer
@justinbmeyer
One thing I did to make canjs "break" was to set the task limit in queues to 1000 ... I wonder if we should enable this as a debugging tool
I'll write up an issue