Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 14 21:13
    greenkeeper[bot] labeled #5378
  • Oct 14 21:12
    greenkeeper[bot] opened #5378
  • Oct 14 21:12

    greenkeeper[bot] on can-simple-map-4.3.3

    fix(package): update can-simple… (compare)

  • Oct 14 20:19
    greenkeeper[bot] labeled #5377
  • Oct 14 20:19
    greenkeeper[bot] opened #5377
  • Oct 14 20:19

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • Oct 14 20:18
    greenkeeper[bot] labeled #5376
  • Oct 14 20:18
    greenkeeper[bot] opened #5376
  • Oct 14 20:18

    greenkeeper[bot] on @feathersjs

    chore(package): update @feather… (compare)

  • Oct 14 14:43
    greenkeeper[bot] closed #5373
  • Oct 14 14:43

    greenkeeper[bot] on can-deep-observable-1.0.1

    (compare)

  • Oct 14 14:42

    m-mujica on update-deep-observable

    (compare)

  • Oct 14 14:42

    m-mujica on master

    Update can-deep-observable to l… Merge pull request #5374 from c… (compare)

  • Oct 14 14:42
    m-mujica closed #5374
  • Oct 14 14:42
    m-mujica closed #5365
  • Oct 14 14:09
    f-ricci starred canjs/canjs
  • Oct 14 13:55
    greenkeeper[bot] commented #5375
  • Oct 14 13:55

    greenkeeper[bot] on core-js-3.3.2

    chore(package): update core-js … (compare)

  • Oct 14 10:51
    m-mujica review_requested #5374
  • Oct 14 07:43
    rjgotten commented #5358
Ivo Pinheiro
@ivospinheiro
I have this:
image.png
Ivo Pinheiro
@ivospinheiro
Could it be related with can-event?
It seems that it depends on can-util/dom
Matthew Phillips
@matthewp
yes, you dont need can-event in a canjs 4/5 app
Ivo Pinheiro
@ivospinheiro
It was the usage of can-event/batch/batch
I'm working on a branch to upgrade the application to canjs@4 and on the rebase to get the latest changes I've forgot to change this
Is there any guide how to debug this kind of conflicts?
It happens once in a while when we upgrade some can dependency
Gregg Roemhildt
@roemhildtg
I delete the package-lock.json and the node_modules. Then npm i
Ivo Pinheiro
@ivospinheiro
In my case it wasn't the solution
I had to analyse the System._traceData.parentMap information in order to understand why there were two different versions of can-dom-data-state being imported
Ivo Pinheiro
@ivospinheiro
I have a question in can-connect/contructor/store
Should in this case be used canBatch?
https://github.com/canjs/can-connect/blob/4f284fc8b9026767e7cf0f69968a94319b559f13/constructor/store/store.js#L524-L533
Justin Meyer
@justinbmeyer
@ivospinheiro maybe ... is updatedInstance not already in a batch?
store is really supposed to mostly ignorant of canjs ... it's possible that hydrateInstance should be overwritten in can-connect/can/map
though I think queues is probably ok for store to know about
Gregg Roemhildt
@roemhildtg
Anyone have any debugging tips for troubleshooting this error? Chrome freezes up with Paused before potential out of memory crash and then this happens a couple of minutes later:
image.png
Manuel Mujica
@m-mujica
@roemhildtg do you have can-debug installed? I wonder if doing something like this https://canjs.com/doc/guides/debugging.html#Debugwhatcausedaobservableeventorupdatetohappen_ could help you figure out if you have some sort of binding-cycle.
can.queues.logStack(); might help you figure out why that code keeps executing... There are other debugging tips in that guide as well.
Gregg Roemhildt
@roemhildtg
I can't get that to run once this happens. It's like the whole browser is locked up
Manuel Mujica
@m-mujica
Screen Shot 2018-12-14 at 9.06.33 AM.png
hmm I see. One thing I've done when stuff like that happens is, since it's likely you have a code path executing in a cycle... Before the browser dies, you can pause the code execution.
sometimes the stack trace helps me figure out what's going on.
Gregg Roemhildt
@roemhildtg
Yeah, that pause button doesn't become available in this case. Whatever's causing this appears to be locking up the browser immediately perhaps a loop with a memory leak that immediately allocates all of the available memory?
Manuel Mujica
@m-mujica
well, then I would start commenting out code... in there is a specific template you're rendering, try removing components and see if that makes the problem go away.
Gregg Roemhildt
@roemhildtg
Yeah Ill start looking into it that way
Gregg Roemhildt
@roemhildtg
Okay, I've narrowed down the issue
Its a partial that has a let helper used
{{let url = object.attributes[field.name]}}
{{#if(url)}}
<a href="{{#if(field.urlPrefix)}}{{field.urlPrefix}}{{/if}}{{url}}{{#if(field.urlSuffix)}}{{field.urlSuffix}}{{/if}}" 
    target="_blank">
    <i class="{{#if(field.iconClass}}{{field.iconClass}}{{else}}fa fa-external-link{{/if}}"></i>
    {{#if(field.linkText)}}{{field.linkText}}{{else}}Link{{/if}}
</a>
{{else}}
<p>None</p>
{{/if}}
It renders fine the first time, but when object changes it freezes up
It actually renders fine the first time object changes, but the second time it freezes up
qantourisc
@qantourisc
BTW is there a way to do <{{{somefield}}/> ?
@roemhildtg Do you get an error, or just nothing ?
Justin Meyer
@justinbmeyer
@qantourisc the best way of doing that is via component constructors
@roemhildtg I've fixed the bug ... getting a PR and release together now
Justin Meyer
@justinbmeyer
Gregg Roemhildt
@roemhildtg
Sounds good! Thanks for the quick fix!
released
Justin Meyer
@justinbmeyer
One thing I did to make canjs "break" was to set the task limit in queues to 1000 ... I wonder if we should enable this as a debugging tool
I'll write up an issue
Gregg Roemhildt
@roemhildtg
It would be good to have some way of preventing issues like this. Not that it happens often, but when it does its pretty tough finding the source
Justin Meyer
@justinbmeyer
@roemhildtg I don't think there's a way to prevent it, but that issue has an idea about how to spot the problem.
Well, it might be preventable as we could see the same function added multiple times to the queue in the same "batch"
Frank Lemanschik
@frank-dspeed
@justinbmeyer do you got a idea how to polyfill this
view-model.mjs:25 Uncaught (in promise) ReferenceError: regeneratorRuntime is not defined
    at eval (view-model.mjs:25)
    at AppViewModel{}'s componentToShow getter (view-model.mjs:25)
    at Observation.onBound (can-observation.js:86)
    at KeyTree.add (can-key-tree.js:140)
    at Observation.on (value.js:35)
    at Object.eval [as onValue] (observe.js:25)
    at Function.temporarilyBind (temporarily-bind.js:23)
    at AppViewModel.get AppViewModel{}.componentToShow (can-define.js:780)
    at AppViewModel.getKeyValue (map.js:58)
    at Object.getKeyValue (get-set.js:80)
some how for me it looks like steal don't likes dynamic import
maybe i need newer bable?