Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 23 16:39
    enquora commented #2954
  • Nov 23 11:04
    cacaodev commented #2954
  • Nov 23 11:02
    djbewick closed #2957
  • Nov 23 11:02
    djbewick commented #2957
  • Nov 23 10:27
    cappbot commented #2957
  • Nov 23 10:17
    mrcarlberg commented #2957
  • Nov 23 10:03
    cappbot labeled #2957
  • Nov 23 10:03
    cappbot milestoned #2957
  • Nov 23 10:02
    djbewick opened #2957
  • Nov 22 10:01
    mrcarlberg commented #2956
  • Nov 22 10:01

    mrcarlberg on master

    Fixed: Missing call to super in… (compare)

  • Nov 22 10:01
    mrcarlberg closed #2956
  • Nov 21 21:10
    didierkorthoudt commented #2914
  • Nov 21 11:20
    cappbot commented #2956
  • Nov 21 11:11
    cappbot labeled #2956
  • Nov 21 11:11
    cappbot milestoned #2956
  • Nov 21 11:11
    didierkorthoudt edited #2956
  • Nov 21 11:09
    didierkorthoudt edited #2956
  • Nov 21 11:09
    didierkorthoudt opened #2956
  • Nov 20 16:52
    enquora commented #2942
David Richardson
@enquora
Screen Shot 2020-10-13 at 9.11.23 AM.pdf
David Richardson
@enquora
@didierkorthoudt I see that CPButtonBar now explicity enables button borders. This seems to be a change - is it a deliberate choice or a mistake?
daboe01
@daboe01
@didierkorthoudt no problem. works for me :-)
David Richardson
@enquora
@mrcarlberg @didierkorthoudt I’m seeing problems with the recently merged CPBox changes (#2924). Most problematic: when a CPTableView control is a child of CPBox (using IB palette, so the full view hierarchy from scrollview down), nib2cib throws the error null is not an object (evaluating 'self._tableColumnRanges[index - 1]’)
No problem if the tableview isn’t inside a box. The tableview has no datasource or delegate declared at this point. This happens with any box type or configuration.
David Richardson
@enquora

Also, when box type is Old Style with Line border type, a warnings are thrown during nib2cib pointing to using the Custom box type and setting the border radius manually - yet that seems to have no effect. Is this a work-in-progress?

The warning appears to be interpreted as an error by nib2cib and halt compilation, but I’m not certain about that yet.

I’m on my own branch, which was should include the Oct 2 merges, but I’ll switch back to master. I see a significant number of new merges over the weekend so it’s worth pulling them in.
David Richardson
@enquora
Problem still exists after switching to master and pulling in latest merge
David Richardson
@enquora
David Richardson
@enquora
If other merges don’t yet depend on #2924 it should be reverted pending expanded testing, imo
Didier Korthoudt
@didierkorthoudt
@enquora The warnings are due to the « modern Cocoa » behavior, as some things are now deprecated… The problem with CPTableView in CPBox seems strange and I’ll dig into it. Thank you for the reduction !
David Richardson
@enquora
@didierkorthoudt Is #2924 intended to support setting box corner radii in IB or is it a work-in-progress? They don’t seem to be settable here.
Martin Carlberg
@mrcarlberg
Woo-hoo, Cappuccino day for me today 😃
Didier Korthoudt
@didierkorthoudt
If only I could… Maybe this afternoon… 🤞🏻
Martin Carlberg
@mrcarlberg
:thumbsup:
David Richardson
@enquora
@mrcarlberg I’ve closed the original PR with the upgrade to the xib/cib format and opened another with it’s own branch. The original PR was from an ongoing Tools branch - Github’s interface for PRs makes it confusing to switch branches for an unresolved PR :-( No content has changed between the two PRs
cacaodev
@cacaodev
Some buttons in the framework are now rounded, for example in CPButtonBar or in CPAlert. What is happening here ? Is it a new buttonType or a new default in a theme attribute ?
Michael Bach
@michaelbach
Dear All:

I just pulled the latest master, and like @enquora find "Yet CPButtons are displayed with a highly radiused border, unlike Aristo2". But why should my stuff switch to Aristo3 already? I changed nothing and the borders are still pixelated, so it should be Aristo2. But it should NOT have these large radii in buttons!
And I just (a little late) note that @cacaodev noticed same.

Thank you, best, Michael

Didier Korthoudt
@didierkorthoudt
@michaelbach @cacaodev Yes, indeed, @enquora found it too. I have to check what’s happening with Aristo2. It may be related to default button type as I’ve implemented all Cocoa types of buttons… Stay tuned…
Didier Korthoudt
@didierkorthoudt
@mrcarlberg Cappuccino day for me… 😉
Michael Bach
@michaelbach
thank you!
Didier Korthoudt
@didierkorthoudt
@mrcarlberg I’ve adapted #2918 as asked…
Didier Korthoudt
@didierkorthoudt
@mrcarlberg @michaelbach @cacaodev @enquora @daboe01 Well… After digging for some hours, switching between master, my own master, searching, scratching my head, …, I must admit that what you’ve seen in button look is… well… the correct thing. Let me explain : in Aristo2, there is only 2 visual types of button : RoundRect and Rounded. Rounded (with high radius) is the default for regular “push” buttons. What I think is that I’ve fixed something not correct in CPButton in order to be able to implement all types of buttons and that it has a side effect : making Aristo2 using the correct look.
Here is the left part of the rounded bezel :
button-bezel-rounded-left.png
And here is the left part of the round rect bezel :
button-bezel-left.png
These images are directly taken from Aristo2.
Here is a test with both types of buttons :
Screen Shot 2020-10-25 at 4.45.12 PM.png
As you see, everything is correct. I may have passed beside something important, just let me know…
I may try to implement a workaround in order to restore previous behavior, just let me know if you need it. Regarding CPButtonBar, well, as I’ve reworked it completely, please consider the new version (yet to be finalized and merged).
Didier Korthoudt
@didierkorthoudt
@mrcarlberg Beside that, I’ll have to make a PR to remove dev comments remaining in CPButton… Sorry for this.
Didier Korthoudt
@didierkorthoudt
I must now rebase my repo in order to go further. My next target will be to finalize CPButtonBar using the new buttons (some fixes may be needed).
cacaodev
@cacaodev
You changed the default bezel style from CPRoundRectBezelStyle to CPRoundedBezelStyle https://github.com/cappuccino/cappuccino/blame/master/AppKit/CPButton.j#L207
This is something we should discuss first in a PR
Didier Korthoudt
@didierkorthoudt
@cacaodev Indeed ! Thank you for pointing this. I’ve set it to rounded (push) as this is the standard button. But if you create your buttons by code, without specifying anything, it should go back to RoundRect style. Will change this so it will go back to old way of doing. Easy thank to you !..
Didier Korthoudt
@didierkorthoudt
@cacaodev @mrcarlberg I’ve pushed #2947 to fix default bezel style problem in CPButton. I’ve also removed unwanted comments…
David Richardson
@enquora

The larger button radii didn’t present a big visual problem here for existing work but the button borders in CPButtonBar and the table problems inside boxes are more worriesome. For most, if not all, of the last half-decade (at least), the main branch could plausibly be used in production apps. There is significant value in this approach - it greatly extends our testing, particularly wrt visual changes. Even Apple has (apparently) very minimal automated testing of visual changes, and implementing such is well beyond what is feasible for us. Having the main branch used by many people in existing apps provides a very real benefit.

I’m skeptical this continues to be viable (until Aristo3 is closer to fully merged) given the last few batches of merges and the complexity of the complete visual layer overhaul which is underway.

What are the arguments against merging the Aristo3 changes into an intermediate branch? This would make broader testing easier, and switching back to something stable easier - imo. The intermediate branch could then be merged into main on a regular but less frequent schedule.

Martin Carlberg
@mrcarlberg
@enquora There are many ways we can do the merger of @didierkorthoudt excellent work. We should all expect to find bugs even as I and others are testing before merging. We are using git and it is very easy to use an older version by date for production apps if needed.
It is easier for us to just merge it into the master branch and it will be tested faster :smile:
Martin Carlberg
@mrcarlberg
So, I guess we all have to live with some more bugs in master now until we can fix them all.
Didier Korthoudt
@didierkorthoudt
@mrcarlberg I’ll (try to) propose a fix for current CPButtonBar so the new CPButtonBar could be fully tested.
Martin Carlberg
@mrcarlberg
@didierkorthoudt Great! :smiley:
Michael Bach
@michaelbach
@mrcarlberg: "It is easier for us to just merge it into the master branch and it will be tested faster…" Actually, yes! Once I know the Master is appropriately updated, I'll test with ≈100 programs :) [really! but most are rather similar to each other in their resource usage].
And now I know how to roll back: Also (something in) the narwhal folder must be rolled back, not just the Framworks folder.
Didier Korthoudt
@didierkorthoudt
@enquora @mrcarlberg @daboe01 Could you please test your button bars with current master (that is with #2947 merged) ? I’ve done a quick test and all seems in order now, as you can see here :
Screen Shot 2020-10-28 at 2.56.56 PM.png
David Richardson
@enquora
#2947 fixes buttons inside CPButtonBar
Didier Korthoudt
@didierkorthoudt
@enquora Great !
Thank you for testing on your side !
David Richardson
@enquora
I again raise concerns about merging such a large undertaking as Aristo3 directly into the main branch. With anything so complex, problems and odditites are inevitable. They really deserve their own intermediate branch, to be merged into main only after extended testing by multiple people with real projects.