mrcarlberg on master
Fixed: Missing call to super in… (compare)
CPButton. I’ve also removed unwanted comments…
The larger button radii didn’t present a big visual problem here for existing work but the button borders in CPButtonBar and the table problems inside boxes are more worriesome. For most, if not all, of the last half-decade (at least), the main branch could plausibly be used in production apps. There is significant value in this approach - it greatly extends our testing, particularly wrt visual changes. Even Apple has (apparently) very minimal automated testing of visual changes, and implementing such is well beyond what is feasible for us. Having the main branch used by many people in existing apps provides a very real benefit.
I’m skeptical this continues to be viable (until Aristo3 is closer to fully merged) given the last few batches of merges and the complexity of the complete visual layer overhaul which is underway.
What are the arguments against merging the Aristo3 changes into an intermediate branch? This would make broader testing easier, and switching back to something stable easier - imo. The intermediate branch could then be merged into main on a regular but less frequent schedule.
CPBox problem was introduced in #2924
nib2cib throws the error
null is not an object (evaluating 'self._tableColumnRanges[index - 1]’) when it encounters that configuration. The changes to
nib2cib were minimal - the
CPBox implementation looks more likely.
CPBoxrevisions should trigger it is unclear though.
objj_backtrace_print(CPLog.warn);to print out the call stack.