Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 23 16:39
    enquora commented #2954
  • Nov 23 11:04
    cacaodev commented #2954
  • Nov 23 11:02
    djbewick closed #2957
  • Nov 23 11:02
    djbewick commented #2957
  • Nov 23 10:27
    cappbot commented #2957
  • Nov 23 10:17
    mrcarlberg commented #2957
  • Nov 23 10:03
    cappbot labeled #2957
  • Nov 23 10:03
    cappbot milestoned #2957
  • Nov 23 10:02
    djbewick opened #2957
  • Nov 22 10:01
    mrcarlberg commented #2956
  • Nov 22 10:01

    mrcarlberg on master

    Fixed: Missing call to super in… (compare)

  • Nov 22 10:01
    mrcarlberg closed #2956
  • Nov 21 21:10
    didierkorthoudt commented #2914
  • Nov 21 11:20
    cappbot commented #2956
  • Nov 21 11:11
    cappbot labeled #2956
  • Nov 21 11:11
    cappbot milestoned #2956
  • Nov 21 11:11
    didierkorthoudt edited #2956
  • Nov 21 11:09
    didierkorthoudt edited #2956
  • Nov 21 11:09
    didierkorthoudt opened #2956
  • Nov 20 16:52
    enquora commented #2942
Didier Korthoudt
@didierkorthoudt
Screen Shot 2020-10-28 at 2.56.56 PM.png
David Richardson
@enquora
#2947 fixes buttons inside CPButtonBar
Didier Korthoudt
@didierkorthoudt
@enquora Great !
Thank you for testing on your side !
David Richardson
@enquora
I again raise concerns about merging such a large undertaking as Aristo3 directly into the main branch. With anything so complex, problems and odditites are inevitable. They really deserve their own intermediate branch, to be merged into main only after extended testing by multiple people with real projects.
Didier Korthoudt
@didierkorthoudt
@enquora Well, this is @mrcarlberg work so I let him decide (I’ll do whatever is decided, of course)
David Richardson
@enquora
That leaves the strange behaviour of CPTableView inside CPBox. I haven’t had time in the last week to look further into it, but am settling back into some Cappuccino work
Didier Korthoudt
@didierkorthoudt
@enquora This is my next target
David Richardson
@enquora
@daboe01 What became of your stack exhaustion problem? I just noticed your reduction is still in my Downloads folder - wondering if this was resolved?
1 reply
David Richardson
@enquora

@didierkorthoudt The CPTableView inside CPBox problem was introduced in #2924

nib2cib throws the error null is not an object (evaluating 'self._tableColumnRanges[index - 1]’) when it encounters that configuration. The changes to nib2cib were minimal - the CPBox implementation looks more likely.

I have created a reverting patch to allow staying current with everything else - I can jump back and forth quickly now if you see something needing a quick test
David Richardson
@enquora
The immediate error is actually in the table - obviously, boxes don’t have table columns. Is a variable in CPBox being leaked globally that is clobbering a loop initialization or iterator in CPTableView?
Michael Bach
@michaelbach
With the latest master (½hr ago) I noticed
(1) button radii are fine now, thanks!
(2) the stepper arrows are no longer visible as shown it these 2 screenshots.
Best, M
David Richardson
@enquora
We have a xib label or two needing client-specific terminology. Is it appropriate to use localization in Cocoa for such situations? Perhaps specified in a sub-region of a language? Where does Cappuccino stand wrt localization support in general?
Didier Korthoudt
@didierkorthoudt
@michaelbach Thank you for pointing out the stepper problem… I’ll have a look. Should be simply the button type… (I hope so)
Didier Korthoudt
@didierkorthoudt
@michaelbach #2948 fixes the stepper problem.
Didier Korthoudt
@didierkorthoudt
@enquora I can indeed reproduce your table in a box problem. That’s the positive side of a negative situation… 😉 Will dig on this one.
Shawn Platkus
@platkus
@enquora I’ve come across the need for having client requested string labels in our Mac app. I don’t think localization techniques is the right call here as those strings would need localizations themselves. In our Mac app, there was a specific bike for this OEM and check aged the strings just for that OEM build.
For a Cappuccino app, the approach I would take for just a couple strings would be to special case them in the code. Our Cappuccino app has a JSON file of tags and values that we read in when the application starts up. I have OEM specific values in this JSON file that can be set to tell my application what installation specific options are desired. You could do something similar with a JSON Boolean or string for this client that tells your application to use the alternate strings. You could even embed the alternate strings in this JSON config file and read them from there and set them in code dynamically.
1 reply
cacaodev
@cacaodev
There are also issues with radio buttons. In Tests/Manual/CPRadioBindings you can now select multiple radio buttons and you coud not before the recent merges. An "out of bounds" error is also thrown when you select index 0 in the first popup of second section.
Didier Korthoudt
@didierkorthoudt
@cacaodev I’ve not checked this manual test indeed. This should be a side effect of the modern Cocoa radio buttons management. I’ll have a look ASAP. Thank you for pointing this.
Michael Bach
@michaelbach
@didierkorthoudt: I fixed the steppers according to your PR and they are fine now, great!
I was just going to report the radio button issue, I have it too. There's more: the rotary slider is drawn as a tiny linear slider, not a round disk with indicator. Furthermore, on some buttons (especially when I use some unicode for label) there is an exception as shown in the attached screenshot. Finally, I get an error with array manipulation, also shown in a screenshot.
And I nearly forgot: Sometimes checkboxes stay visually checked, although they transmit their status change correctly to their action functions.
Still, thanks for your immense efforts!
Screenshot 2020-10-29 at 18.25.11.png
Screenshot 2020-10-29 at 18.38.23.png
David Richardson
@enquora
@didierkorthoudt This looks likely to be where the tableview error occurs: https://github.com/cappuccino/cappuccino/blob/e6fe9396f8956447616b0140270249a74ecd6bf2/AppKit/CPTableView.j#L1746
Why your CPBox revisions should trigger it is unclear though.
Didier Korthoudt
@didierkorthoudt
@mrcarlberg Hi Martin ! I’m trying to debug @enquora problem with table in box… It’s a nib2cib problem so difficult to debug. Is there something I could call to trace the call stack ? I’m currently inserting CPLog.info here and there but it would be easier to obtain the full call stack.
Martin Carlberg
@mrcarlberg
@didierkorthoudt You could remove the msgSend inline option by removing the -O2 compiler option in the Jakefile for nib2cib
That will allow you to turn on backtrace decorators by adding the following line somewhere in the nib2cib tool:objj_msgSend_decorate(objj_backtrace_decorator);
Finally you could use objj_backtrace_print(CPLog.warn); to print out the call stack.
Didier Korthoudt
@didierkorthoudt
@mrcarlberg Thank you !
Didier Korthoudt
@didierkorthoudt
@enquora @mrcarlberg This table in a box problem seems (yet another time) related to a non-ready view (the table view). It doesn’t seem to be fully decoded when the box tries to set its own frame, thus setting the table frame also… I continue to dig into this…
I’ll try this with #2917 to see if it’s fixing this problem also…
Didier Korthoudt
@didierkorthoudt
Nope. Would have been too easy…
Didier Korthoudt
@didierkorthoudt
@enquora @mrcarlberg OK, found a fix. Have to test further and clean things…
Martin Carlberg
@mrcarlberg
:thumbsup:
Didier Korthoudt
@didierkorthoudt
@enquora @mrcarlberg #2949 fixes the “table in a box” problem.
@enquora Could you please check that it also works for you ?
David Richardson
@enquora
@didierkorthoudt First test indicates it works. I’ll have a definitive answer Monday morning after full testing
Looking at the fix, one wonders how this worked at all previously
Didier Korthoudt
@didierkorthoudt
@enquora Well, this could be due to many things like, for example, a change in CPBox subviews decoding order… And, yes, I’ve never tested putting a CPTableView inside a CPBox… 😉
Didier Korthoudt
@didierkorthoudt
@mrcarlberg Sorry for #2950 but each time I compile Cappuccino, I say to myself “I’ll fix this warning ASAP”… for about a year !.. So this is now fixed. 😉
daboe01
@daboe01
@didierkorthoudt we really appreciate your endurance with finishing this mammoth task
Didier Korthoudt
@didierkorthoudt
@daboe01 Thank you but it’s only because each time I push a PR, my wife gives me a beer… 😉 Currently working on your buttons title alignment problem...
daboe01
@daboe01
excellent stuff!!
Didier Korthoudt
@didierkorthoudt
@daboe01 It works with Aristo2 but you’ll have to wait for Aristo3 to obtain those windows-like window buttons icons… 😉
David Richardson
@enquora
I presume Travis’ pricing changes affect us. Can anyone comment on the specifics?
Martin Carlberg
@mrcarlberg
@enquora Do you have any info about what "pricing changes" Travis has done?
David Richardson
@enquora
@mrcarlberg As I read it, Travis CI FOSS accounts must now use their new Trial plan, are credited 1,000 minutes, and can ask for more credits when those are exhausted.
David Richardson
@enquora
Also, do we test-build XcodeCapp? I assume so, and Mac costing appears to be more expensive. Although it appears possible to perform only the XcodeCapp portion on Mac infrastructure