Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 21 13:58

    grzkv on master

    metrics: adding linear bucket h… Merge pull request #216 from bo… (compare)

  • Oct 21 13:58
    grzkv closed #216
  • Oct 19 14:23
    azhiltsov review_requested #216
  • Oct 19 14:21
    azhiltsov synchronize #216
  • Oct 19 14:21

    azhiltsov on find_lin_buckets

    metrics: adding linear bucket h… (compare)

  • Oct 18 15:15
    azhiltsov synchronize #216
  • Oct 18 15:15

    azhiltsov on find_lin_buckets

    metrics: adding linear bucket h… (compare)

  • Oct 18 15:13
    azhiltsov opened #216
  • Oct 18 15:12

    azhiltsov on find_lin_buckets

    metrics: adding linear bucket h… (compare)

  • Oct 17 13:24
    azhiltsov commented #215
  • Oct 17 13:22
    bom-d-van opened #215
  • Oct 08 21:58
    paskal commented #190
  • Oct 08 21:52
    paskal synchronize #190
  • Oct 08 21:51
    paskal synchronize #190
  • Oct 08 21:24
    paskal synchronize #190
  • Oct 08 21:14
    paskal synchronize #190
  • Oct 08 21:09
    paskal synchronize #190
  • Oct 08 20:51
    paskal synchronize #190
  • Oct 08 20:49
    paskal synchronize #190
  • Sep 27 08:23

    grzkv on refactor-ci

    (compare)

Roman Grytskiv
@grzkv
Hey
Pablo Luis Zorzoli
@plz
Hey
Roman Grytskiv
@grzkv
@/all Please, use this chat for open-source discussion. PR review requests, sending issues, etc. Thanks!
Meanwhile, I will try adding integrations.
Roman Grytskiv
@grzkv
Yay, github integration works!
Roman Grytskiv
@grzkv
Just need to configure what notifications we get.
Roman Grytskiv
@grzkv
I suggest we disable codecov commenting in PRs. What do you think? It creates a lot of noise.
Roman Grytskiv
@grzkv

@/all Please, don’t merge PRs, just approve. Because:

  • there may be conflicts, and merging should be the responsibility of PR creator
  • sometimes merges can be risky and need to be postponed or tested first
  • if there are several PRs they may need merging in specific order

Thanks!

Roman Grytskiv
@grzkv
@gksingh__twitter Regarding cairo changes
I think, moving 1.14 → 1.16 breaks the compatibility
You can try downgrading with removing current stuff and
brew install Caskroom/cask/xquartz
Alexey Zhiltsov
@azhiltsov
from our internal git:
graphite: locking cairo version to 1.14.6
Upgrade to the 1.15.12 broke the python graphite
Roman Grytskiv
@grzkv
pushed docs about supported cairo version
We need to think about
  • if we want to upgrade Cairo
  • if we want to keep the PR about pixel_ratio that breaks cairo v1.16
Roman Grytskiv
@grzkv
Can someone please have a look at bookingcom/carbonapi#78 and bookingcom/carbonapi#79 Thanks!
Alexey Zhiltsov
@azhiltsov
@grzkv done
Roman Grytskiv
@grzkv
@azhiltsov Re our discussion where to put info
https://github.com/torvalds/linux/pull/17#issuecomment-5654674
Linus agrees with you)
Info should go into commit messages.
@azhiltsov @gksingh__twitter Please, review bookingcom/carbonapi#81
Roman Grytskiv
@grzkv
@azhiltsov @gksingh__twitter Please, review bookingcom/carbonapi#85
Roman Grytskiv
@grzkv
Vladimir Pestov
@KozzyKoder
Hey, how can I find what rules we validate against on this task: bookingcom/carbonapi#171 ?
Roman Grytskiv
@grzkv
Hi @KozzyKoder . Sorry for late response. I was on vacation. The task is not fully defined. There are some obvious cases that need to be eliminated. You can start with those. Other cases still need to be worked out in detail. Please start a discussion around the ticket. You can start working out obvious cases that are already described in the ticket right away.
Roman Grytskiv
@grzkv
@KozzyKoder Please, ask here if you have some more questions.