Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 09 17:12
    bors[bot] closed #334
  • Oct 09 17:12
    bors[bot] closed #333
  • Oct 09 17:12

    bors[bot] on master

    [fetch] use cli git for fetchin… Merge branch 'master' into fix-… [Cargo.lock] update libc and 1 more (compare)

  • Oct 09 17:12
    bors[bot] commented #334
  • Oct 09 16:24

    bors[bot] on staging.tmp

    (compare)

  • Oct 09 16:24

    bors[bot] on staging

    Merge #334 334: [fetch] use cl… (compare)

  • Oct 09 16:24

    bors[bot] on staging.tmp

    [fetch] use cli git for fetchin… Merge branch 'master' into fix-… [Cargo.lock] update libc and 1 more (compare)

  • Oct 09 16:24

    bors[bot] on staging.tmp

    [ci skip][skip ci][skip netlify] (compare)

  • Oct 09 16:24
    ordian commented #334
  • Oct 09 16:23
    ordian synchronize #334
  • Oct 09 16:20
    bors[bot] commented #334
  • Oct 09 16:05

    bors[bot] on staging.tmp

    (compare)

  • Oct 09 16:05

    bors[bot] on staging

    Merge #334 334: [fetch] use cl… (compare)

  • Oct 09 16:05

    bors[bot] on staging.tmp

    [fetch] use cli git for fetchin… Merge branch 'master' into fix-… [ci skip][skip ci][skip netlify… (compare)

  • Oct 09 16:05

    bors[bot] on staging.tmp

    [ci skip][skip ci][skip netlify] (compare)

  • Oct 09 16:05
    ordian commented #334
  • Oct 09 16:04
    ordian synchronize #334
  • Oct 09 15:49
    bors[bot] commented #334
  • Oct 09 15:34

    bors[bot] on staging.tmp

    (compare)

  • Oct 09 15:34

    bors[bot] on staging

    [fetch] use cli git for fetchin… Merge #334 334: [fetch] use cl… (compare)

Bastien Orivel
@Eijebong
Sure I'll report all of them !
all the bugs !
Pascal Hertleif
@killercup
oh god what have we done :O now that you can cargo-upgrade instead of doing this manually you have way too much time to report bugs!
Bastien Orivel
@Eijebong
I wish :D
There
Pascal Hertleif
@killercup
thanks <3
Bastien Orivel
@Eijebong
Oh you can put an @ !!!!
Pascal Hertleif
@killercup
@Eijebong huh?
Bastien Orivel
@Eijebong
cargo upgrade parking_lot@0.6
So it puts 0.6 in the toml instead of 0.6.3
Pascal Hertleif
@killercup
oh, is that not in the --help?
it should be!
Bastien Orivel
@Eijebong
It is
But do I look like someone that reads doc ? :trollface:
Pascal Hertleif
@killercup
:D
Bastien Orivel
@Eijebong
First PR where I used cargo upgrade opened \o/
Pascal Hertleif
@killercup
:tada:
Bastien Orivel
@Eijebong
I'm actually going to use this a lot now that it doesn't completly destroy tomls
Especially in servo because upgrading stuff in there is painful
Pascal Hertleif
@killercup
:)
Bastien Orivel
@Eijebong
It's borken !!
[eijebong@bananium] ~/code/lyon (master) >>> cargo upgrade euclid --all
Command failed due to unhandled error: Failed to get workspace metadata
Caused by: Error parsing major identifier at line 1 column 24776
Bastien Orivel
@Eijebong
     Running `target/debug/cargo-upgrade upgrade --major-only`
cargo-edit:
    Upgrading cargo_metadata v0.5.6 -> v0.6.0
    Upgrading termcolor v0.3 -> v1.0.0
    Upgrading error-chain v0.11.0 -> v0.12.0
:tada:
Pascal Hertleif
@killercup
thanks for that awesome pr @Eijebong <3
Bastien Orivel
@Eijebong
Np :) Will address review comments tonight
Otavio Salvador
@otavio
Hello folks, I did a PR to bump the error-chain and cargo_metadata versions.
It should be good to go, I think. I did run all tests locally and I did not see problems
laurent bernabé
@loloof64
Hi everyone ! Cargo Edit seems to be a wonderfull tool, however, I am a bit worried of the fact it could not be used in Rust stable : so is it really the case ?
Pascal Hertleif
@killercup
@loloof64 cargo-edit absolutely works on stable. Why would you think otherwise?
laurent bernabé
@loloof64
Hi :smile: Thank you for your answer. In fact I just looked at the dependencies in the Readme : and I saw rustfmt-nightly
Pascal Hertleif
@killercup
@loloof64 ah, sorry, those are dependencies that we internally use when developing cargo-edit itself! (and they are both available on stable with rtustup nowadays!)
laurent bernabé
@loloof64
ok. No problem :smile:
Pascal Hertleif
@killercup
we should probably update the readme :)
laurent bernabé
@loloof64
Thank you anyway :smile:
Pascal Hertleif
@killercup
of course
Robin Krahl
@robinkrahl
Hi! I’d like to package cargo-edit for Debian. Would that be okay with you?
Pascal Hertleif
@killercup
@robinkrahl hi! of course!
Robin Krahl
@robinkrahl
@killercup Nice, thanks for the quick answer! I’ll leave a note here once I’m done (might take some time as I have to take care of some dependencies first).
Pascal Hertleif
@killercup
@robinkrahl cool! the project is pretty much in "rudimentary maintenance mode" from my side. if you'd like to update any dependencies, feel free to ping me here or on github and i'll make sure to make a new release :)
David Laban
@alsuren

I'm heading to bed now, but I think I have a fix for the section re-ordering thing ( killercup/cargo-edit#218 ).

I've got a friend who's mentoring me to help make things more idiomatic, and then I will start submitting PRs.

  • 1st pr will probably be to make impl Display for Table use something like the visitor pattern, rather than Cell and RefCell
  • 2nd pr will probably be to use pretty_assertions in tests
  • 3rd PR will probably be to enable the fix for #218 (store sort_position on each table when parsing, and then emit tables in order of sort_position when displaying). I'm not sure whether to fix the order in Display::fmt, or add a separate Document::to_string_in_original_order() method.
Andronik Ordian
@ordian
@killercup Apparently github is down: https://www.githubstatus.com/incidents/qjhqlf52nw6n. The code in 3e9994fad7965d120c415b3b97c39c031dc1a892 LGTM.
Pascal Hertleif
@killercup
@ordian hah, just when I had some time to work on stuff! i'll wait a few hours and make proper prs
hah, now it worked
Andronik Ordian
@ordian
nice :thumbsup:
Darin
@Dowwie
@killercup @ordian looking forward to the next cargo-edit release -- when are you planning to ?
Andronik Ordian
@ordian
@Dowwie I've opened #332
Darin
@Dowwie
@ordian :thumbsup:
Darin
@Dowwie
thanks for releasing!
:fireworks: