Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Cary Robbins
    @carymrobbins
    @yanoziel I haven't yet worked on 2020 support. Will update you once it's done.
    Imran Settuba
    @sImttuba_gitlab
    What are the remaining steps for 2020.1?
    Cary Robbins
    @carymrobbins
    I have a branch here that I've started work on - https://github.com/carymrobbins/intellij-haskforce/commits/idea-2020.1
    That branch fails to compile due to a deprecation -
    % ./gradlew test
...
:compileScala
.../intellij-haskforce/src/com/haskforce/codeInsight/HaskellCompletionCacheLoader.scala:21: trait ProjectComponent in package components is deprecated: see corresponding Javadoc for more information.
class HaskellCompletionCacheLoader(project: Project) extends ProjectComponent {
                                                             ^
    So some things need to be re-worked to get around this. Either that or allow the deprecation for now. I would kind of prefer to fix the deprecation though.
    Here's the javadoc for the deprecation 
    /**
 * @deprecated components are deprecated. If you register a class as a project component it will be loaded, its instance will be created and
 * {@link #initComponent()} and {@link #projectOpened()} methods will be called for each project even if user doesn't use any feature of your
 * plugin. Also plugins which declare project components don't support dynamic loading. Please see
 * http://www.jetbrains.org/intellij/sdk/docs/basics/plugin_structure/plugin_components.html for guidelines on migrating to other APIs.
 */
@Deprecated
public interface ProjectComponent extends BaseComponent {
    Cary Robbins
    @carymrobbins
    https://www.jetbrains.org/intellij/sdk/docs/basics/plugin_structure/plugin_components.html
    To store the state of your plugin at the application or project level, use a Service and implement the PersistentStateComponent interface. See Persisting State of Components for details.
    Imran Settuba
    @sImttuba_gitlab
    Yeah thats no problem
    ProjectComponents have an isomorphic service representation. Do you have any state in this component?
    Cary Robbins
    @carymrobbins
    Yes, there's a cache field. It's fairly primitive - https://github.com/carymrobbins/intellij-haskforce/blob/idea-2020.1/src/com/haskforce/codeInsight/HaskellCompletionCacheLoader.scala
    Imran Settuba
    @sImttuba_gitlab
    I’ve got that working now
    I have 3 failed tests
    Cary Robbins
    @carymrobbins
    awesome, want to push that up to a branch?
    Imran Settuba
    @sImttuba_gitlab
    I’ll send in the link, when the PR is open
    Cary Robbins
    @carymrobbins
    :tada:
    Imran Settuba
    @sImttuba_gitlab
    done carymrobbins/intellij-haskforce#429
    Cary Robbins
    @carymrobbins
    @sImttuba_gitlab Appreciate that, left some comments.
    Imran Settuba
    @sImttuba_gitlab
    Read and added changes. What do you wanna call the listener?
    This listener is much more powerful, if you consider the sort of optimizations you can do over each phase over the lifecycle
    removing a shit tone of boiler plate
    Cary Robbins
    @carymrobbins

    What do you wanna call the listener?

    I assume you are talking about HaskellCompletionCacheLoader ? I think for now the current name might be ok. It's used in other places so likely easier to just leave the current name now.

    Imran Settuba
    @sImttuba_gitlab
    No, nvm. In my ide it only shows the 2019.3 API’s so I can’t see those depreecation errors your refering to
    Cary Robbins
    @carymrobbins
    Try compiling with ./gradlew test
    You might also need to refresh the gradle project in your IDE so it will use the 2020.1 API
    Imran Settuba
    @sImttuba_gitlab
    did that multiple times
    I doesn’t compile locally because the build set up is a bit weird. It still doesn’t upload the 2020.1 libs
    Would be nice if you could chime in I removed the change where you showed me the error
    Cary Robbins
    @carymrobbins
    When you run ./gradlew test does it download 2020.1 resources?
    Imran Settuba
    @sImttuba_gitlab
    nop
    I checked gradle and it does still kep the 2019.3 versions around
    Cary Robbins
    @carymrobbins
    Yes, it will keep them cached I believe, unless you remove them
    Imran Settuba
    @sImttuba_gitlab
    also the gradle intelliJ plugin version needs to be updated
    if we wanna go for 2020.1
    Already did multiple times and gradle just adds them after cleaning them or removing them manually
    please feel free to add commits if you have it working
    I send you an invite to push into the PR
    Cary Robbins
    @carymrobbins
    Awesome, will do
    Just have work-work stuff to do first
    As for debugging your issue, may want to check here -
    % ls -1 ~/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIC
193.5233-EAP-CANDIDATE-SNAPSHOT
2019.2.1
2019.3
2019.3.1
2020.1
LATEST-EAP-SNAPSHOT
    Imran Settuba
    @sImttuba_gitlab

    No problem, didn’t wanted to be pushy. 

    193-EAP-SNAPSHOT
2019.2
2019.2.1
2019.2.4
2019.3
2019.3.1
2019.3.3
2019.3.4
2020.1
2020.1.1
LATEST-EAP-SNAPSHOT

    Those are my results

    Cary Robbins
    @carymrobbins
    weird, so you do have the 2020 sources
    Imran Settuba
    @sImttuba_gitlab
    Yep. But the project doesn’t load them to the plugiin. I ‘ve never came across that
    Cary Robbins
    @carymrobbins
    Seems odd that this happens to you with ./gradlew as well
    Imran Settuba
    @sImttuba_gitlab
    Here it fails with a undiscovered java version
    I try to reimport the project
    I think I found the error
    the gradle wrapper is supper old
    Cary Robbins
    @carymrobbins
    We could update that in the same PR I'm sure