Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Imran Settuba
    @sImttuba_gitlab
    Yeah thats no problem
    ProjectComponents have an isomorphic service representation. Do you have any state in this component?
    Cary Robbins
    @carymrobbins
    Yes, there's a cache field. It's fairly primitive - https://github.com/carymrobbins/intellij-haskforce/blob/idea-2020.1/src/com/haskforce/codeInsight/HaskellCompletionCacheLoader.scala
    Imran Settuba
    @sImttuba_gitlab
    I’ve got that working now
    I have 3 failed tests
    Cary Robbins
    @carymrobbins
    awesome, want to push that up to a branch?
    Imran Settuba
    @sImttuba_gitlab
    I’ll send in the link, when the PR is open
    Cary Robbins
    @carymrobbins
    :tada:
    Imran Settuba
    @sImttuba_gitlab
    done carymrobbins/intellij-haskforce#429
    Cary Robbins
    @carymrobbins
    @sImttuba_gitlab Appreciate that, left some comments.
    Imran Settuba
    @sImttuba_gitlab
    Read and added changes. What do you wanna call the listener?
    This listener is much more powerful, if you consider the sort of optimizations you can do over each phase over the lifecycle
    removing a shit tone of boiler plate
    Cary Robbins
    @carymrobbins

    What do you wanna call the listener?

    I assume you are talking about HaskellCompletionCacheLoader ? I think for now the current name might be ok. It's used in other places so likely easier to just leave the current name now.

    Imran Settuba
    @sImttuba_gitlab
    No, nvm. In my ide it only shows the 2019.3 API’s so I can’t see those depreecation errors your refering to
    Cary Robbins
    @carymrobbins
    Try compiling with ./gradlew test
    You might also need to refresh the gradle project in your IDE so it will use the 2020.1 API
    Imran Settuba
    @sImttuba_gitlab
    did that multiple times
    I doesn’t compile locally because the build set up is a bit weird. It still doesn’t upload the 2020.1 libs
    Would be nice if you could chime in I removed the change where you showed me the error
    Cary Robbins
    @carymrobbins
    When you run ./gradlew test does it download 2020.1 resources?
    Imran Settuba
    @sImttuba_gitlab
    nop
    I checked gradle and it does still kep the 2019.3 versions around
    Cary Robbins
    @carymrobbins
    Yes, it will keep them cached I believe, unless you remove them
    Imran Settuba
    @sImttuba_gitlab
    also the gradle intelliJ plugin version needs to be updated
    if we wanna go for 2020.1
    Already did multiple times and gradle just adds them after cleaning them or removing them manually
    please feel free to add commits if you have it working
    I send you an invite to push into the PR
    Cary Robbins
    @carymrobbins
    Awesome, will do
    Just have work-work stuff to do first
    As for debugging your issue, may want to check here -
    % ls -1 ~/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIC
193.5233-EAP-CANDIDATE-SNAPSHOT
2019.2.1
2019.3
2019.3.1
2020.1
LATEST-EAP-SNAPSHOT
    Imran Settuba
    @sImttuba_gitlab

    No problem, didn’t wanted to be pushy. 

    193-EAP-SNAPSHOT
2019.2
2019.2.1
2019.2.4
2019.3
2019.3.1
2019.3.3
2019.3.4
2020.1
2020.1.1
LATEST-EAP-SNAPSHOT

    Those are my results

    Cary Robbins
    @carymrobbins
    weird, so you do have the 2020 sources
    Imran Settuba
    @sImttuba_gitlab
    Yep. But the project doesn’t load them to the plugiin. I ‘ve never came across that
    Cary Robbins
    @carymrobbins
    Seems odd that this happens to you with ./gradlew as well
    Imran Settuba
    @sImttuba_gitlab
    Here it fails with a undiscovered java version
    I try to reimport the project
    I think I found the error
    the gradle wrapper is supper old
    Cary Robbins
    @carymrobbins
    We could update that in the same PR I'm sure
    Imran Settuba
    @sImttuba_gitlab
    yes updating the wrapper worked now I see the API's
    Cary Robbins
    @carymrobbins
    awesome!
    Imran Settuba
    @sImttuba_gitlab
    I fixed the cache, but still having the lexer error. Probably someone with more knowledge about the gramma may check that later.
    Cary Robbins
    @carymrobbins
    those tests are flaky in some cases, i think when run from intellij, maybe they work better when doing ./gradlew test. Something about the OS and unicode. Either way, if they pass on CI I'm good with it regardless of if they pass locally.
    Imran Settuba
    @sImttuba_gitlab
    Ok. I think CI will only kick in, when the branch targets master.
    But feel free to leave a review, when you have time
    Cary Robbins
    @carymrobbins
    Will do, thanks Imran!
    Cary Robbins
    @carymrobbins
    Looks great, I'm going to push up another commit to make just a few modifications. Running the test suite now, then will try out the IDE and make sure everything still works.
    Imran Settuba
    @sImttuba_gitlab
    Nice :)
    Cary Robbins
    @carymrobbins
    @sImttuba_gitlab I went ahead and merged your branch. I need to do more testing, should hopefully get that done and get a release out over the weekend. In the meantime, building my branch idea-2020.1 with ./gradlew assemble can get you an installable HaskForce plugin zip.