Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 19 17:21
    bglusman added as member
  • May 01 2015 13:31
    bglusman commented on c9b840b
  • May 01 2015 13:20
    bglusman commented on 5b38f0d
  • May 01 2015 13:19
    bglusman commented on 1b8eba9
  • May 01 2015 13:17
    bglusman commented on 2acebe2
  • May 01 2015 13:16
    bglusman opened #5
  • May 01 2015 13:13
    bglusman closed #4
  • May 01 2015 13:13
    bglusman commented #4
  • May 01 2015 00:19

    bglusman on resolve_upstream_conflicts_in_volt_gem

    Handle bug in rack calling each… (compare)

  • Apr 30 2015 21:13

    bglusman on resolve_upstream_conflicts_in_volt_gem

    Fixes one error, but reveals an… (compare)

  • Apr 29 2015 19:07

    bglusman on resolve_upstream_conflicts_in_volt_gem

    Sync commit with bglusman/volt … (compare)

  • Apr 28 2015 23:22
    pencilcheck commented #4
  • Apr 28 2015 21:03
    ybur-yug commented #4
  • Apr 28 2015 20:54
    bglusman opened #4
  • Apr 28 2015 20:50

    bglusman on wrapperize_volt

    call index_ready via handler, b… (compare)

  • Apr 28 2015 20:34

    bglusman on wip_experiment_server_rendering_component

    Failed experiment to try and re… (compare)

  • Apr 28 2015 18:12

    bglusman on wrapperize_volt

    Generate dependencies dynamical… (compare)

  • Apr 28 2015 14:59

    bglusman on wrapperize_volt

    generalize hardcoded to use con… (compare)

  • Apr 28 2015 14:18

    bglusman on wrapperize_volt

    Squash pencilcheck changes toge… (compare)

  • Apr 28 2015 14:10

    bglusman on wrapperize_volt

    Untrack log files Should mimic how Page is setup … Hardcoding now but it was calli… and 3 more (compare)

Brian Glusman
@bglusman
@pencilcheck made some progress, now stuck somewhere totally different, FYI :-)
catch up later
pushing up changes to same branch
Penn Su
@pencilcheck
:O
cool
Brian Glusman
@bglusman
woo hoo! I think things are basically working, with one minor/weird monkey patch in rack (for something that looks like it may have been added for a bug fix itself, so should investigate and possibly open our own bug if it really is an error)
Penn Su
@pencilcheck
ok
Brian Glusman
@bglusman
there’s one new strange error where client is requesting components/main.map, maybe source map? but it works as it did before, so definite progress!
I guess maybe I’ll open up PR to volt with changes now too
Brian Glusman
@bglusman
opened volt PR
Penn Su
@pencilcheck
It's the new code for debugging I suppose
Brian Glusman
@bglusman
@pencilcheck not sure I understand, unless you mean there’s still debugging to do, in which case, yes for sure :-)
I’m trying to get a todo rails app running with third-rail now, so far it’s… dicey…have two different todo apps I’ve tried actually and both give same confusing/weird error that String has no safe_concat method, which is… confusing… because they don’t in rails either, that’s a helper method which a string is passed INTO, and I can’t find any code that calls that on an object… I guess it must be trying to call the helper from a block getting eval’d in a string’s instance eval or something? not even sure how to debug/think about that
experimenting with workaround defining safe_concat on string, but doubt that’s a real option
Brian Glusman
@bglusman
offender seems to be form_tag_in_block method in action_view/lib/action_view/helpers/form_tag_helper.rb
though could happen in multiple places
Brian Glusman
@bglusman
@catmando crap, I don’t know if this helper thing you’re doing with @view_flow is going to work Mitch, it seems to work for simple case, but pretty sure that’s what’s breaking the form helpers etc… I hadn’t even know about the form_view and output_buffer internals before, not sure how to think this through, but FYI, that’s my current diagnosis/blocker
Brian Glusman
@bglusman
could maybe try and turn it on its head and have rails do all rendering? experimenting with calling helper with yield output, dunno
Brian Glusman
@bglusman
There’s something I totally don’t understand going on in rails template render, I was thinking the problem was the layout’s call to volt_layout helper, butthe error actually happens before that when theres a form_tag helper called
just thinking out loud/keeping some notes here to discuss if/when any of the rest of you have time :-)
Brian Glusman
@bglusman
Ugh, volt PR had merge conflicts, which I resolved, and volt’s tests pass, but think third rail is broken after changes, and the only errors are client side and not that helpful…I feel kind of under water, but I’ll see if I can keep poking at/figure out what’s wrong, just a heads up
yburyug
@ybur-yug
@bglusman im on a business trip through mid-day tomorrow but will gladly hop on and pair and see if another set of eyes helps or if youve something specific I can stab at solo I could tonight.
Brian Glusman
@bglusman
@ybur-yug thanks for offer… some other eyes and attention would be good, I may be taking a break from third-rail until/unless I have inspiration or more confidence/direction, I updated PR to volt twice yesterday, but don’t even know what to aim at now, or if it getting merged in in current state is a meaningful milestone or not… it’d be a start I guess, but I’m not expecting third-rail to be a major focus for rest of RC unless someone else get’s substantially involved, too many moving parts and conflicting priorities.
seeing what you can still get to work, and reproducing/understanding the form_tag helper conundrum would be awesome though, specifically I think it’s only form_tag with a block passed in which I think triggers the attempt to call safe_concat on string. Maybe when @pencilcheck or @catmando have time to look/pair on it, but I’m going through a bit of anxiety/frustration so working on slightly more self contained projects for a while is my plan until/unless I have more support
Mitch VanDuyn
@catmando
@bglusman - i never tested the @viewflow thing very much, so indeed it may be only works for trivial cases.
Penn Su
@pencilcheck
kinda busy atm
will look into it when I have more time
but nice job
Brian Glusman
@bglusman
@catmando no i don’t think it is viewflow after all
it seems like somehow blocks to view helpers, at least form_tag, are getting instance eval’d in the wrong context, like in a string instead of in the view or something?
Working on it got complicated by trying to keep the volt PR up to date, so now it doesn’t work and I don’t know what to do… I took a break from focusing on it, but if either of you have time and want to pair on/investigate together that’s cool…
Ryan asked me to split up the PR a little bit, haven’t responded or decided what’s sane, not even 100% sure if it was clear to me how he wanted it broken up...
probably should forget PR until we have it working better I guess, but the fact that it no longer works on latest volt at all feels like a bigger problem, hard to prioritize
Mitch VanDuyn
@catmando
Folks - just to let you know where I am at with this:
I spent some time working with react.rb (thin opal-ruby wrapper on react js) and it works wonderfully. For my specific needs (i.e. working with a large legacy project) this seems to be a much better way to go. So for now I am going to focus on using react. I still think volt is a very very cool project, and definitely a good option for a clean sheet design.
Brian Glusman
@bglusman
@catmando so you have no further interest in contributing to third rail? I also used react.rb for my tetris game, mostly worked great though I never got keypress events to work natively, had to hack around it using jQuery (and not even opal-jQuery, that gave me problems sadly). Would be interesting if we could make some ruby-react components, maybe isomorphically, and/or allow react components to be easily usable within volt, but given how stuck I was getting in third-rail, if you’re no longer involved it seems unlikely it has much life left, unless @pencilcheck and/or others want to step up and help me with it
Feels to me like if react.rb fills your needs than third-rail/volt was never really the thing you needed/wanted, but maybe I’m misunderstanding
Mitch VanDuyn
@catmando
Key events seem to work okay. Isomorphic rendering works fine.
I hate to switch teams like this but I do have to meet short term business goals.
Volt is just not a good match for a brown field site. Sorry if I have let you down.
Penn Su
@pencilcheck
hm
react.rb interesting
Mitch VanDuyn
@catmando
@pencilcheck - we can chat abt it on the react.rb gitter
Penn Su
@pencilcheck
I can't find the repo on gitter
Penn Su
@pencilcheck
ah, I'm stupid :P thx
@bglusman I think we will just have to come back from time to time, right now I don't have urgent need as well ...
Brian Glusman
@bglusman
@pencilcheck / @catmando yeah, I never had an urgent need, I just thought it would be awesome and help volt gain traction
but it got a bit sticky, and I may not be up to figuring out the issues on my own, though if either of you or someone else want to pair and try and unravel things, it would be nice to get a minimally viable release out, and/or get the changes merged into volt… but seems not a priority for now
Punita Ojha
@punitaojha
This message was deleted
Mitch VanDuyn
@catmando
@punitaojha nobody uses this chat any more