Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Ross A. Baker
    @rossabaker
    Yeah, it's the default answer in Scala right now.
    I would like to make something better, and have some ideas, but life is hectic right now. :smile:
    Tim Spence
    @TimWSpence
    Well I’m sure it would be very well received if you ever do get the time!

    Thanks for the PR Chris! I just had 2 qq’s:

    1. Is that running rvm/gem install on every build? I couldn’t see anything which would suggest it’s cached
    2. Will that cross-build work currently? I just tried adding “2.11.12” to crossScalaVersions and running sbt +test locally and it failed with some type inference errors

    Just tagging @ChristopherDavenport in case this got lost in the chat. (1) is mainly out of curiosity and (2) I may have missed something super obvious - I haven’t much experience of worrying about 2.11 compatibility

    Ross A. Baker
    @rossabaker
    Hmm. Chris' PR succeed, and builds for 2.11.
    Oh, not necessarily. Chris' Travis PR is checked by Circle CI.
    Tim Spence
    @TimWSpence
    Yup! :joy:
    The old who tests the tests problem
    Ross A. Baker
    @rossabaker
    So, Chris has it set up to worry about 2.11 compatibility and fail when you accidentally break it.
    That's the good news.
    The bad news is that it's apparently already broken.
    I'm seeing if I can reproduce.
    That's annoying that the inference is better on 2.12. Most of the time those do about the same thing. 2.13 is where it gets miserable.
    Mostly around collections. Otherwise, even 2.13 is pretty easy.
    Oh, I bet this is a Java8 issue.
    Scala 2.12 lets you use Scala functions where Java functions are needed. 2.11 doesn't give you that out of the box.
    Tim Spence
    @TimWSpence
    Oh yeah, I got the intention of Chris’ change, I was just saying it needs a code change as well. Which you have now done so thank you very much! :) Although it looked like that library also supports .asJava syntax which might look slightly less nasty?
    Ross A. Baker
    @rossabaker
    Oh... yeah, definitely. I was surprised how ugly it was.
    .asJava is more consistent with the more familiar JavaConverters
    Well, or not:
    [error] /home/ross/src/cats-stm/core/src/main/scala/io/github/timwspence/cats/stm/STM.scala:180:44: type mismatch;
    [error]  found   : <error> => <error>
    [error]  required: ?{def asJava: ?}
    [error] Note that implicit conversions are not applicable because they are ambiguous:
    [error]  both method enrichAsJavaConsumer in trait Priority1FunctionConverters of type [T](sf: T => Unit)scala.compat.java8.functionConverterImpls.RichFunction1AsConsumer[T]
    [error]  and method enrichAsJavaIntFunction in trait Priority1FunctionConverters of type [R](sf: Int => R)scala.compat.java8.functionConverterImpls.RichFunction1AsIntFunction[R]
    [error]  are possible conversion functions from <error> => <error> to ?{def asJava: ?}
    [error]         entry.tvar.pending.updateAndGet((m => m + (txId -> pending)).asJava)
    Christopher Davenport
    @ChristopherDavenport
    :laughing: Thats an error message.
    So the plan is merge ross’s then enable ci, then integrate mine?
    Tim Spence
    @TimWSpence
    Ouch! That's a shame! Yeah I'll merge Ross's. Surely we need to merge yours to enable CI Chris? Or was that what you meant?
    Christopher Davenport
    @ChristopherDavenport
    Right, once you merge ross’s we can turn on CI and make sure it all goes smoothly.
    Tim Spence
    @TimWSpence
    Cool. I'll be home shortly so I'll merge it then
    Just did it on my phone instead. Thanks Ross!
    I guess I need to enable a build on Travis before we merge yours Chris?
    Christopher Davenport
    @ChristopherDavenport
    I think that would be a good choice.
    Tim Spence
    @TimWSpence
    😂
    I just wanted to check there was nothing else I needed to do
    Christopher Davenport
    @ChristopherDavenport
    Those environmental variables in travis get you set for very quick iteration.
    Then we should get the project on scala-steward so that way you can get automatic updates. I can walk you through the process, or with your permission I can add it.
    Tim Spence
    @TimWSpence
    Cool, I’ll enable and merge now
    What is scala steward?
    Christopher Davenport
    @ChristopherDavenport
    https://github.com/fthomas/scala-steward - A project that will automatically file PR’s to your repository when dependencies update.
    You just need to add TimWSpence/cats-stm to this file
    Tim Spence
    @TimWSpence
    Thanks!
    Just generating the github token
    Is there any way to restrict it to just have access to cats-stm?
    the default seems to be access to all my private repos AFAICT
    Christopher Davenport
    @ChristopherDavenport
    Yeah. Unfortunately thats how the tokens work.
    Tim Spence
    @TimWSpence
    ouch
    Christopher Davenport
    @ChristopherDavenport
    I use one offs that way if I need to replace them I can kill off the token if it leaks.
    Tim Spence
    @TimWSpence
    Yep, called it cats-stm so I can keep track of it :)
    Christopher Davenport
    @ChristopherDavenport
    Note: When this get traction that documentation branch will easily become your largest source of commits.
    Worrisome travis log - here
    Tim Spence
    @TimWSpence
    argh special characters in pw
    Christopher Davenport
    @ChristopherDavenport
    Likely snapshot will fail but site will go through, Unless failure of first after_success blocks the second step
    @rossabaker I’ve never seen this before, have you Link
    @TimWSpence Do you have a gh-pages branch?
    Hmmm, you do.